Page MenuHomeFreeBSD

[net80211] Quieten the logging from ieee80211_vht_get_vhtflags()
ClosedPublic

Authored by adrian on Aug 25 2025, 12:52 AM.
Referenced Files
F132078392: D52142.id161283.diff
Mon, Oct 13, 11:29 AM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
Unknown Object (File)
Sun, Oct 12, 12:28 AM
Unknown Object (File)
Mon, Oct 6, 7:12 PM
Unknown Object (File)
Fri, Sep 26, 6:26 PM

Details

Summary

The commit in Fixes: introduced logging the output bits from
ieee80211_vht_get_vhtflags(). This ends up causing quite a lot
of logging when net80211 is doing things like processing
received beacons.

So just remove the logging; if it's needed again then a developer
can add it back to that location, or just use dtrace to capture
the return value.

Fixes: 4bf049bfeefd9

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz requested changes to this revision.Aug 25 2025, 5:47 AM
bz added a subscriber: bz.
bz added inline comments.
sys/net80211/ieee80211_ht.c
1936

On which (properly done) driver do you see (say) 10 beacons a second?

My net80211 wlanstats says I saw 35 beacons in 9 hours of uptime.
For iwx see email; beacon filtering is disabled (or not finished).

How much doe you see on rtwn or iwn?

I'd suggest to solve it this way:

if (0} IEEE80211_NOTE...

Disabling the logging if it really bothers you and you think this is an issue here.

This revision now requires changes to proceed.Aug 25 2025, 5:47 AM
sys/net80211/ieee80211_ht.c
1936

I'll disable it like this.

For rtwn, that processes all the beacons all the time (they're not ONLY handled in firmware):

adrian@francine:~ % wlanstats -i wlan0 | grep -i beacon
36113             rx beacon frames
1                 beacon miss events handled
bz requested changes to this revision.Sep 1 2025, 1:06 AM
bz added inline comments.
sys/net80211/ieee80211_ht.c
1939

Can you please reduce this to one line changed?

This revision now requires changes to proceed.Sep 1 2025, 1:06 AM

ok, reduced to one line diff, please re-review! thanks!

This revision is now accepted and ready to land.Sep 7 2025, 7:46 PM