Page MenuHomeFreeBSD
Differential D52649

net80211: document some of the crypto/key functions
ClosedPublic
Actions

Authored by adrian on Sat, Sep 20, 9:32 PM.
Tags
Referenced Files
F132541178: D52649.diff
Fri, Oct 17, 7:56 PM
Unknown Object (File)
Sun, Oct 12, 10:51 PM
Unknown Object (File)
Sun, Oct 12, 6:59 PM
Unknown Object (File)
Sun, Oct 12, 5:17 PM
Unknown Object (File)
Sun, Oct 12, 4:43 PM
Unknown Object (File)
Sun, Oct 12, 11:23 AM
Unknown Object (File)
Sun, Oct 12, 11:23 AM
Unknown Object (File)
Sun, Oct 12, 11:22 AM
View All 28 Files
Subscribers
bz
glebius
imp
melifaro

Details

Reviewers
None
Group Reviewers
wireless
Commits
rG1f76551e1a5e: net80211: document some of the crypto/key functions
Summary

This documents the following functions:

  • ieee80211_is_key_global()
  • ieee80211_is_key_unicast()
  • ieee80211_crypto_get_key_wepidx()
  • ieee80211_crypto_get_keyid()
  • ieee80211_crypto_get_txkey()
  • ieee80211_crypto_encap()
  • ieee80211_crypto_decap()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.Sat, Sep 20, 9:32 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSat, Sep 20, 9:32 PM
adrian requested review of this revision.Sat, Sep 20, 9:32 PM
Harbormaster completed remote builds in B67211: Diff 162499.Sat, Sep 20, 9:32 PM
adrian added a parent revision: D52524: iwx: add some missed beacon debugging.Sat, Sep 20, 9:33 PM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian updated this revision to Diff 162500.Sat, Sep 20, 9:36 PM

update

Harbormaster completed remote builds in B67212: Diff 162500.Sat, Sep 20, 9:36 PM
bz added a subscriber: bz.Sun, Sep 21, 12:13 AM

Do you also want to improve the IEEE80211_CRYPTO(9) man page?

I was wondering who's doing all the spell checking/grammar checks/... of code comments. I cannot currently do that. You might want to add someone for that as reviewer.

sys/net80211/ieee80211_crypto.c
710

MIC or MMIC?

adrian added a child revision: D52652: iwx: re-add sequence numbers for non-AMPDU, preserving previous behaviour.Sun, Sep 21, 2:05 AM
adrian added inline comments.Mon, Oct 6, 10:11 PM
sys/net80211/ieee80211_crypto.c
710

Yeah, it should be MIC. For TKIP it's the MMIC, for WEP it's the ICV, for CCMP/GCMP it's the ICV. (That's why we now have RX_F_ICV_STRIP, RX_F_MIC_STRIP, RX_F_MMIC_STRIP.)

lemme go clarify that.

adrian updated this revision to Diff 163669.Mon, Oct 6, 10:13 PM

update from bz

Harbormaster completed remote builds in B67599: Diff 163669.Mon, Oct 6, 10:13 PM
adrian marked an inline comment as done.Mon, Oct 6, 10:13 PM
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Oct 8, 3:17 AM
Closed by commit rG1f76551e1a5e: net80211: document some of the crypto/key functions (authored by adrian). · Explain Why
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG1f76551e1a5e: net80211: document some of the crypto/key functions.

Revision Contents
Changeset List

PathSize
sys/
net80211/
28 lines
87 lines

Diff 163734

View Options

sys/net80211/ieee80211.c

Loading...
View Options

sys/net80211/ieee80211_crypto.c

Loading...