Page MenuHomeFreeBSD

net80211: update drivers to allocate sequence numbers in the raw path
ClosedPublic

Authored by adrian on Wed, Jul 8, 5:54 AM.
Referenced Files
F164465496: D58098.diff
Sat, Aug 1, 5:49 AM
Unknown Object (File)
Sat, Jul 25, 9:01 AM
Unknown Object (File)
Fri, Jul 24, 7:56 AM
Unknown Object (File)
Mon, Jul 20, 10:12 PM
Unknown Object (File)
Sun, Jul 19, 3:13 PM
Unknown Object (File)
Fri, Jul 17, 8:57 AM
Unknown Object (File)
Thu, Jul 16, 3:51 AM
Unknown Object (File)
Thu, Jul 16, 2:18 AM
Subscribers

Details

Summary

A bunch of drivers weren't properly converted. I mistakenly
put a call to ieee80211_output_seqno_assign() wherever the
crypto header was added, which isn't exactly correct.
There are plenty of drivers which don't share enough of their
raw and normal transmit path code for that to hold true.

So after some manual review, it looks like I've captured the
places (outside of iwn(4) which I committed earlier) where
I missed ieee80211_output_seqno_assign() calls.

  • For bwi(4) and bwn(4) I refactored it out into a place that is common enough and happens in the same lock hold window, so it's serialised.
  • For the rest, it's just plain missing from the raw path.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable