Page MenuHomeFreeBSD

net80211: update drivers to allocate sequence numbers in the raw path
Needs ReviewPublic

Authored by adrian on Wed, Jul 8, 5:54 AM.
Referenced Files
F162279774: D58098.id181516.diff
Sat, Jul 11, 4:03 PM
Unknown Object (File)
Fri, Jul 10, 3:26 PM
Unknown Object (File)
Thu, Jul 9, 7:45 PM
Unknown Object (File)
Wed, Jul 8, 5:55 AM
Subscribers

Details

Reviewers
None
Group Reviewers
wireless
Summary

A bunch of drivers weren't properly converted. I mistakenly
put a call to ieee80211_output_seqno_assign() wherever the
crypto header was added, which isn't exactly correct.
There are plenty of drivers which don't share enough of their
raw and normal transmit path code for that to hold true.

So after some manual review, it looks like I've captured the
places (outside of iwn(4) which I committed earlier) where
I missed ieee80211_output_seqno_assign() calls.

  • For bwi(4) and bwn(4) I refactored it out into a place that is common enough and happens in the same lock hold window, so it's serialised.
  • For the rest, it's just plain missing from the raw path.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74608
Build 71491: arc lint + arc unit