Page MenuHomeFreeBSD
Differential D50407

net80211: remove direct references to ifp->if_xname
ClosedPublic
Actions

Authored by adrian on May 18 2025, 4:59 AM.
Tags
Referenced Files
F170716794: D50407.id155676.diff
Sun, Sep 6, 4:45 AM
F170665246: D50407.id156012.diff
Sat, Sep 5, 10:00 PM
Unknown Object (File)
Fri, Sep 4, 10:47 AM
Unknown Object (File)
Fri, Sep 4, 8:22 AM
Unknown Object (File)
Fri, Sep 4, 5:31 AM
Unknown Object (File)
Wed, Sep 2, 11:41 PM
Unknown Object (File)
Wed, Sep 2, 2:48 PM
Unknown Object (File)
Wed, Sep 2, 9:20 AM
View All Files
Subscribers
bz
emaste
glebius
imp
melifaro

Details

Reviewers
bz
Group Reviewers
wireless
Commits
rG249f14c87fd5: net80211: remove direct references to ifp->if_xname
Summary
  • change ieee80211_get_vap_ifname() to use if_name()
  • migrate the other references of ifp->if_xname to ieee80211_get_vap_ifname()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adrian created this revision.May 18 2025, 4:59 AM
Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMay 18 2025, 4:59 AM
adrian requested review of this revision.May 18 2025, 4:59 AM
Harbormaster completed remote builds in B64259: Diff 155641.May 18 2025, 4:59 AM
adrian added a parent revision: D50406: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c.May 18 2025, 5:00 AM
adrian added a reviewer: wireless.
adrian added a project: wireless.
adrian updated this revision to Diff 155644.May 18 2025, 5:58 AM

rebase

Harbormaster completed remote builds in B64262: Diff 155644.May 18 2025, 5:58 AM
adrian mentioned this in D50023: net80211: move references to IF_LLADDR() into ieee80211_freebsd.c.May 18 2025, 2:58 PM
bz accepted this revision.May 18 2025, 8:13 PM
bz added a subscriber: bz.

LGTM

This revision is now accepted and ready to land.May 18 2025, 8:13 PM
adrian updated this revision to Diff 155676.May 19 2025, 4:11 AM

rebase

This revision now requires review to proceed.May 19 2025, 4:11 AM
Harbormaster completed remote builds in B64282: Diff 155676.May 19 2025, 4:11 AM
emaste added a subscriber: emaste.May 22 2025, 4:44 PM
bz requested changes to this revision.May 24 2025, 11:29 PM

just style; so do and push them; no need to upload again

sys/net80211/ieee80211_freebsd.c
1144

return (); sorry seem to have missed it because it was like that before

This revision now requires changes to proceed.May 24 2025, 11:29 PM
adrian updated this revision to Diff 155996.May 25 2025, 1:58 AM

comments from bz

Harbormaster completed remote builds in B64415: Diff 155996.May 25 2025, 1:58 AM
bz accepted this revision.May 25 2025, 1:39 PM
This revision is now accepted and ready to land.May 25 2025, 1:39 PM
Closed by commit rG249f14c87fd5: net80211: remove direct references to ifp->if_xname (authored by adrian). · Explain WhyMay 25 2025, 3:25 PM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG249f14c87fd5: net80211: remove direct references to ifp->if_xname.

Revision Contents
Changeset List

PathSize
sys/
net80211/
2 lines
4 lines
2 lines

Diff 156012

View Options

sys/net80211/ieee80211_freebsd.c

Loading...
View Options

sys/net80211/ieee80211_scan.c

Loading...
View Options

sys/net80211/ieee80211_wds.c

Loading...