Differential D50029

e6000sw: unlock the driver lock in the error path during attach
ClosedPublic
Actions

Authored by adrian on Apr 25 2025, 6:39 PM.

Tags

None

Referenced Files

	F156789979: D50029.diff
	Sat, May 16, 9:57 AM

	Unknown Object (File)
	Thu, May 14, 7:29 PM

	Unknown Object (File)
	Mon, Apr 27, 12:00 PM

	Unknown Object (File)
	Mon, Apr 27, 11:33 AM

	Unknown Object (File)
	Sun, Apr 19, 9:48 AM

	Unknown Object (File)
	Sun, Apr 19, 1:24 AM

	Unknown Object (File)
	Sun, Apr 19, 1:16 AM

	Unknown Object (File)
	Fri, Apr 17, 12:13 PM

View All 72 Files

Subscribers

Details

Reviewers

Commits

rGaf298663e9ff: e6000sw: unlock the driver lock in the error path during attach

Summary

The driver sleep lock was being held during most of the error paths,
and not unlocking it will panic the kernel during detach. So, fix it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Apr 25 2025, 6:39 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 25 2025, 6:39 PM

adrian requested review of this revision.Apr 25 2025, 6:39 PM

Harbormaster completed remote builds in B63734: Diff 154298.Apr 25 2025, 6:39 PM

adrian added a parent revision: D50028: e6000sw: always compile it.Apr 25 2025, 6:47 PM

adrian added a child revision: D50030: e6000sw: stop / drain the taskqueue (and tick) during detach.

imp accepted this revision.Apr 25 2025, 7:37 PM

This revision is now accepted and ready to land.Apr 25 2025, 7:37 PM

Closed by commit rGaf298663e9ff: e6000sw: unlock the driver lock in the error path during attach (authored by adrian). · Explain WhyApr 27 2025, 6:39 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGaf298663e9ff: e6000sw: unlock the driver lock in the error path during attach.

Revision Contents
Changeset List

Path

Size

sys/

dev/

etherswitch/

e6000sw/

1 line

Diff 154348

sys/dev/etherswitch/e6000sw/e6000sw.c

Loading...