Page MenuHomeFreeBSD

ath_rate_sample: fix setting HT rates
ClosedPublic

Authored by adrian on Mar 1 2025, 10:40 PM.
Referenced Files
Unknown Object (File)
Mon, Oct 13, 10:14 PM
Unknown Object (File)
Sun, Oct 12, 2:46 PM
Unknown Object (File)
Fri, Oct 3, 3:04 PM
Unknown Object (File)
Thu, Oct 2, 4:23 AM
Unknown Object (File)
Thu, Oct 2, 1:15 AM
Unknown Object (File)
Wed, Oct 1, 3:32 PM
Unknown Object (File)
Tue, Sep 30, 8:36 AM
Unknown Object (File)
Mon, Sep 15, 11:55 PM
Subscribers

Details

Summary

ieee80211_node_set_txrate_ht_mcsrate() takes an MCS rate from 0..76,
the high bit (IEEE80211_RATE_MCS) must not be set.

This is definitely my fault - I likely didn't get to testing this
diff when I changed it from ieee80211_node_set_txrate_dot11rate()
just before landing.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz added a subscriber: bz.

Commit message:

Fixes: 7067450010931479f8dd97e51e4c5bf6a4d34c7e

Once could argue we should add a warning to ieee80211_node_set_txrate_ht_mcsrate() if the high bit is set and clear it but the mcs > 76 check will also catch it quickly.

This revision is now accepted and ready to land.Mar 1 2025, 11:01 PM
This revision was automatically updated to reflect the committed changes.