Differential D49197

ath_rate_sample: fix setting HT rates
ClosedPublic
Actions

Authored by adrian on Mar 1 2025, 10:40 PM.

Details

Reviewers

Group Reviewers

wireless

Commits

rG10c633ab1204: ath_rate_sample: fix setting HT rates

Summary

ieee80211_node_set_txrate_ht_mcsrate() takes an MCS rate from 0..76,
the high bit (IEEE80211_RATE_MCS) must not be set.

This is definitely my fault - I likely didn't get to testing this
diff when I changed it from ieee80211_node_set_txrate_dot11rate()
just before landing.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Mar 1 2025, 10:40 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 1 2025, 10:40 PM

adrian requested review of this revision.Mar 1 2025, 10:40 PM

Harbormaster completed remote builds in B62717: Diff 151727.Mar 1 2025, 10:40 PM

adrian added a parent revision: D49196: ath: fix 20MHz HT short-gi logic..Mar 1 2025, 10:41 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

Commit message:

Fixes: 7067450010931479f8dd97e51e4c5bf6a4d34c7e

Once could argue we should add a warning to ieee80211_node_set_txrate_ht_mcsrate() if the high bit is set and clear it but the mcs > 76 check will also catch it quickly.

This revision is now accepted and ready to land.Mar 1 2025, 11:01 PM

Closed by commit rG10c633ab1204: ath_rate_sample: fix setting HT rates (authored by adrian). · Explain WhyMar 1 2025, 11:33 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG10c633ab1204: ath_rate_sample: fix setting HT rates.

adrian added a child revision: D49199: net80211: add the specific 802.11-2020 references to VHT IEs.Mar 2 2025, 1:10 AM