e6000sw: stop / drain the taskqueue (and tick) during detach
ClosedPublic
Actions

Authored by adrian on Fri, Apr 25, 6:42 PM.

Details

Reviewers

Commits

rGee7f62faa893: e6000sw: stop / drain the taskqueue (and tick) during detach

Summary

Although the tick isn't running every hz right now, when it /is/
running at hz, the shutdown path will race with an existing running
tick routine, causing unpredictable panics.

Introduce a shutdown flag which will abort doing the tick work if set
set the shutdown flag and start cancel/draining the taskqueue during detach.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Fri, Apr 25, 6:42 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Apr 25, 6:42 PM

Harbormaster completed remote builds in B63735: Diff 154299.Fri, Apr 25, 6:42 PM

adrian requested review of this revision.Fri, Apr 25, 6:42 PM

adrian added a parent revision: D50029: e6000sw: unlock the driver lock in the error path during attach.Fri, Apr 25, 6:47 PM

adrian added a child revision: D50031: e6000sw: schedule e6000sw_tick() to occur once a second.

adrian added a reviewer: imp.Sat, Apr 26, 5:03 AM

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Apr 27, 6:39 PM

Closed by commit rGee7f62faa893: e6000sw: stop / drain the taskqueue (and tick) during detach (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGee7f62faa893: e6000sw: stop / drain the taskqueue (and tick) during detach.

Revision Contents
Changeset List

Path

Size

sys/

dev/

etherswitch/

e6000sw/

e6000sw.c

18 lines

Diff 154349

View Options

sys/dev/etherswitch/e6000sw/e6000sw.c

e6000sw: stop / drain the taskqueue (and tick) during detachClosedPublicActions