Paths

Table of Contentst

Differential D49370

uath: add support for GCMP-128 encryption
AcceptedPublic
Actions

Authored by adrian on Sat, Mar 15, 2:06 AM.

Tags

Referenced Files

	Unknown Object (File)
	Wed, Mar 19, 6:54 PM

	Unknown Object (File)
	Wed, Mar 19, 6:50 PM

	Unknown Object (File)
	Wed, Mar 19, 3:25 PM

	Unknown Object (File)
	Tue, Mar 18, 2:51 PM

	Unknown Object (File)
	Sun, Mar 16, 9:57 PM

	Unknown Object (File)
	Sun, Mar 16, 8:19 PM

	Unknown Object (File)
	Sun, Mar 16, 10:04 AM

Subscribers

Details

Reviewers

Group Reviewers

Summary

Explicitly set the software ciphers; add support for GCMP-128.

Locally tested:

AR5523 11abg NIC, 2/5GHz STA operation, GCMP forced in wpa_supplicant.conf

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 62967
Build 59851: arc lint + arc unit

Event Timeline

adrian created this revision.Sat, Mar 15, 2:06 AM

Herald added a subscriber: imp. · View Herald TranscriptSat, Mar 15, 2:06 AM

adrian requested review of this revision.Sat, Mar 15, 2:06 AM

Harbormaster completed remote builds in B62931: Diff 152290.Sat, Mar 15, 2:06 AM

adrian added a parent revision: D49367: net80211: refactor out the AAD init code shared between GCMP and CCMP.Sat, Mar 15, 2:06 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D49392: net80211: document the crypto enmic/demic functions..Sun, Mar 16, 6:17 PM

bz requested changes to this revision.Tue, Mar 18, 10:53 AM

bz added a subscriber: bz.

bz added inline comments.

sys/dev/usb/wlan/if_uath.c
446	ieee80211_set_software_ciphers

This revision now requires changes to proceed.Tue, Mar 18, 10:53 AM

update from bz

Harbormaster completed remote builds in B62967: Diff 152404.Tue, Mar 18, 11:41 PM

bz accepted this revision.Wed, Mar 19, 12:34 PM

This revision is now accepted and ready to land.Wed, Mar 19, 12:34 PM

emaste added a subscriber: emaste.Wed, Mar 19, 1:19 PM

emaste added inline comments.

sys/dev/usb/wlan/if_uath.c
445	Can we have an assert in `ieee80211_set_software_ciphers` that enforces this?

adrian marked an inline comment as done.Thu, Mar 20, 4:32 AM

adrian added inline comments.

sys/dev/usb/wlan/if_uath.c
445	Can we have an assert in `ieee80211_set_software_ciphers` that enforces this? I'll think about to enforce it after this lands, and before I start liberally sprinkling this in chipsets as I test it. I'll likely need to go add a flag in the ieee80211com struct that says ieee80211_ifattach() has been called, so i'm not relying on BSDisms like our ifnet layer being init'ed. (Yeah I've been made aware again of our stack being ported to weird and wonderful places...)

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

wlan/

6 lines

Diff 152404

sys/dev/usb/wlan/if_uath.c

Loading...