Page MenuHomeFreeBSD

net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c
ClosedPublic

Authored by adrian on May 18 2025, 4:45 AM.
Referenced Files
F132130339: D50406.id155643.diff
Tue, Oct 14, 12:44 AM
Unknown Object (File)
Sun, Oct 12, 2:17 PM
Unknown Object (File)
Sun, Oct 12, 12:55 PM
Unknown Object (File)
Thu, Oct 2, 9:25 PM
Unknown Object (File)
Thu, Oct 2, 2:02 PM
Unknown Object (File)
Thu, Oct 2, 12:16 PM
Unknown Object (File)
Wed, Oct 1, 6:31 PM
Unknown Object (File)
Tue, Sep 30, 8:58 AM

Details

Summary
  • create ieee80211_vap_get_broadcast_address() to fetch the broadcast MAC address for the given VAP
  • refactor references to ifp->if_broadcastaddr -> ieee80211_vap_get_broadcast_address()

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz added a subscriber: bz.

Scrolling through apart from the local variable this looks good.

sys/net80211/ieee80211_freebsd.c
1328

Could pass vap->if_ifp here and save the local variable.

This revision is now accepted and ready to land.May 18 2025, 8:16 PM
This revision now requires review to proceed.May 19 2025, 4:11 AM
bz requested changes to this revision.May 24 2025, 11:27 PM

Just style.

sys/net80211/ieee80211_freebsd.c
1326

return (...)

sys/net80211/ieee80211_hostap.c
563

Can't say in Phabricator if indentation is right..

sys/net80211/ieee80211_wds.c
491

again indent unclear in Phabricator

This revision now requires changes to proceed.May 24 2025, 11:27 PM
This revision is now accepted and ready to land.May 25 2025, 1:38 PM