Details

Reviewers

Group Reviewers

wireless

Commits

rGa278d11a60e0: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c

Summary

create ieee80211_vap_get_broadcast_address() to fetch the broadcast MAC address for the given VAP
refactor references to ifp->if_broadcastaddr -> ieee80211_vap_get_broadcast_address()

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 64414
Build 61298: arc lint + arc unit

Event Timeline

adrian created this revision.May 18 2025, 4:45 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptMay 18 2025, 4:45 AM

adrian requested review of this revision.May 18 2025, 4:45 AM

Harbormaster completed remote builds in B64258: Diff 155640.May 18 2025, 4:45 AM

adrian added a parent revision: D50405: net80211: migrate if_flags, if_drvflags out of most source files.May 18 2025, 4:46 AM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D50407: net80211: remove direct references to ifp->if_xname.May 18 2025, 5:00 AM

rebase

Harbormaster completed remote builds in B64261: Diff 155643.May 18 2025, 5:58 AM

adrian mentioned this in D50023: net80211: move references to IF_LLADDR() into ieee80211_freebsd.c.May 18 2025, 2:58 PM

Scrolling through apart from the local variable this looks good.

sys/net80211/ieee80211_freebsd.c
1328	Could pass vap->if_ifp here and save the local variable.

This revision is now accepted and ready to land.May 18 2025, 8:16 PM

update from bz

This revision now requires review to proceed.May 19 2025, 4:11 AM

Harbormaster completed remote builds in B64281: Diff 155675.May 19 2025, 4:11 AM

comment from bz

Harbormaster completed remote builds in B64305: Diff 155724.May 20 2025, 4:44 AM

adrian marked an inline comment as done.May 20 2025, 4:45 AM

emaste added a subscriber: emaste.May 22 2025, 4:43 PM

Just style.

sys/net80211/ieee80211_freebsd.c
1326	return (...)
sys/net80211/ieee80211_hostap.c
563	Can't say in Phabricator if indentation is right..
sys/net80211/ieee80211_wds.c
491	again indent unclear in Phabricator

This revision now requires changes to proceed.May 24 2025, 11:27 PM

comments from bz

Harbormaster completed remote builds in B64414: Diff 155995.May 25 2025, 1:58 AM

bz accepted this revision.May 25 2025, 1:38 PM

This revision is now accepted and ready to land.May 25 2025, 1:38 PM

Closed by commit rGa278d11a60e0: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c (authored by adrian). · Explain WhyMay 25 2025, 3:25 PM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGa278d11a60e0: net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c.

net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 155995

sys/net80211/ieee80211_adhoc.c

sys/net80211/ieee80211_freebsd.h

sys/net80211/ieee80211_freebsd.c

sys/net80211/ieee80211_hostap.c

sys/net80211/ieee80211_ioctl.c

sys/net80211/ieee80211_output.c

sys/net80211/ieee80211_scan_sw.c

sys/net80211/ieee80211_wds.c

net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.cClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 155995

sys/net80211/ieee80211_adhoc.c

sys/net80211/ieee80211_freebsd.h

sys/net80211/ieee80211_freebsd.c

sys/net80211/ieee80211_hostap.c

sys/net80211/ieee80211_ioctl.c

sys/net80211/ieee80211_output.c

sys/net80211/ieee80211_scan_sw.c

sys/net80211/ieee80211_wds.c

net80211: refactor out ifp->if_broadcastaddr into ieee80211_freebsd.c
ClosedPublic
Actions

Revision Contents
Changeset List