rtwn: enable reception of BAR frames
Needs ReviewPublic
Actions

Authored by adrian on Tue, Apr 1, 12:44 AM.

Tags

Referenced Files

	F114418492: D49596.diff
	Sat, Apr 12, 8:24 AM

	F114409370: D49596.diff
	Sat, Apr 12, 6:08 AM

	F114409369: D49596.diff
	Sat, Apr 12, 6:08 AM

	F114409368: D49596.diff
	Sat, Apr 12, 6:08 AM

	F114409367: D49596.diff
	Sat, Apr 12, 6:08 AM

	F114409366: D49596.diff
	Sat, Apr 12, 6:08 AM

	Unknown Object (File)
	Wed, Apr 2, 6:25 PM

	Unknown Object (File)
	Wed, Apr 2, 1:59 PM

View All 12 Files

Subscribers

imp

Details

Reviewers

jrtc27

Group Reviewers

wireless

Summary

The RX filter wasn't enabling BAR frames, so we weren't receiving them
during normal operation.

Jessica noticed we WERE getting BAR frames, but only when promisc mode
is active. Which is a different set of bugs, but it did highlight
the differences here.

PR: kern/285822

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63237
Build 60121: arc lint + arc unit

Event Timeline

adrian created this revision.Tue, Apr 1, 12:44 AM

Herald added a subscriber: imp. · View Herald TranscriptTue, Apr 1, 12:44 AM

adrian requested review of this revision.Tue, Apr 1, 12:44 AM

adrian added a parent revision: D49575: net80211: validate control frame TA/RA before further processing.Tue, Apr 1, 12:45 AM

Harbormaster completed remote builds in B63237: Diff 152941.Tue, Apr 1, 12:45 AM

adrian added reviewers: wireless, jrtc27.Tue, Apr 1, 12:46 AM

adrian added a project: wireless.

adrian added a child revision: D49628: rtwn: don't treat UDP/TCP checksum failure as permanent failure.Wed, Apr 2, 12:01 AM

I don't know the register details there but in general it looks sane.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

if_rtwn.c

8 lines

Diff 152941

View Options

rtwn: enable reception of BAR framesNeeds ReviewPublicActions