Differential D49596

rtwn: enable reception of BAR frames
ClosedPublic
Actions

Authored by adrian on Apr 1 2025, 12:44 AM.

Details

Reviewers

jrtc27

Group Reviewers

wireless

Commits

rG5c74aa3abd4e: rtwn: enable reception of BAR frames

Summary

The RX filter wasn't enabling BAR frames, so we weren't receiving them
during normal operation.

Jessica noticed we WERE getting BAR frames, but only when promisc mode
is active. Which is a different set of bugs, but it did highlight
the differences here.

PR: kern/285822

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Apr 1 2025, 12:44 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 1 2025, 12:44 AM

adrian requested review of this revision.Apr 1 2025, 12:44 AM

adrian added a parent revision: D49575: net80211: validate control frame TA/RA before further processing.Apr 1 2025, 12:45 AM

Harbormaster completed remote builds in B63237: Diff 152941.Apr 1 2025, 12:45 AM

adrian added reviewers: wireless, jrtc27.Apr 1 2025, 12:46 AM

adrian added a project: wireless.

adrian added a child revision: D49628: rtwn: don't treat UDP/TCP checksum failure as permanent failure.Apr 2 2025, 12:01 AM

I don't know the register details there but in general it looks sane.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 23 2025, 2:04 AM

Closed by commit rG5c74aa3abd4e: rtwn: enable reception of BAR frames (authored by jrtc27, committed by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG5c74aa3abd4e: rtwn: enable reception of BAR frames.

Revision Contents
Changeset List

Path

Size

sys/

dev/

rtwn/

if_rtwn.c

8 lines

Diff 154132

View Options

rtwn: enable reception of BAR framesClosedPublicActions