Differential D49764

net80211: refactor sequence number assignment code
Needs ReviewPublic
Actions

Authored by adrian on Thu, Apr 10, 8:31 PM.

Details

Reviewers

None

Group Reviewers

wireless

Summary

Refactor out the sequence number assignment code for normal frames
and beacons.

Document the behaviour around fragments and packet lists.

Right now this should be a no-op; there's some verification code
in here to make sure that the TID selected by the existing code
matches the TID populated in the passed in mbuf/frame.

Locally tested:

rtwn(4), STA mode

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 63434
Build 60318: arc lint + arc unit

Event Timeline

adrian created this revision.Thu, Apr 10, 8:31 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptThu, Apr 10, 8:31 PM

adrian requested review of this revision.Thu, Apr 10, 8:31 PM

Harbormaster completed remote builds in B63434: Diff 153475.Thu, Apr 10, 8:31 PM

adrian added a parent revision: D49628: rtwn: don't treat UDP/TCP checksum failure as permanent failure.Thu, Apr 10, 8:36 PM

adrian added a reviewer: wireless.

adrian added a project: wireless.

adrian added a child revision: D49765: net80211: document the vap / device transmit paths, fragment node references.

I need to understand this code and the callers. That'll take time. Hopefully I'll find an hour next week.

sys/net80211/ieee80211_output.c
4205	Do you not want uint8_t arg_tid and a bool XXX to use as indicator; changing signedness and size of tid is a pain to deal with usually.
4209	uint8_t you can fold it down together with uint8_t tid, type;
4227	tid=%u