Page MenuHomeFreeBSD
Feed Advanced Search

Sun, Sep 15

adrian added a comment to D18593: mips32: move support for temporary mappings above KSEG0 to per-CPU data.

I have no complaints; I'm still stuck on mips32r2 and similar non-SMP hardware for these router things. I'll soon be moving to ARM though..

Sun, Sep 15, 5:32 AM

Thu, Sep 5

adrian committed rS351868: [lib80211] add initial VHT (11ac) channel ranges for FCC..
[lib80211] add initial VHT (11ac) channel ranges for FCC.
Thu, Sep 5, 3:55 PM

Jun 6 2019

adrian added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

@bz - once a packet (fragment in this case) has made it to it's destination, I would argue that you shouldn't needlessly drop that packet any more. (Host vs. Router behavior). An interface flapping frequently, and removing all enqueued fragments while doing this, would reduce the usability of such an interface from marginal to completely inoperable.
Using the ifp of the last received fragment rather the ifp of the initial one (in time, not relative offset) sounds to me like a good compromise.

Jun 6 2019, 4:01 PM

May 28 2019

adrian added a comment to D20433: [conf] reduce kernel size if there is no iflib & usb .

hm, the iflib bits are already in -head?

May 28 2019, 6:06 PM
adrian closed D20431: [ath] correct copy of queue info (found by pvs-studio).
May 28 2019, 6:05 PM
adrian committed rS348331: [ath_hal] Fix queue bits a bit.
[ath_hal] Fix queue bits a bit
May 28 2019, 6:05 PM
adrian added a comment to D20433: [conf] reduce kernel size if there is no iflib & usb .

I like this; but yeah we're going to need to add options iflib everywhere else to make the defaults work. Can you do that?

May 28 2019, 6:01 PM
adrian accepted D20431: [ath] correct copy of queue info (found by pvs-studio).
May 28 2019, 6:01 PM

May 20 2019

adrian committed rS347998: [mediatek] Add support for non-flash devices on the SPI bus of the Mediatek….
[mediatek] Add support for non-flash devices on the SPI bus of the Mediatek…
May 20 2019, 5:44 PM
adrian closed D20101: GPIO CS support and set mode and clock.
May 20 2019, 5:44 PM

May 19 2019

adrian accepted D20101: GPIO CS support and set mode and clock.

Hey this looks good! I don't have any hardware to test it on right now though so I'll take your word for it.

May 19 2019, 4:03 PM

May 15 2019

adrian committed rS347618: [ar71xx_gpio] Add AR9341/AR9342 to the list of chips for programming….
[ar71xx_gpio] Add AR9341/AR9342 to the list of chips for programming…
May 15 2019, 4:51 PM
adrian closed D20170: Add GPIO MUX support on AR934x and AR1321.
May 15 2019, 4:51 PM
adrian added a comment to D20170: Add GPIO MUX support on AR934x and AR1321.

ooooh ok. yeah maybe we should add that CPU to the detected list?

May 15 2019, 6:51 AM
adrian added a comment to D20170: Add GPIO MUX support on AR934x and AR1321.

ok, so can you add:

May 15 2019, 6:06 AM

May 14 2019

adrian added a comment to D20170: Add GPIO MUX support on AR934x and AR1321.

oh interesting. er, so i know this is asking a lot but I'm trying to understand explicitly what the hardware setup is.

May 14 2019, 6:07 PM

May 12 2019

adrian requested changes to D20170: Add GPIO MUX support on AR934x and AR1321.

so it turns out this isn't "right". There's already a way to configure the output function for the SoC side GPIO pins. look at the existing gpiofunc/gpiomode. That's what gpiofunc does (and gpiomode=1 just says "make it output, value low as a default"). It's only useful for AR934x and later.

May 12 2019, 9:32 PM

May 9 2019

adrian accepted D20170: Add GPIO MUX support on AR934x and AR1321.

looks good! i'll go commit it tonight.

May 9 2019, 2:20 AM

May 5 2019

adrian committed rS347141: [ath_rate_sample] Have the final attempted rate in 11n modes to be the lowest….
[ath_rate_sample] Have the final attempted rate in 11n modes to be the lowest…
May 5 2019, 6:32 AM
adrian committed rS347140: [ath] [ath_rate] Fix ANI calibration during non-ACTIVE states; start poking at….
[ath] [ath_rate] Fix ANI calibration during non-ACTIVE states; start poking at…
May 5 2019, 4:56 AM

May 3 2019

adrian committed rS347050: [libfetch] Fix compilation with WITHOUT_CRYPT..
[libfetch] Fix compilation with WITHOUT_CRYPT.
May 3 2019, 6:07 AM

May 1 2019

adrian added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..
In D20117#433281, @jhb wrote:
May 1 2019, 9:23 PM
adrian added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..

I see you've done a bit of net80211 checking there; I think I'm going to use this change as motivation to speed up my desire to make rcvif manipulation a bit less insane and error prone.

Would it work to use PH_loc.ptr in place of rcvif to store the pointer the net80211 node struct? I assume PH_loc was added after you'd already taken rcvif?
If anybody wants to throw rotten vegetables for the choice to unionize rcvif and snd_tag, lob them at me. I argued strongly to keep the mbuf size unchanged. This is because (on amd64) we wind up taking an extra cacheline miss on mbuf ext free if the pkt_hdr adds a new pointer, because any additions to the packet header will push m_ext.ext_arg1 into another cacheline. In our workload, this ext_free happens millions of times per second. I wish I could think of some clean, non-intrusive way to have an mbuf have just an m_ext, but not waste space on a pkt_hdr.

May 1 2019, 4:36 PM
adrian added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..

I see you've done a bit of net80211 checking there; I think I'm going to use this change as motivation to speed up my desire to make rcvif manipulation a bit less insane and error prone.

May 1 2019, 3:38 PM
adrian added a comment to D20117: Restructure mbuf send tags to provide stronger guarantees..
In D20117#433037, @ae wrote:

I'm sorry, I completely missed this change in the past. But it looks like it can break ipfw firewall rules, since rcvif is now union with snd_tag. And this means, rcvif can be initialized for packets that were not actually received on specified interface. ipfw uses rcvif in rules to check that a packet was received on specified interface, and this check was correct even for outgoing packets. Now it looks like such checks can be incorrect.

Send tags are only used for endstation initiated traffic (eg, TCP). So if a packet has a send tag set, then it could not possibly have arrived via any interface. Eg, it would have previously had a NULL rcvif. So if you compare pointers, it should be fine.
If you look at something in the rcvif, there is now a flag (CSUM_SND_TAG) that indicates that the rcvif/snd_tag union is a send tag, so you can avoid treating a send_tag as an ifnet in that case.

May 1 2019, 3:36 PM

Apr 21 2019

adrian committed rS346470: [ath] [ath_hal] [ath_hal_9300] Extend the start PCU receive to handle resetting….
[ath] [ath_hal] [ath_hal_9300] Extend the start PCU receive to handle resetting…
Apr 21 2019, 2:36 AM

Apr 19 2019

adrian committed rS346405: [ath] Fix return value check to not complain..
[ath] Fix return value check to not complain.
Apr 19 2019, 6:00 PM

Apr 17 2019

adrian added a comment to D19944: random(4): Restore availability tradeoff prior to r346250.

I'm ok with flipping random on by default nowdays. There are bigger fish to fry in the "wasted kernel space" game.

Apr 17 2019, 11:06 PM
adrian accepted D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

I think this is a pretty self contained change and would like to see it land.

Apr 17 2019, 7:23 PM
adrian committed rS346322: [casper] fix compilation when casper is disabled..
[casper] fix compilation when casper is disabled.
Apr 17 2019, 4:58 PM

Apr 16 2019

adrian added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

So in a Previous Project a Long Long Time Ago we solved this by having the receive/send state being an ifindex into an array of "ifnet" pointers, and a gencount so you can see if it's stale. Then all the code had to handle that the interface ifindex was stale (ie, a NULL pointer versus a garbage pointer) and decide at each point how to make forward progress. In some cases it wasn't needed for forward progress - eg it was already on a transmit queue, so the fact the receive interface went away wasn't a huge deal. But sometimes it was - eg tunnel (l2tp in one case) went away.

Apr 16 2019, 8:50 PM

Apr 15 2019

adrian added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

And yes I'd love for this to be addressed as a whole, but this is a pretty neat way to explicitly call out fixing up a good corner case.

Apr 15 2019, 10:41 PM
adrian added a comment to D19622: Fix panic in network stack due memory use after free in relation to fragmented packets.

*puts network engineer in the past hat on*

Apr 15 2019, 10:39 PM

Mar 19 2019

adrian committed rS345284: [ath_hal_ar9300] Add some comments around the AR9300 ANI code..
[ath_hal_ar9300] Add some comments around the AR9300 ANI code.
Mar 19 2019, 12:07 AM

Mar 6 2019

adrian committed rS344843: [ath_hal_ar9300] Add the missing bits from the previous HAL commit..
[ath_hal_ar9300] Add the missing bits from the previous HAL commit.
Mar 6 2019, 8:52 AM
adrian committed rS344842: [athani] Add a simple tool to list and control ANI parameters..
[athani] Add a simple tool to list and control ANI parameters.
Mar 6 2019, 7:58 AM
adrian committed rS344841: [ath_hal] [ath_hal_ar9300] ANI fixes and preparation for userland control..
[ath_hal] [ath_hal_ar9300] ANI fixes and preparation for userland control.
Mar 6 2019, 7:54 AM

Mar 4 2019

adrian committed rS344750: [ath_hal_ar9300] Add the extra ANI configuration fields for the AR93xx HAL..
[ath_hal_ar9300] Add the extra ANI configuration fields for the AR93xx HAL.
Mar 4 2019, 6:43 AM
adrian committed rS344749: [ath_hal] add extra ANI fields for the AR9300 HAL..
[ath_hal] add extra ANI fields for the AR9300 HAL.
Mar 4 2019, 6:42 AM

Jan 7 2019

adrian added a comment to D5165: [patch] dev/bwn suppressing "bwn0: unsupported rate 0" console messages.

Yeah, we should have a fallback rate function in net80211.

Jan 7 2019, 5:00 PM

Sep 25 2018

adrian added a comment to D17308: net80211: Enable netdump support.

Yeah please don't ifdef the structure definitions. I need to go do a pass at some point to make that not be a problem; it's 2018 :)

Sep 25 2018, 1:43 AM
adrian added inline comments to D17308: net80211: Enable netdump support.
Sep 25 2018, 12:22 AM
adrian added inline comments to D17308: net80211: Enable netdump support.
Sep 25 2018, 12:04 AM

Sep 5 2018

adrian added a comment to D15943: new driver: dev/rt2860: driver for RT2860 wifi.

I was going to try and commit this to -head soon, as it's a pretty stand-alone thing. even just before -head branches.

Sep 5 2018, 2:57 AM

Jul 14 2018

adrian added a comment to P188 arge_rxfilter(9) implemented for if_arge(4), some parts were externalized from arge_attach(9) and cleanup on some magic numbers..

This looks good! do you have commit privs or should I break it up into smaller pieces and commit it?

Jul 14 2018, 3:56 AM

Jun 24 2018

adrian added a comment to D15999: Create PCI_MATCH and pci_match_device.

yaaaaayayaya do it~!

Jun 24 2018, 7:38 PM

Jun 21 2018

adrian added a comment to D15943: new driver: dev/rt2860: driver for RT2860 wifi.

interesting! ok. I wonder how hard it'd be to integrate this into the existing ral driver. All of the RAL "HAL" routines right now really are almost complete drivers themselves with some shared bus management glue. HOw hard does it look to integrate it?

Jun 21 2018, 6:42 PM

Jun 8 2018

adrian committed rS334849: [ath_hal] Return failure if noise floor calibration fails..
[ath_hal] Return failure if noise floor calibration fails.
Jun 8 2018, 6:22 PM
adrian committed rS334848: [ath_hal] Don't do ANI processing if we've reset..
[ath_hal] Don't do ANI processing if we've reset.
Jun 8 2018, 6:15 PM

May 25 2018

adrian committed rS334197: [ath_hal] migrate the shared HAL_RESET_* pieces out into ath_hal..
[ath_hal] migrate the shared HAL_RESET_* pieces out into ath_hal.
May 25 2018, 1:27 AM

Mar 16 2018

adrian accepted D14710: Show SSID maximum string length in ifconfig scan.

I think it's fine to extend it; longer SSIDs are now a thing and have been for a while.

Mar 16 2018, 4:29 PM

Mar 9 2018

adrian accepted D14628: Wrap protection frame allocation into ieee80211_alloc_prot().

It looks good! It'd be fun to try and RTS/CTS protect longer bursts, but that can always come later!

Mar 9 2018, 2:41 AM

Feb 7 2018

adrian committed rS328970: [ath] Use the BSSID address logic for STA VAPs too..
[ath] Use the BSSID address logic for STA VAPs too.
Feb 7 2018, 9:37 AM
adrian committed rS328969: [ar71xx] Fix the TL-wdr3600/tl-wdr4300 hints in the new world order..
[ar71xx] Fix the TL-wdr3600/tl-wdr4300 hints in the new world order.
Feb 7 2018, 9:36 AM

Feb 6 2018

adrian committed rS328924: [arswitch] Implement the switch MAC address fetch API..
[arswitch] Implement the switch MAC address fetch API.
Feb 6 2018, 8:36 AM
adrian committed rS328923: [etherswitchcfg] print the switch MAC address if provided..
[etherswitchcfg] print the switch MAC address if provided.
Feb 6 2018, 8:35 AM
adrian committed rS328922: [etherswitch] add initial support for potentially configuring and fetching the….
[etherswitch] add initial support for potentially configuring and fetching the…
Feb 6 2018, 8:35 AM

Feb 5 2018

adrian committed rS328901: [arswitch] disable ARP copy-to-CPU port for AR9340 for now..
[arswitch] disable ARP copy-to-CPU port for AR9340 for now.
Feb 5 2018, 8:37 PM
adrian committed rS328900: [arswitch] fix build breakage..
[arswitch] fix build breakage.
Feb 5 2018, 8:31 PM
adrian committed rS328873: [arswitch] Enable ATU dump support for the AR9340..
[arswitch] Enable ATU dump support for the AR9340.
Feb 5 2018, 7:05 AM
adrian committed rS328872: [arswitch] fix mac address field definition..
[arswitch] fix mac address field definition.
Feb 5 2018, 7:04 AM
adrian committed rS328871: [arswitch] Break out of the loop upon any error, not just -1..
[arswitch] Break out of the loop upon any error, not just -1.
Feb 5 2018, 5:52 AM
adrian committed rS328869: [ar71xx] Fix DB120 AHB device hints in the new world order..
[ar71xx] Fix DB120 AHB device hints in the new world order.
Feb 5 2018, 4:48 AM
adrian committed rS328868: [ar71xx] AR934x is a MIPS74k board - use the right hwpmc module.
[ar71xx] AR934x is a MIPS74k board - use the right hwpmc module
Feb 5 2018, 4:47 AM
adrian committed rS328867: [ar71xx] New world order - don't reference ath_pci here, it's a module now.
[ar71xx] New world order - don't reference ath_pci here, it's a module now
Feb 5 2018, 4:46 AM

Feb 4 2018

adrian committed rS328838: [arswitch] fix up issues on the AR8327..
[arswitch] fix up issues on the AR8327.
Feb 4 2018, 8:22 AM

Feb 3 2018

adrian committed rS328823: [arswitch] add initial functionality for AR8327 ATU management..
[arswitch] add initial functionality for AR8327 ATU management.
Feb 3 2018, 12:59 AM

Feb 2 2018

adrian committed rS328815: [etherswitchcfg] add atu flush and atu dump commands..
[etherswitchcfg] add atu flush and atu dump commands.
Feb 2 2018, 10:09 PM
adrian committed rS328814: [arswitch] Stub out the ATU table dump in AR9340 switches until I implement.
[arswitch] Stub out the ATU table dump in AR9340 switches until I implement
Feb 2 2018, 10:08 PM
adrian committed rS328812: [arswitch] begin tidying up the learning and ATU management, introduce ATU APIs..
[arswitch] begin tidying up the learning and ATU management, introduce ATU APIs.
Feb 2 2018, 10:05 PM
adrian committed rS328766: [etherswitch] add the first pass of a simple API to flush and fetch the L2….
[etherswitch] add the first pass of a simple API to flush and fetch the L2…
Feb 2 2018, 2:05 AM

Feb 1 2018

adrian committed rS328758: [atheros] Update QCA953x support to use the new hints..
[atheros] Update QCA953x support to use the new hints.
Feb 1 2018, 10:02 PM
adrian committed rS328757: [atheros] Fix DIR-825C1 to use the new hints..
[atheros] Fix DIR-825C1 to use the new hints.
Feb 1 2018, 10:01 PM
adrian committed rS328756: [atheros] teach these two boards about the new hints location as well..
[atheros] teach these two boards about the new hints location as well.
Feb 1 2018, 10:00 PM
adrian committed rS328755: [atheros] Teach the QCA955x SoC code about the new hints stuff..
[atheros] Teach the QCA955x SoC code about the new hints stuff.
Feb 1 2018, 10:00 PM
adrian committed rS328754: [atheros] Fix-up the base address stuff after I did a drive-by with the….
[atheros] Fix-up the base address stuff after I did a drive-by with the…
Feb 1 2018, 9:59 PM

Jan 31 2018

adrian committed rS328619: [arswitch] Fix ATU programming on the AR8327 switch..
[arswitch] Fix ATU programming on the AR8327 switch.
Jan 31 2018, 7:37 AM
adrian committed rS328618: [arswitch] Fix ATU flushing on AR8216/AR8316 and most of the later chips..
[arswitch] Fix ATU flushing on AR8216/AR8316 and most of the later chips.
Jan 31 2018, 7:37 AM
adrian committed rS328617: [arswitch] add a new debug section for upcoming address table management..
[arswitch] add a new debug section for upcoming address table management.
Jan 31 2018, 7:20 AM

Jan 2 2018

adrian committed rS327479: [net80211] convert all of the WME use over to a temporary copy of WME info..
[net80211] convert all of the WME use over to a temporary copy of WME info.
Jan 2 2018, 12:07 AM

Dec 30 2017

adrian added a comment to D13161: net80211: sanitize input for ieee80211_output().

commit away! thanks!

Dec 30 2017, 12:17 AM
adrian added a comment to D9806: net80211: handle VHT nodes in ieee80211_node_setuptxparms().

commit away!

Dec 30 2017, 12:16 AM

Dec 9 2017

adrian committed rS326737: [net80211] add a method for checking if a VAP WME AC has a NOACK policy or not..
[net80211] add a method for checking if a VAP WME AC has a NOACK policy or not.
Dec 9 2017, 11:16 PM

Nov 27 2017

adrian accepted D13021: bhnd: add/update inline documentation comments and man pages.
Nov 27 2017, 8:03 PM

Nov 26 2017

adrian added a comment to D13244: Remove fortune(6).

Replacing it with a placeholder bootstrap fortune shell script to retain backward compat is a smart move.

Nov 26 2017, 5:19 PM
adrian accepted D13244: Remove fortune(6).

Approved.

Nov 26 2017, 7:24 AM

Nov 20 2017

adrian accepted D12385: Preemptively perform intr_map_irq() on non-FDT MIPS targets..
Nov 20 2017, 11:29 PM

Nov 19 2017

adrian added inline comments to D13161: net80211: sanitize input for ieee80211_output().
Nov 19 2017, 11:42 PM

Nov 14 2017

adrian accepted D12385: Preemptively perform intr_map_irq() on non-FDT MIPS targets..
Nov 14 2017, 9:43 PM

Nov 9 2017

adrian committed rS325569: [bsdbox] fix compilation due to library work..
[bsdbox] fix compilation due to library work.
Nov 9 2017, 1:41 AM

Oct 16 2017

adrian closed D12680: [svxlink] make this compile again.
Oct 16 2017, 7:28 PM
adrian committed rP452246: [svxlink] make this compile / run on FreeBSD-HEAD again..
[svxlink] make this compile / run on FreeBSD-HEAD again.
Oct 16 2017, 7:28 PM

Oct 15 2017

adrian updated the diff for D12680: [svxlink] make this compile again.

Fix up warnings from portlint

Oct 15 2017, 5:35 PM
adrian created D12680: [svxlink] make this compile again.
Oct 15 2017, 4:45 PM

Oct 13 2017

adrian committed rS324580: [net80211] don't try to follow a NULL rxs pointer down the sink..
[net80211] don't try to follow a NULL rxs pointer down the sink.
Oct 13 2017, 6:49 AM

Oct 12 2017

adrian committed rS324571: [ath] Begin using the replacement EDCA functions..
[ath] Begin using the replacement EDCA functions.
Oct 12 2017, 9:59 PM
adrian committed rS324570: [net80211] begin handling multiple hardware decap'ed A-MSDU in the RX path..
[net80211] begin handling multiple hardware decap'ed A-MSDU in the RX path.
Oct 12 2017, 9:57 PM

Oct 10 2017

adrian added a comment to D12480: multimedia/qt5-multimedia: Modernize and turn on sound support by default.

I think alsa is fine, as pulseaudio can capture alsa sound too.

Oct 10 2017, 5:08 PM
adrian accepted D12480: multimedia/qt5-multimedia: Modernize and turn on sound support by default.

hi! thanks for this! this will be really useful!

Oct 10 2017, 4:40 PM

Oct 3 2017

adrian accepted D12582: bhnd(4): Add support for querying DMA address translation parameters.

lgtm; you don't have to ask for my permission to commit to bhnd stuff btw :)

Oct 3 2017, 10:56 PM