Differential D20142

iflib: remove assertion that isc_capabilities is nonzero
ClosedPublic
Actions

Authored by emaste on May 2 2019, 3:00 PM.

Tags

None

Referenced Files

	F132424262: D20142.id56963.diff
	Thu, Oct 16, 7:54 PM

	Unknown Object (File)
	Tue, Oct 14, 9:22 AM

	Unknown Object (File)
	Tue, Oct 14, 9:22 AM

	Unknown Object (File)
	Tue, Oct 14, 9:22 AM

	Unknown Object (File)
	Mon, Oct 13, 7:22 PM

	Unknown Object (File)
	Sat, Oct 11, 1:15 AM

	Unknown Object (File)
	Aug 20 2025, 12:03 PM

	Unknown Object (File)
	Aug 20 2025, 10:30 AM

View All 87 Files

Subscribers

imp

Details

Reviewers

aryeeteygerald_rogers.com
mmacy
shurd

Group Reviewers

iflib

Commits

rS347031: iflib: remove assertion that isc_capabilities is nonzero

Summary

It's atypical, but not invalid, for a driver to pass no capabilities.

Submitted by: Gerald

Test Plan

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.May 2 2019, 3:00 PM

Herald added a reviewer: shurd. · View Herald TranscriptMay 2 2019, 3:00 PM

Herald added a reviewer: iflib. · View Herald Transcript

Herald added a subscriber: ae. · View Herald Transcript

emaste added a child revision: D20079: [new driver] Microchips LAN743X driver for FreeBSD.May 2 2019, 3:03 PM

Makes sense.

This revision is now accepted and ready to land.May 2 2019, 5:51 PM

Closed by commit rS347031: iflib: remove assertion that isc_capabilities is nonzero (authored by emaste). · Explain WhyMay 2 2019, 7:13 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptMay 2 2019, 7:13 PM

emaste mentioned this in D19946: allow iflib drivers to pass their own ifmedia.May 2 2019, 7:15 PM

emaste mentioned this in D20079: [new driver] Microchips LAN743X driver for FreeBSD.May 2 2019, 7:31 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

iflib.c

2 lines

Diff 56979

View Options

iflib: remove assertion that isc_capabilities is nonzeroClosedPublicActions