- User Since
- Jan 7 2019, 8:46 PM (40 w, 1 d)
May 6 2019
Apr 26 2019
For more info on this bug, it occurs because all iflib drivers atm have iflib_get_media in IFDI_ATTACH_PRE. I don't think any of them actually use the media until later so you can either move the calls down into IFDI_ATTACH_POST or initialize the pointer and media before IFDI_ATTACH_PRE.
Apr 22 2019
I like the changes.
Apr 17 2019
nvm, that makes sense.
As is, the patch works.
the custom media would have to call the wrappers, especially if restart is necessary
I think a check/assert for that (and maybe a comment on isc_media) would be good idea
Should probably note that this would require miibus users (and other consumers of this) to correctly init the status and change callbacks to iflib_media_change and iflib_media_status.
Remove diff junk ...
- Update comments to reflect rS345550
Apr 9 2019
Rebase changes to reflect upstream update to libarchive
Apr 3 2019
- Support old DTBs which still use phy_id
- Remove extra phy-handlei check and add 'no children' check
Jan 26 2019
Also I perform a diff against the old version first so they must have added a line that looks like the diff marker during conflict resolution. This seems very unlikely.
Jan 24 2019
- Change unresolved conflict warning into an error
An error or forcing them to resolve it manually again may be better.
Jan 23 2019
Jan 22 2019
- Clarify 'mirror failure' message
- Fix style issues
Remove unnecessary diff junk.
- Use HEREDOC/cat instead of multiple echos
Jan 21 2019
- Fix style/syntax issues
Jan 18 2019
Note that most IDS_run output shouldn't be considered as "informational", especially checksum differences: these should not be suppressed because they suggest there are real issues.
- Improve code for printing to stderr
Need to add export UNAME_r to config_SourceRelease. Will create new review with fix.
- Fix ordering of system checks
- Update permissions check and chflag check
- Fix spacing issues
- Include support for upgrading from alpha releases
- Simplify src component check
It may be because it is hard to follow but warnings/errors are redirected to the stderr
And then the stdout fetch_run/IDS_run is intended to be piped to INFOREDIR. This is normally stdout but can be /dev/null in order to hide informational messages ...
is this a bad idea?
Jan 17 2019
- Fix typo in comment
- Update outdated comment
Jan 16 2019
Jan 15 2019
- Ensure install flags can be removed