Page MenuHomeFreeBSD

aryeeteygerald_rogers.com (Gerald Aryeetey)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 7 2019, 8:46 PM (28 w, 1 d)

Recent Activity

May 6 2019

aryeeteygerald_rogers.com added inline comments to D20079: [new driver] Microchips LAN743X driver for FreeBSD.
May 6 2019, 6:26 PM

Apr 26 2019

aryeeteygerald_rogers.com added a comment to D20079: [new driver] Microchips LAN743X driver for FreeBSD.

Link to Git repository

Apr 26 2019, 10:40 PM
aryeeteygerald_rogers.com added a reviewer for D20079: [new driver] Microchips LAN743X driver for FreeBSD: emaste.
Apr 26 2019, 10:34 PM
aryeeteygerald_rogers.com created D20079: [new driver] Microchips LAN743X driver for FreeBSD.
Apr 26 2019, 10:33 PM
aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.

For more info on this bug, it occurs because all iflib drivers atm have iflib_get_media in IFDI_ATTACH_PRE. I don't think any of them actually use the media until later so you can either move the calls down into IFDI_ATTACH_POST or initialize the pointer and media before IFDI_ATTACH_PRE.

Apr 26 2019, 6:12 PM

Apr 22 2019

aryeeteygerald_rogers.com accepted D20007: ar: shuffle symbol offsets during conversion for 32-bit ar archives.

I like the changes.

Apr 22 2019, 4:23 PM

Apr 17 2019

aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.

nvm, that makes sense.

Apr 17 2019, 11:29 PM
aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.
Apr 17 2019, 11:28 PM
aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.

As is, the patch works.
I would still suggest exposing the iflib_media_* because init_locked is unavailable in the case of reset and I think the locks in the wrapper are useful?

Call iflib_init. You don't need the iflib lock held across your PHY routines - the wrapper you see here is so that normal drivers don't have to maintain their own locks. Any dedicated PHY driver is going to already be using its own locks. Exposing these would only further complicate the API with no benefit.

can you test with this patch and let me know? It should be a no-op for current drivers so can probably go in quickly.

Apr 17 2019, 10:58 PM
aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.

As is, the patch works.

Apr 17 2019, 10:16 PM
aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.

the custom media would have to call the wrappers, especially if restart is necessary

Apr 17 2019, 9:44 PM
aryeeteygerald_rogers.com added inline comments to D19946: allow iflib drivers to pass their own ifmedia.
Apr 17 2019, 9:07 PM
aryeeteygerald_rogers.com added inline comments to D19946: allow iflib drivers to pass their own ifmedia.
Apr 17 2019, 8:52 PM
aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.

I think a check/assert for that (and maybe a comment on isc_media) would be good idea

Apr 17 2019, 8:46 PM
aryeeteygerald_rogers.com added a comment to D19946: allow iflib drivers to pass their own ifmedia.

Should probably note that this would require miibus users (and other consumers of this) to correctly init the status and change callbacks to iflib_media_change and iflib_media_status.

Apr 17 2019, 8:41 PM
aryeeteygerald_rogers.com updated the diff for D18933: Ensure kernel.bootfile is a real file.

Remove diff junk ...

Apr 17 2019, 7:24 PM
aryeeteygerald_rogers.com updated the diff for D18933: Ensure kernel.bootfile is a real file.
Apr 17 2019, 7:22 PM

Apr 9 2019

aryeeteygerald_rogers.com updated the diff for D18793: Implement support for "/SYM64/" archives in ar.

Rebase changes to reflect upstream update to libarchive

Apr 9 2019, 4:15 PM

Apr 3 2019

aryeeteygerald_rogers.com updated the diff for D19814: Use 'phy-handle' in FDT to find PHY address.
  • Support old DTBs which still use phy_id
Apr 3 2019, 8:23 PM
aryeeteygerald_rogers.com updated the diff for D19814: Use 'phy-handle' in FDT to find PHY address.
  • Remove extra phy-handlei check and add 'no children' check
Apr 3 2019, 5:58 PM
aryeeteygerald_rogers.com added inline comments to D19814: Use 'phy-handle' in FDT to find PHY address.
Apr 3 2019, 4:42 PM
aryeeteygerald_rogers.com created D19814: Use 'phy-handle' in FDT to find PHY address.
Apr 3 2019, 4:07 PM

Jan 26 2019

aryeeteygerald_rogers.com added a comment to D18942: freebsd-update: Fail if there are any unresolved conflicts.

Also I perform a diff against the old version first so they must have added a line that looks like the diff marker during conflict resolution. This seems very unlikely.

Jan 26 2019, 7:56 PM

Jan 24 2019

aryeeteygerald_rogers.com created D18944: freebsd-update: Clarify unclear help text.
Jan 24 2019, 6:36 PM
aryeeteygerald_rogers.com retitled D18942: freebsd-update: Fail if there are any unresolved conflicts from Warn users about unresolved conflicts to freebsd-update: Fail if there are any unresolved conflicts.
Jan 24 2019, 6:27 PM
aryeeteygerald_rogers.com updated the diff for D18942: freebsd-update: Fail if there are any unresolved conflicts.
  • Change unresolved conflict warning into an error
Jan 24 2019, 6:27 PM
aryeeteygerald_rogers.com added a comment to D18942: freebsd-update: Fail if there are any unresolved conflicts.

An error or forcing them to resolve it manually again may be better.

Jan 24 2019, 6:10 PM
aryeeteygerald_rogers.com created D18942: freebsd-update: Fail if there are any unresolved conflicts.
Jan 24 2019, 6:09 PM

Jan 23 2019

aryeeteygerald_rogers.com created D18933: Ensure kernel.bootfile is a real file.
Jan 23 2019, 9:06 PM
aryeeteygerald_rogers.com created D18931: freebsd-update: Throw error if failed to install files.
Jan 23 2019, 5:19 PM

Jan 22 2019

aryeeteygerald_rogers.com created D18927: freebsd-update: Stop installing empty component sets.
Jan 22 2019, 10:50 PM
aryeeteygerald_rogers.com created D18925: Prefer freebsd-version over uname -r.
Jan 22 2019, 10:47 PM
aryeeteygerald_rogers.com created D18923: freebsd-update: Add `AllowUnattended` option.
Jan 22 2019, 7:16 PM
aryeeteygerald_rogers.com updated the diff for D18916: Clarify unsupported architecture upgrade message.
  • Clarify 'mirror failure' message
Jan 22 2019, 6:02 PM
aryeeteygerald_rogers.com added a comment to D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.

Note that most IDS_run output shouldn't be considered as "informational", especially checksum differences: these should not be suppressed because they suggest there are real issues.

Where are the checksum diffs? I don't think they are currently suppressed but maybe I missed it.

Sorry it was my typo. It's IDS_compare's output (called by IDS_run).

Jan 22 2019, 5:10 PM
aryeeteygerald_rogers.com updated the diff for D18916: Clarify unsupported architecture upgrade message.
  • Fix style issues
Jan 22 2019, 3:58 PM
aryeeteygerald_rogers.com updated the diff for D18913: freebsd-update: open $PAGER only if necessary.

Remove unnecessary diff junk.

Jan 22 2019, 3:46 PM
aryeeteygerald_rogers.com updated the diff for D18913: freebsd-update: open $PAGER only if necessary.
  • Use HEREDOC/cat instead of multiple echos
Jan 22 2019, 3:43 PM

Jan 21 2019

aryeeteygerald_rogers.com created D18916: Clarify unsupported architecture upgrade message.
Jan 21 2019, 7:27 PM
aryeeteygerald_rogers.com created D18915: Fix incorrect padding in b64enc and use fetch API.
Jan 21 2019, 6:13 PM
aryeeteygerald_rogers.com created D18913: freebsd-update: open $PAGER only if necessary.
Jan 21 2019, 5:55 PM
aryeeteygerald_rogers.com updated the diff for D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.
  • Fix style/syntax issues
Jan 21 2019, 4:35 PM

Jan 18 2019

aryeeteygerald_rogers.com added inline comments to D18825: Verify the system can perform install/rollback.
Jan 18 2019, 10:41 PM
aryeeteygerald_rogers.com added a comment to D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.

Note that most IDS_run output shouldn't be considered as "informational", especially checksum differences: these should not be suppressed because they suggest there are real issues.

Jan 18 2019, 9:11 PM
aryeeteygerald_rogers.com added inline comments to D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.
Jan 18 2019, 9:08 PM
aryeeteygerald_rogers.com updated the diff for D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.
  • Improve code for printing to stderr
Jan 18 2019, 9:03 PM
aryeeteygerald_rogers.com created D18896: freebsd-update: fix --currently-running.
Jan 18 2019, 6:47 PM
aryeeteygerald_rogers.com added a comment to D18881: Allow upgrade from -BETA and -RC releases.

Need to add export UNAME_r to config_SourceRelease. Will create new review with fix.

Jan 18 2019, 6:44 PM
aryeeteygerald_rogers.com updated the diff for D18825: Verify the system can perform install/rollback.
  • Fix ordering of system checks
Jan 18 2019, 6:36 PM
aryeeteygerald_rogers.com added inline comments to D18825: Verify the system can perform install/rollback.
Jan 18 2019, 6:12 PM
aryeeteygerald_rogers.com updated the diff for D18825: Verify the system can perform install/rollback.
  • Update permissions check and chflag check
Jan 18 2019, 5:49 PM
aryeeteygerald_rogers.com added inline comments to D18849: Use BASEDIR when checking for src component.
Jan 18 2019, 5:01 PM
aryeeteygerald_rogers.com updated the diff for D18881: Allow upgrade from -BETA and -RC releases.
  • Fix spacing issues
Jan 18 2019, 4:59 PM
aryeeteygerald_rogers.com updated the diff for D18881: Allow upgrade from -BETA and -RC releases.
  • Include support for upgrading from alpha releases
Jan 18 2019, 4:54 PM
aryeeteygerald_rogers.com updated the diff for D18849: Use BASEDIR when checking for src component.
  • Simplify src component check
Jan 18 2019, 4:40 PM
aryeeteygerald_rogers.com added a comment to D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.

It may be because it is hard to follow but warnings/errors are redirected to the stderr
And then the stdout fetch_run/IDS_run is intended to be piped to INFOREDIR. This is normally stdout but can be /dev/null in order to hide informational messages ...
is this a bad idea?

Jan 18 2019, 4:12 PM

Jan 17 2019

aryeeteygerald_rogers.com created D18881: Allow upgrade from -BETA and -RC releases.
Jan 17 2019, 10:50 PM
aryeeteygerald_rogers.com updated the diff for D18877: Remove dependency on /boot if jailed.
  • Fix typo in comment
Jan 17 2019, 7:34 PM
aryeeteygerald_rogers.com updated the diff for D18827: Update /etc/passwd after password db changes.
  • Update outdated comment
Jan 17 2019, 7:30 PM
aryeeteygerald_rogers.com updated the summary of D18877: Remove dependency on /boot if jailed.
Jan 17 2019, 6:12 PM
aryeeteygerald_rogers.com created D18877: Remove dependency on /boot if jailed.
Jan 17 2019, 6:11 PM

Jan 16 2019

aryeeteygerald_rogers.com created D18859: Print fatal errors/warnings to STDERR and add -q (quiet) option.
Jan 16 2019, 8:34 PM

Jan 15 2019

aryeeteygerald_rogers.com updated the summary of D18827: Update /etc/passwd after password db changes.
Jan 15 2019, 10:28 PM
aryeeteygerald_rogers.com updated the summary of D18825: Verify the system can perform install/rollback.
Jan 15 2019, 10:27 PM
aryeeteygerald_rogers.com updated the summary of D18803: Clarify unsupported release upgrade error message.
Jan 15 2019, 10:24 PM
aryeeteygerald_rogers.com updated the summary of D18849: Use BASEDIR when checking for src component.
Jan 15 2019, 10:20 PM
aryeeteygerald_rogers.com created D18849: Use BASEDIR when checking for src component.
Jan 15 2019, 10:19 PM
aryeeteygerald_rogers.com retitled D18825: Verify the system can perform install/rollback from Verify that / and /usr are mounted with read-write to Verify the system can perform install/rollback.
Jan 15 2019, 7:35 PM
aryeeteygerald_rogers.com updated the diff for D18825: Verify the system can perform install/rollback.
  • Ensure install flags can be removed
Jan 15 2019, 7:33 PM

Jan 11 2019

aryeeteygerald_rogers.com created D18827: Update /etc/passwd after password db changes.
Jan 11 2019, 10:24 PM
aryeeteygerald_rogers.com created D18825: Verify the system can perform install/rollback.
Jan 11 2019, 9:29 PM

Jan 9 2019

aryeeteygerald_rogers.com updated the summary of D18803: Clarify unsupported release upgrade error message.
Jan 9 2019, 11:01 PM
aryeeteygerald_rogers.com created D18803: Clarify unsupported release upgrade error message.
Jan 9 2019, 11:01 PM
aryeeteygerald_rogers.com created D18793: Implement support for "/SYM64/" archives in ar.
Jan 9 2019, 5:02 PM