snd_hdspe(4): Recognize newer firmware's PCI vendor id.
ClosedPublic
Actions

Authored by dev_submerge.ch on Apr 26 2024, 8:47 PM.

Details

Reviewers

Commits

rG12f6e0a4d2d5: snd_hdspe(4): Recognize newer firmware's PCI vendor id.
rG301ced3b69fb: snd_hdspe(4): Recognize newer firmware's PCI vendor id.
rG9718d4ab9938: snd_hdspe(4): Recognize newer firmware's PCI vendor id.

Summary

At least for HDSPe RayDAT cards, newer firmware comes with RME's own PCI
vendor id instead of the Xilinx one. Other HDSPe cards are probably also
affected. Update snd_hdspe(4) to recognize both the old Xilinx and the
new RME vendor ids.

MFC after: 1 day

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dev_submerge.ch created this revision.Apr 26 2024, 8:47 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 26 2024, 8:47 PM

dev_submerge.ch requested review of this revision.Apr 26 2024, 8:47 PM

Harbormaster completed remote builds in B57405: Diff 137735.Apr 26 2024, 8:47 PM

@br: I was surprised that after a firmware update of my HDSPe RayDAT card it wasn't recognized anymore on FreeBSD. Turns out RME changed the PCI vendor id to their own instead of the Xilinx one.

Could you please check that your HDSPe AIO card is still recognized with this patch? Would be nice to have this fixed in upcoming 14.1-RELEASE, thus the short-term MFC.

In D44978#1025398, @dev_submerge.ch wrote:

@br: I was surprised that after a firmware update of my HDSPe RayDAT card it wasn't recognized anymore on FreeBSD. Turns out RME changed the PCI vendor id to their own instead of the Xilinx one.

Could you please check that your HDSPe AIO card is still recognized with this patch? Would be nice to have this fixed in upcoming 14.1-RELEASE, thus the short-term MFC.

Let me check. BTW should this work for HDSPe AIO Pro? I don't have it but I'm curious

In D44978#1025409, @br wrote:

In D44978#1025398, @dev_submerge.ch wrote:

@br: I was surprised that after a firmware update of my HDSPe RayDAT card it wasn't recognized anymore on FreeBSD. Turns out RME changed the PCI vendor id to their own instead of the Xilinx one.

Could you please check that your HDSPe AIO card is still recognized with this patch? Would be nice to have this fixed in upcoming 14.1-RELEASE, thus the short-term MFC.

Let me check. BTW should this work for HDSPe AIO Pro? I don't have it but I'm curious

Thanks. Regarding HDSPe AIO Pro: I suppose it uses the new PCI vendor id too, but probably a different PCI revision? Functionality-wise the specs look quite similar, but my guess is that it needs at least some additional settings for e.g. output levels. We could skim the rewritten linux driver to see what the differences are.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 27 2024, 8:51 AM

Closed by commit rG9718d4ab9938: snd_hdspe(4): Recognize newer firmware's PCI vendor id. (authored by dev_submerge.ch, committed by br). · Explain Why

This revision was automatically updated to reflect the committed changes.

br added a commit: rG9718d4ab9938: snd_hdspe(4): Recognize newer firmware's PCI vendor id..

br added a commit: rG301ced3b69fb: snd_hdspe(4): Recognize newer firmware's PCI vendor id..Jul 28 2024, 8:21 PM

br added a commit: rG12f6e0a4d2d5: snd_hdspe(4): Recognize newer firmware's PCI vendor id..Jul 28 2024, 8:25 PM