pci: Use a switch statement when reading ivars
ClosedPublic
Actions

Authored by andrew on Dec 12 2024, 9:24 AM.

Details

Reviewers

jhb
jkim
cperciva
imp

Commits

rGd3916945e4e1: pci: Use a switch statement when reading ivars
rGfafb43abd0dc: pci: Use a switch statement when reading ivars

Summary

In pci_host_generic.c use a switch statement rather than a series
of if statements.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Dec 12 2024, 9:24 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 12 2024, 9:24 AM

andrew requested review of this revision.Dec 12 2024, 9:24 AM

Harbormaster completed remote builds in B61099: Diff 147843.Dec 12 2024, 9:24 AM

andrew added a parent revision: D48044: acpica: Extract _OSC parsing to a common file.Dec 12 2024, 9:24 AM

andrew added a child revision: D48046: pci: Make generic_pcie_read_ivar non static.

imp accepted this revision.Dec 12 2024, 2:33 PM

imp added inline comments.

sys/dev/pci/pci_host_generic.c
383	That could be default: case too, if you want

This revision is now accepted and ready to land.Dec 12 2024, 2:33 PM

Closed by commit rGfafb43abd0dc: pci: Use a switch statement when reading ivars (authored by andrew). · Explain WhyDec 12 2024, 6:19 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGfafb43abd0dc: pci: Use a switch statement when reading ivars.

cperciva added a commit: rGd3916945e4e1: pci: Use a switch statement when reading ivars.Apr 1 2025, 5:46 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic.c

8 lines

Diff 147885

View Options

sys/dev/pci/pci_host_generic.c

pci: Use a switch statement when reading ivarsClosedPublicActions