pci_host_generic: Support ACPI_IVAR_HANDLE
ClosedPublic
Actions

Authored by andrew on Dec 12 2024, 9:24 AM.

Details

Reviewers

jhb
jkim
cperciva
imp

Commits

rG479872ce9194: pci_host_generic: Support ACPI_IVAR_HANDLE
rGdeb36d0c6543: pci_host_generic: Support ACPI_IVAR_HANDLE

Summary

In the ACPI attachment support the ACPI_IVAR_HANDLE ivar. While here
use the common ivar function to support the common ivars.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Dec 12 2024, 9:24 AM

Herald added a subscriber: imp. · View Herald TranscriptDec 12 2024, 9:24 AM

andrew requested review of this revision.Dec 12 2024, 9:24 AM

Harbormaster completed remote builds in B61101: Diff 147845.Dec 12 2024, 9:24 AM

andrew added a parent revision: D48046: pci: Make generic_pcie_read_ivar non static.Dec 12 2024, 9:24 AM

andrew added a child revision: D48048: pci_host_generic:Add pcib_request_feature on ACPI.

So long as the enums for ivars are disjoint

This revision is now accepted and ready to land.Dec 12 2024, 2:35 PM

In D48047#1095160, @imp wrote:

So long as the enums for ivars are disjoint

ACPI's ivars start at 100 for this very reason. The other ACPI PCI drivers used for !arm64 already do the same thing.

jhb accepted this revision.Dec 12 2024, 3:18 PM

Closed by commit rGdeb36d0c6543: pci_host_generic: Support ACPI_IVAR_HANDLE (authored by andrew). · Explain WhyDec 12 2024, 6:19 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGdeb36d0c6543: pci_host_generic: Support ACPI_IVAR_HANDLE.

cperciva added a commit: rG479872ce9194: pci_host_generic: Support ACPI_IVAR_HANDLE.Apr 1 2025, 5:46 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic_acpi.c

19 lines

Diff 147887

View Options

sys/dev/pci/pci_host_generic_acpi.c

pci_host_generic: Support ACPI_IVAR_HANDLEClosedPublicActions