Page MenuHomeFreeBSD

acpi_gpiobus: Fix cleanup on set flags failure
ClosedPublic

Authored by andrew on Nov 19 2024, 1:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 20, 3:16 PM
Unknown Object (File)
Sat, Feb 8, 1:34 PM
Unknown Object (File)
Feb 1 2025, 6:49 PM
Unknown Object (File)
Jan 14 2025, 10:29 PM
Unknown Object (File)
Jan 14 2025, 10:44 AM
Unknown Object (File)
Jan 14 2025, 10:31 AM
Unknown Object (File)
Jan 14 2025, 7:01 AM
Unknown Object (File)
Jan 13 2025, 5:18 PM
Subscribers

Details

Summary

When GPIOBUS_PIN_SETFLAGS fails we called gpiobus_free_ivars to clean
up the contents of the ivar, then would free the ivar. This lead to a
use-after-free as the ivar had already been set on the child so
gpiobus_child_deleted would try to free it again.

Fix this by removing the early cleanup and letting
gpiobus_child_deleted handle it.

Fixes: c9e880c0ceef ("gpiobus: Use a bus_child_deleted method to free ivars for children")
Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable