Differential D47670

acpi_gpiobus: Fix cleanup on set flags failure
ClosedPublic
Actions

Authored by andrew on Nov 19 2024, 1:08 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Jan 14, 10:29 PM

	Unknown Object (File)
	Tue, Jan 14, 10:44 AM

	Unknown Object (File)
	Tue, Jan 14, 10:31 AM

	Unknown Object (File)
	Tue, Jan 14, 7:01 AM

	Unknown Object (File)
	Mon, Jan 13, 5:18 PM

	Unknown Object (File)
	Mon, Jan 6, 4:00 PM

	Unknown Object (File)
	Mon, Jan 6, 9:25 AM

	Unknown Object (File)
	Mon, Jan 6, 9:11 AM

View All 16 Files

Subscribers

Details

Reviewers

jhb
cperciva

Commits

rGbb8c68b25333: acpi_gpiobus: Fix cleanup on set flags failure

Summary

When GPIOBUS_PIN_SETFLAGS fails we called gpiobus_free_ivars to clean
up the contents of the ivar, then would free the ivar. This lead to a
use-after-free as the ivar had already been set on the child so
gpiobus_child_deleted would try to free it again.

Fix this by removing the early cleanup and letting
gpiobus_child_deleted handle it.

Fixes: c9e880c0ceef ("gpiobus: Use a bus_child_deleted method to free ivars for children")
Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Nov 19 2024, 1:08 PM

Herald added subscribers: loos, imp. · View Herald TranscriptNov 19 2024, 1:08 PM

andrew requested review of this revision.Nov 19 2024, 1:08 PM

Harbormaster completed remote builds in B60683: Diff 146688.Nov 19 2024, 1:08 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 9 2024, 3:45 PM

Closed by commit rGbb8c68b25333: acpi_gpiobus: Fix cleanup on set flags failure (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGbb8c68b25333: acpi_gpiobus: Fix cleanup on set flags failure.

Revision Contents
Changeset List

Path

Size

sys/

dev/

gpio/

2 lines

Diff 147736

sys/dev/gpio/acpi_gpiobus.c

Loading...