Page MenuHomeFreeBSD
Differential D47420

scmi: Make transports report the effective length of the received messages
ClosedPublic
Actions

Authored by cristian.marussi_arm.com on Nov 4 2024, 8:51 AM.
Tags
None
Referenced Files
F157131468: D47420.id145965.diff
Mon, May 18, 4:01 PM
F157086788: D47420.id146812.diff
Mon, May 18, 9:02 AM
F157062631: D47420.id.diff
Mon, May 18, 5:29 AM
Unknown Object (File)
Fri, May 15, 1:31 AM
Unknown Object (File)
Mon, May 11, 7:44 PM
Unknown Object (File)
Mon, May 11, 7:44 PM
Unknown Object (File)
Mon, May 11, 7:44 PM
Unknown Object (File)
Mon, May 11, 7:35 PM
View All Files
Subscribers
imp

Details

Reviewers
andrew
br
Group Reviewers
arm64
Commits
rG9342829d578e: scmi: Make transports report the effective length of the received messages
Summary

Once a message is received that fits into the RX buffer, update the
msg.rx_len field with the effective length of the message received.

Tested on: Arm Morello Board
Sponsored by: Arm Ltd
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 60717
Build 57601: arc lint + arc unit

Event Timeline

cristian.marussi_arm.com created this revision.Nov 4 2024, 8:51 AM
Herald added a subscriber: imp. · View Herald TranscriptNov 4 2024, 8:51 AM
cristian.marussi_arm.com requested review of this revision.Nov 4 2024, 8:51 AM
cristian.marussi_arm.com added a parent revision: D47419: scmi: Fix race on timed out transmissions.
Harbormaster completed remote builds in B60364: Diff 145965.Nov 4 2024, 8:51 AM
cristian.marussi_arm.com added a child revision: D47421: scmi: Redefine max message payload size.Nov 4 2024, 8:51 AM
andrew added inline comments.Nov 4 2024, 3:46 PM
sys/dev/firmware/arm/scmi_shmem.c
307

This looks wrong, ret is a boolean type so shouldn't be compared with an integer.

cristian.marussi_arm.com added inline comments.Nov 4 2024, 4:51 PM
sys/dev/firmware/arm/scmi_shmem.c
307

Yes indeed, I will fix.

cristian.marussi_arm.com updated this revision to Diff 146812.Nov 21 2024, 8:54 PM

Fix mishandled retvalue on scmi_shmem_msg_poll and related funcs

Harbormaster completed remote builds in B60717: Diff 146812.Nov 21 2024, 8:54 PM
andrew accepted this revision.Nov 28 2024, 11:48 AM
This revision is now accepted and ready to land.Nov 28 2024, 11:48 AM
andrew mentioned this in rG9342829d578e: scmi: Make transports report the effective length of the received messages.Jan 23 2025, 5:28 PM
emaste closed this revision.Oct 17 2025, 3:37 PM
emaste added a commit: rG9342829d578e: scmi: Make transports report the effective length of the received messages.

Revision Contents
Changeset List

PathSize
sys/
dev/
firmware/
arm/
2 lines
10 lines
12 lines
6 lines
18 lines
4 lines
5 lines

Diff 146812

View Options

sys/dev/firmware/arm/scmi.h

Loading...
View Options

sys/dev/firmware/arm/scmi.c

Loading...
View Options

sys/dev/firmware/arm/scmi_mailbox.c

Loading...
View Options

sys/dev/firmware/arm/scmi_shmem.h

Loading...
View Options

sys/dev/firmware/arm/scmi_shmem.c

Loading...
View Options

sys/dev/firmware/arm/scmi_smc.c

Loading...
View Options

sys/dev/firmware/arm/scmi_virtio.c

Loading...