Differential D48289

arm64: apple: fix aic for !SMP configurations
ClosedPublic
Actions

Authored by kevans on Jan 2 2025, 4:37 PM.

Tags

None

Referenced Files

	F133210767: D48289.id148756.diff
	Fri, Oct 24, 12:22 AM

	Unknown Object (File)
	Wed, Oct 22, 11:04 PM

	Unknown Object (File)
	Sun, Oct 12, 1:27 PM

	Unknown Object (File)
	Sun, Oct 12, 6:59 AM

	Unknown Object (File)
	Sat, Oct 11, 8:56 PM

	Unknown Object (File)
	Sat, Oct 11, 8:15 PM

	Unknown Object (File)
	Sat, Oct 11, 7:40 PM

	Unknown Object (File)
	Sat, Oct 11, 6:07 PM

View All 48 Files

Subscribers

Details

Reviewers

jhb
andrew
manu

Group Reviewers

Commits

rG16f0d01f9ca1: arm64: apple: fix aic for !SMP configurations

Summary

Record the BSP CPU identification in attach for later use in our
bus_setup_intr implementation.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jan 2 2025, 4:37 PM

Herald added a reviewer: manu. · View Herald TranscriptJan 2 2025, 4:37 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

kevans requested review of this revision.Jan 2 2025, 4:37 PM

Harbormaster completed remote builds in B61460: Diff 148679.Jan 2 2025, 4:37 PM

andrew accepted this revision.Jan 2 2025, 5:43 PM

This revision is now accepted and ready to land.Jan 2 2025, 5:43 PM

jhb added inline comments.Jan 2 2025, 8:04 PM

sys/arm64/apple/apple_aic.c
141	I would be tempted to make #ifdef's a bit smaller by keeping sc_cpuids around always so that only sc_ipimasks and sc_ipi_srcs are under the #ifdef. It means you will end up allocating a single-element array for sc_cpuids, but that's fine. No one will probably use a UP kernel anyway so I'd optimize for minimizing diffs.

Reverse course, just move sc_cpuids out from underneath SMP and let it allocatee
a single-entry sc_cpuids. The overhead of still doing intr_irq_next_cpu() is
minimal since it's simply a PCPU_GET(cpuid) on !SMP kernels.

This revision now requires review to proceed.Jan 3 2025, 10:26 PM

Harbormaster completed remote builds in B61497: Diff 148756.Jan 3 2025, 10:27 PM

jhb accepted this revision.Jan 9 2025, 9:17 PM

This revision is now accepted and ready to land.Jan 9 2025, 9:17 PM

Closed by commit rG16f0d01f9ca1: arm64: apple: fix aic for !SMP configurations (authored by kevans). · Explain WhyJan 10 2025, 4:28 AM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG16f0d01f9ca1: arm64: apple: fix aic for !SMP configurations.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

apple/

5 lines

Diff 149035

sys/arm64/apple/apple_aic.c

Loading...