Record the BSP CPU identification in attach for later use in our
bus_setup_intr implementation.
Details
Details
- Reviewers
jhb andrew manu - Group Reviewers
arm64 - Commits
- rG16f0d01f9ca1: arm64: apple: fix aic for !SMP configurations
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 61460 Build 58344: arc lint + arc unit
Event Timeline
| sys/arm64/apple/apple_aic.c | ||
|---|---|---|
| 142 | I would be tempted to make #ifdef's a bit smaller by keeping sc_cpuids around always so that only sc_ipimasks and sc_ipi_srcs are under the #ifdef. It means you will end up allocating a single-element array for sc_cpuids, but that's fine. No one will probably use a UP kernel anyway so I'd optimize for minimizing diffs. | |
Comment Actions
Reverse course, just move sc_cpuids out from underneath SMP and let it allocatee
a single-entry sc_cpuids. The overhead of still doing intr_irq_next_cpu() is
minimal since it's simply a PCPU_GET(cpuid) on !SMP kernels.