Differential D46080

arm64/vmm: Support tlbi from VHE
ClosedPublic
Actions

Authored by andrew on Jul 23 2024, 11:20 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, May 23, 12:46 AM

	Unknown Object (File)
	Wed, May 20, 12:21 PM

	Unknown Object (File)
	Tue, Apr 28, 5:35 PM

	Unknown Object (File)
	Tue, Apr 28, 5:29 PM

	Unknown Object (File)
	Fri, Apr 24, 4:43 PM

	Unknown Object (File)
	Apr 22 2026, 11:33 PM

	Unknown Object (File)
	Apr 16 2026, 12:55 AM

	Unknown Object (File)
	Apr 15 2026, 12:45 PM

View All 93 Files

Subscribers

Details

Reviewers

Group Reviewers

arm64
bhyve

Commits

rG5577bb2f67ff: arm64/vmm: Support tlbi from VHE

Summary

When invalidating the stage 2 TLB we need to ensure page tables updates
have completed and for tlbi vmalle1is the HCR_EL2 TGE flag needs to be
clear.

To fix the former add a data barrier before the tlbi instructions. On
non-VHE this will happen as part of the exception entry, so is only
needed for VHE.

The tlbi vmalle1is instruction operates on the EL2 & 0 regime when
HCR_EL2 E2H and TGE flags are both set. By clearing the TGE flag it
will stop this and operate on the EL1 & 0 regime we are expecting.

Sponsored by: Arm Ltd

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jul 23 2024, 11:20 AM

Herald added a reviewer: manu. · View Herald TranscriptJul 23 2024, 11:20 AM

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B58778: Diff 141261.Jul 23 2024, 11:20 AM

andrew requested review of this revision.Jul 23 2024, 11:20 AM

andrew added a parent revision: D46079: arm64/vmm: Only store the guest par_el1.

andrew added a child revision: D46081: arm64/vmm: Update exception vectors around a guest.

This revision was not accepted when it landed; it landed in state Needs Review.Aug 20 2024, 9:03 AM

Closed by commit rG5577bb2f67ff: arm64/vmm: Support tlbi from VHE (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG5577bb2f67ff: arm64/vmm: Support tlbi from VHE.

Revision Contents
Changeset List

Path

Size

sys/

arm64/

vmm/

24 lines

Diff 142242

sys/arm64/vmm/vmm_hyp.c

Loading...