arm64: Fix the gicv3 check in locore.S
ClosedPublic
Actions

Authored by andrew on Jun 7 2024, 2:27 PM.

Details

Reviewers

Group Reviewers

Commits

rGaf603143e873: arm64: Fix the gicv3 check in locore.S
rG94865825c014: arm64: Fix the gicv3 check in locore.S
rG57ef7935eb11: arm64: Fix the gicv3 check in locore.S

Summary

In locore.S we need to configure access to the GICv3. To check if it's
available we read the id_aa64pfr0_el1 register, however we then only
check if a GICv3.0 or 4.0 is present. If the system has a GICv4.1 this
check would fail.

Move to checking if the GICV3+ is not absent so this will still work if
the field is updated again.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

andrew created this revision.Jun 7 2024, 2:27 PM

Herald added a reviewer: manu. · View Herald TranscriptJun 7 2024, 2:27 PM

Herald added subscribers: emaste, imp. · View Herald Transcript

andrew requested review of this revision.Jun 7 2024, 2:27 PM

andrew added a parent revision: D45529: arm64: Support counter access with E2H.

Harbormaster completed remote builds in B58103: Diff 139625.Jun 7 2024, 2:27 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jul 23 2024, 9:52 AM

Closed by commit rG57ef7935eb11: arm64: Fix the gicv3 check in locore.S (authored by andrew). · Explain Why

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rG57ef7935eb11: arm64: Fix the gicv3 check in locore.S.

andrew added a commit: rG94865825c014: arm64: Fix the gicv3 check in locore.S.Sep 2 2024, 8:51 AM

andrew added a commit: rGaf603143e873: arm64: Fix the gicv3 check in locore.S.Sep 2 2024, 9:13 AM

Revision Contents
Changeset List

Path

Size

sys/

arm64/

locore.S

5 lines

Diff 141248

View Options

arm64: Fix the gicv3 check in locore.SClosedPublicActions