Differential D45870

ixl: Use GL_RXERR1 register for correct oversize packet count
ClosedPublic
Actions

Authored by Yogesh.Bhosale_intel.com on Jul 4 2024, 10:15 AM.

Tags

None

Referenced Files

	F174215124: D45870.diff
	Thu, Oct 1, 10:28 AM

	Unknown Object (File)
	Fri, Sep 11, 8:10 AM

	Unknown Object (File)
	Wed, Sep 9, 8:55 AM

	Unknown Object (File)
	Aug 25 2026, 4:46 PM

	Unknown Object (File)
	Aug 25 2026, 3:25 PM

	Unknown Object (File)
	Aug 25 2026, 12:05 PM

	Unknown Object (File)
	Aug 15 2026, 8:03 AM

	Unknown Object (File)
	Aug 9 2026, 12:56 AM

Subscribers

Details

Reviewers

Group Reviewers

Intel Networking
Restricted Owners Package	(Owns No Changed Paths)

Commits

rGfef4249f0728: ixl(4): Use GL_RXERR1 register for correct oversize packet count

Summary

The driver sets the Maximum Transmission Unit (MTU) at the Virtual Station Interface(VSI) level, which leads to a discrepancy in the GLPRT_ROC counter's ability to accurately tally oversized packets, as this counter operates at the physical port level. To rectify this issue, it is necessary to take an additional register (GL_RXERR1) into account to obtain the correct count of oversized packets.

Signed-off-by: Yogesh Bhosale yogesh.bhosale@intel.com

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Yogesh.Bhosale_intel.com created this revision.Jul 4 2024, 10:15 AM

Owners added a reviewer: Restricted Owners Package.Jul 4 2024, 10:15 AM

Herald added subscribers: ae, imp. · View Herald TranscriptJul 4 2024, 10:15 AM

Yogesh.Bhosale_intel.com requested review of this revision.Jul 4 2024, 10:15 AM

erj accepted this revision as: erj.Jul 10 2024, 6:00 PM

erj accepted this revision.

This revision is now accepted and ready to land.Jul 10 2024, 6:00 PM

I don't know if we'll see any other comments from anyone else on this, so I'll probably go and commit this sometime in the next couple days.

zlei added a subscriber: zlei.Aug 21 2024, 3:17 AM

Closed by commit rGfef4249f0728: ixl(4): Use GL_RXERR1 register for correct oversize packet count (authored by erj). · Explain WhyAug 27 2024, 11:09 PM

This revision was automatically updated to reflect the committed changes.

erj added a commit: rGfef4249f0728: ixl(4): Use GL_RXERR1 register for correct oversize packet count.

@Yogesh.Bhosale_intel.com I forgot to change the commit header to have you as the author; I'll fix that if/when I do the MFC.

Revision Contents
Changeset List

Path

Size

sys/

dev/

ixl/

i40e_register.h

12 lines

1 line

4 lines

158 lines

Diff 142551

sys/dev/ixl/i40e_register.h

Loading...

sys/dev/ixl/i40e_type.h

Loading...

sys/dev/ixl/ixl_pf.h

Loading...

sys/dev/ixl/ixl_pf_main.c

Loading...