Page MenuHomeFreeBSD

irdma(4): use related vnet for searching netdev
ClosedPublic

Authored by bartosz.sobczak_intel.com on Aug 24 2023, 8:35 PM.
Tags
None
Referenced Files
F165051726: D41592.diff
Wed, Aug 5, 2:17 PM
Unknown Object (File)
Sun, Aug 2, 3:15 AM
Unknown Object (File)
Sun, Aug 2, 2:43 AM
Unknown Object (File)
Sat, Aug 1, 4:35 AM
Unknown Object (File)
Thu, Jul 30, 5:13 PM
Unknown Object (File)
Mon, Jul 27, 6:07 PM
Unknown Object (File)
Sun, Jul 26, 2:18 PM
Unknown Object (File)
Fri, Jul 17, 8:56 AM

Details

Summary

It was found through testing that when ULP uses individual vnet, the search for the correct vlan_id may failing because of no proper interface with given address.

The solution is to use vnet associated to the connection whenever possible.

Signed-off-by: Bartosz Sobczak <bartosz.sobczak@intel.com>

Sponsored by: Intel Corporation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Sep 12 2023, 9:27 PM
anzhu_netapp.com added inline comments.
sys/dev/irdma/irdma_cm.c
1648

ip6_ifp_find() is independent of VIMAGE. It can take "vnet" as input parameter unconditionally.

Would it be simplified if vnet is declared with the default value "&init_net"?

1677

Same. ip_ifp_find() is independent of VIMAGE. It can take "vnet" as input parameter unconditionally.

Would it be simplified if vnet is declared with the default value "&init_net"?

I was preparing to push this yesterday, but I forgot to do the last step; I think @anzhu_netapp.com has a good point here because it'll reduce the number of VIMAGE blocks, but I probably would still push it and would just wait for a fix later.

In D41592#953793, @erj wrote:

I was preparing to push this yesterday, but I forgot to do the last step; I think @anzhu_netapp.com has a good point here because it'll reduce the number of VIMAGE blocks, but I probably would still push it and would just wait for a fix later.

Yeah, i agree, we can do that arrangement. I'll prepare subsequent change as soon as possible, in the meantime i think it could go in as it is.

Yep, cosmetic issue can be addressed separately.