Feed Advanced Search

Fri, Jun 22

erj updated the diff for D15927: Update ixl(4) man page.

Remove (bailed)s

Fri, Jun 22, 7:04 PM
erj added a comment to D15927: Update ixl(4) man page.
In D15927#338138, @pi wrote:

Yes, please add sections on how to use both tools, and reference the ports (sysutils/intel-qcu and
sysutils/intel-nvmupdate).

I've looked up 'bailed' on dict.leo.org but did not find a valid translation. What are those 'bailed' devices ?

Fri, Jun 22, 6:51 PM
erj added a comment to D15927: Update ixl(4) man page.

Should I add a section about the QCU and nvmupdate utilities? They have ports, but I don't think they have manpages, so I don't know how to properly reference them.

Fri, Jun 22, 6:40 PM
erj updated the diff for D15927: Update ixl(4) man page.

Add acronym expansions and info on qualified module check.

Fri, Jun 22, 6:38 PM
erj added a comment to D15927: Update ixl(4) man page.
In D15927#337633, @pi wrote:

Please expand LOM to 'onboard interfaces (LAN on Motherboard, LOM)', if possible. I'm a 30-years user of ethernet, but I've never heard that abbreviation.

I don't think it's that rare of an abbreviation, but I can add the expansion.

If an admin can see if an interface is external or LOM, by whatever magic, can you write about it in the man page ?

I looked into this yesterday, and there may not be a 100% accurate way to do this in the driver. I can add something and maybe identify exceptions.

Fri, Jun 22, 5:15 PM

Thu, Jun 21

erj added a comment to D15927: Update ixl(4) man page.
In D15927#337347, @pi wrote:

Thanks -- will that be written down somewhere in the man page ? Who is selling EXL cards, because I've never found that ? And: What is LOM ?

Thu, Jun 21, 5:17 PM
erj added a comment to D15927: Update ixl(4) man page.
In D15927#337295, @pi wrote:

Can you tell if the boards now accept foreign/unsupported SFP+ modules ? Is there a flag now for this
or does it still insist to only accept intel-branded SFP+ modules ?

Thu, Jun 21, 12:10 AM

Wed, Jun 20

erj added a comment to D15927: Update ixl(4) man page.

Any additional information that should be added to the man page? Some stats descriptions? iflib sysctls? More VF usage information?

Wed, Jun 20, 11:06 PM
erj accepted D15720: Assorted TSO fixes for em(4)/iflib(9) and dead code removal from em(4).
Wed, Jun 20, 10:19 PM
erj committed rS335462: ixl(4): Fix gcc build errors.
ixl(4): Fix gcc build errors
Wed, Jun 20, 10:17 PM
erj updated the summary of D15927: Update ixl(4) man page.
Wed, Jun 20, 7:47 PM
erj updated the diff for D15927: Update ixl(4) man page.

Address comments.

Wed, Jun 20, 6:00 PM
erj added a reviewer for D15927: Update ixl(4) man page: Intel Networking.
Wed, Jun 20, 4:27 PM
erj created D15927: Update ixl(4) man page.
Wed, Jun 20, 4:26 PM

Tue, Jun 19

erj updated the summary of D15577: Update ixl(4) to use iflib..
Tue, Jun 19, 5:47 PM
erj committed rS335358: ixl(4): Remove ixlvc.c from files.amd64.
ixl(4): Remove ixlvc.c from files.amd64
Tue, Jun 19, 3:11 AM

Mon, Jun 18

erj committed rS335339: ixl(4): Update version number to 2.0.0-k.
ixl(4): Update version number to 2.0.0-k
Mon, Jun 18, 8:33 PM
erj committed rS335338: ixl(4): Update to use iflib.
ixl(4): Update to use iflib
Mon, Jun 18, 8:13 PM
erj closed D15577: Update ixl(4) to use iflib..
Mon, Jun 18, 8:13 PM
erj added a comment to D15577: Update ixl(4) to use iflib..

Any last-minute objections? This is the version that's going in!

Mon, Jun 18, 6:03 PM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Commit iflib style fixes separately.

Mon, Jun 18, 5:46 PM
erj committed rS335322: iflib: Style fixes.
iflib: Style fixes
Mon, Jun 18, 5:28 PM
erj updated the diff for D15577: Update ixl(4) to use iflib..
  • Revert "ixl(4): Increase default ITR values to 500 (1000us)"
Mon, Jun 18, 4:43 PM

Thu, Jun 14

erj added a comment to D15577: Update ixl(4) to use iflib..

You might want to go for some middle ground here. 1ms is a bit much (even for us).

Thu, Jun 14, 6:24 PM

Wed, Jun 13

erj updated the diff for D15577: Update ixl(4) to use iflib..

Based on a report by @gallatin:

Wed, Jun 13, 8:50 PM

Tue, Jun 12

erj updated the diff for D15577: Update ixl(4) to use iflib..

Comment out printf()'s introduced in previous commit

Tue, Jun 12, 12:11 AM

Mon, Jun 11

erj updated the diff for D15577: Update ixl(4) to use iflib..

Add these changes from Chris

Mon, Jun 11, 10:53 PM

Thu, Jun 7

erj updated the diff for D15577: Update ixl(4) to use iflib..

Update to exclude code in D15558, since that is now committed.

Thu, Jun 7, 1:58 PM
erj committed rS334779: iflib: Record TCP checksum info in iflib when TCP checksum is requested.
iflib: Record TCP checksum info in iflib when TCP checksum is requested
Thu, Jun 7, 1:09 PM
erj closed D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Thu, Jun 7, 1:09 PM · Intel Networking

Mon, Jun 4

erj added a comment to D15558: iflib: Record TCP checksum info in iflib for ixl(4).

@gallatin I'm assuming you no longer have any objections to this patch?

Mon, Jun 4, 5:55 PM · Intel Networking

Sat, May 26

erj updated the diff for D15577: Update ixl(4) to use iflib..

Include contents of/update to D15558 again, since relying on dependent revisions
in Phabricator is a PITA.

Sat, May 26, 1:43 AM
erj added a dependency for D15577: Update ixl(4) to use iflib.: D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Sat, May 26, 1:20 AM
erj added a dependent revision for D15558: iflib: Record TCP checksum info in iflib for ixl(4): D15577: Update ixl(4) to use iflib..
Sat, May 26, 1:20 AM · Intel Networking
erj updated the diff for D15577: Update ixl(4) to use iflib..

Pulled out TCP saving changes since those are in D15558

Sat, May 26, 1:20 AM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Update due to D15575 being committed.

Sat, May 26, 1:09 AM
erj closed D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
Sat, May 26, 12:46 AM
erj committed rS334231: iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN.
iflib: Add new shared flag: IFLIB_ADMIN_ALWAYS_RUN
Sat, May 26, 12:46 AM

Fri, May 25

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Move stats increment in IPv6 case to match IPv4 case
Fri, May 25, 11:18 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Fri, May 25, 11:17 PM · Intel Networking
erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Remove comment and restore/fix setting CSUM_IP6_TCP flag during TSO6
Fri, May 25, 10:52 PM · Intel Networking
erj added inline comments to D15558: iflib: Record TCP checksum info in iflib for ixl(4).
Fri, May 25, 7:52 PM · Intel Networking
erj updated the diff for D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
  • Make style fix.
Fri, May 25, 7:37 PM
erj abandoned D5214: Convert ixl(4)to use iflib.

Replaced by https://reviews.freebsd.org/D15577

Fri, May 25, 7:19 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 7:00 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:59 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:58 PM
erj updated the summary of D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:54 PM
erj updated the diff for D15577: Update ixl(4) to use iflib..

Remove testing config files and make spelling fixes.

Fri, May 25, 6:52 PM
erj created D15577: Update ixl(4) to use iflib..
Fri, May 25, 6:50 PM
erj set the repository for D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN to rS FreeBSD src repository.
Fri, May 25, 5:46 PM
erj created D15575: iflib: Add new shared flag to iflib: IFLIB_ADMIN_ALWAYS_RUN.
Fri, May 25, 5:45 PM

May 24 2018

erj updated the diff for D15558: iflib: Record TCP checksum info in iflib for ixl(4).
  • iflib: Fixup changes made to record TCP checksum info in iflib for ixl
May 24 2018, 9:27 PM · Intel Networking
erj updated the summary of D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 6:30 PM · Intel Networking
erj added 1 blocking reviewer(s) for D15558: iflib: Record TCP checksum info in iflib for ixl(4): shurd.
May 24 2018, 6:20 PM · Intel Networking
erj created D15558: iflib: Record TCP checksum info in iflib for ixl(4).
May 24 2018, 6:16 PM · Intel Networking

May 14 2018

erj committed rS333149: ixl(4): Update to 1.9.9-k.
ixl(4): Update to 1.9.9-k
May 14 2018, 2:07 PM

May 7 2018

erj committed rS333343: MFC r333149: ixl(4): Update to 1.9.9-k.
MFC r333149: ixl(4): Update to 1.9.9-k
May 7 2018, 11:23 PM
erj committed rS333336: MFC r326571: ifconfig(8): Display extended compliance code string for SFP….
MFC r326571: ifconfig(8): Display extended compliance code string for SFP…
May 7 2018, 9:26 PM
erj committed rS333331: MFC r319797, r320972:.
MFC r319797, r320972:
May 7 2018, 8:41 PM

Apr 17 2018

erj updated the summary of D5214: Convert ixl(4)to use iflib.
Apr 17 2018, 12:34 AM
erj updated the summary of D5214: Convert ixl(4)to use iflib.
Apr 17 2018, 12:33 AM
erj updated the diff for D5214: Convert ixl(4)to use iflib.

Update converted version of ixl(4) to 1.9.8-k; includes some other bugfixes and updates.

Apr 17 2018, 12:32 AM

Apr 8 2018

erj accepted D14985: ixl(4): Update to 1.9.9-k.

I've reviewed this patch-by-patch; it all looks good to me. We just need to make sure validation says it compiles and does what it's supposed to, too.

Apr 8 2018, 6:38 PM
erj added a comment to D14967: split out flag manipulation from general context manipulation in iflib.

Y'all want this committed?

Apr 8 2018, 5:35 PM

Apr 6 2018

erj accepted D14967: split out flag manipulation from general context manipulation in iflib.

I don't see the console hanging on the version of ixl-iflib where I did see them when watchdogs happened, so this appears to fix the deadlock in that situation.

Apr 6 2018, 7:02 PM
erj added a comment to D14984: Sleep rather than spin in e1000 when doing long running config operations.
In D14984#315219, @bcr wrote:

When I read the title of the review, I thought it was some kind of medical advice for sysadmins or something. ;-)
Sorry, this does not help the review, just wanted to let you know.

Apr 6 2018, 5:16 PM

Mar 19 2018

erj committed rS331224: ixgbe(4): Update shared code, add support for X552 1G, fix bug.
ixgbe(4): Update shared code, add support for X552 1G, fix bug
Mar 19 2018, 10:40 PM
erj closed D2046: Fix races during ixl SR-IOV initialization.
Mar 19 2018, 10:38 PM
erj closed D2050: ixl: Propagate link state changes to VFs.
Mar 19 2018, 10:38 PM
erj closed D13885: ixgbe(4): Update shared code, add support for X552, fix bug.

Committed in rS331224.

Mar 19 2018, 10:37 PM

Feb 14 2018

erj added a comment to D13980: Fix ixl driver performance issue.

You mentioned polling in a previous comment -- did you make changes to the kernel to enable that? I'm assuming you've also made changes to the driver as well, since we don't have polling support in the driver.

Feb 14 2018, 6:07 PM

Feb 13 2018

erj added a comment to D13980: Fix ixl driver performance issue.

As I look at this more, I don't think that last section of the patch is right. ixl_rxeof() makes that same DD bit check in the for-loop; it's supposed to have processed as many descriptors as it can by the time it hits the end of the function.

Feb 13 2018, 12:54 AM

Feb 9 2018

erj requested changes to D13980: Fix ixl driver performance issue.

Until Chris's questions get answered.

Feb 9 2018, 7:57 PM

Feb 7 2018

erj added a member for Intel Networking: jeb.
Feb 7 2018, 11:07 PM
erj awarded Dev Summit Attendee to recipient: erj.
Feb 7 2018, 11:05 PM
erj added a member for committers: jeb.
Feb 7 2018, 11:03 PM
erj accepted D13980: Fix ixl driver performance issue.

These changes look good to me, but I'm going to add a co-worker to get his opinion, too. We may want to delay committing this until we get our internal updated version of ixl(4) committed.

Feb 7 2018, 11:01 PM
erj committed rS328998: Add Jeb Cramer (jeb@) as a src committer..
Add Jeb Cramer (jeb@) as a src committer.
Feb 7 2018, 10:54 PM

Feb 6 2018

erj committed rD51408: Refresh PGP subkey expiration for erj, too..
Refresh PGP subkey expiration for erj, too.
Feb 6 2018, 10:21 PM
erj committed rD51407: Refresh PGP key..
Refresh PGP key.
Feb 6 2018, 10:20 PM

Jan 22 2018

erj committed rS328265: ixv(4): Stop setting editing ifnet flags in ixv_if_init().
ixv(4): Stop setting editing ifnet flags in ixv_if_init()
Jan 22 2018, 8:56 PM

Jan 11 2018

erj committed rS327842: e1000: Fix typos in value written to register and a comment.
e1000: Fix typos in value written to register and a comment
Jan 11 2018, 7:25 PM
erj accepted D13858: 1 << 31 redux.

The changes to the Intel ethernet drivers look fine to me.

Jan 11 2018, 5:54 PM
erj added a comment to D13766: Introduce mallocarray() in the kernel.

Is this going to be MFC'd into stable/10 and/or stable/11?

Jan 11 2018, 5:52 PM

Jan 10 2018

erj added a comment to D13833: Make use of the newly introduce mallocarray(9)..
In D13833#290191, @erj wrote:

Why didn't they provide a calloc(), to follow the malloc()/free() pattern?

(It looks like this was introduced in rS327674)

Jan 10 2018, 9:57 PM
erj accepted D13833: Make use of the newly introduce mallocarray(9)..
Jan 10 2018, 9:54 PM
erj added a comment to D13833: Make use of the newly introduce mallocarray(9)..

Why didn't they provide a calloc(), to follow the malloc()/free() pattern?

Jan 10 2018, 9:49 PM

Jan 4 2018

erj added inline comments to D13660: e1000: Add support for Ice Lake and Cannon Lake.
Jan 4 2018, 7:18 PM
erj added inline comments to D13660: e1000: Add support for Ice Lake and Cannon Lake.
Jan 4 2018, 7:12 PM

Jan 3 2018

erj abandoned D7802: ixl(4)/ixlv(4): MFC 1.4.27-k and fixes to stable/10.

@erj Do you want to abandon this review in light of your work on newer releases?

Jan 3 2018, 9:22 PM · Intel Networking

Jan 2 2018

erj added a comment to D13660: e1000: Add support for Ice Lake and Cannon Lake.

We don't have anything for the Ice Lake hardware, but the Cannon Lake stuff looks like it's good.

Jan 2 2018, 8:39 PM

Dec 21 2017

erj committed rS327051: ixgbe(4): Fix build error on i386..
ixgbe(4): Fix build error on i386.
Dec 21 2017, 12:35 AM

Dec 20 2017

erj committed rS327031: ixgbe(4): Convert driver to use iflib.
ixgbe(4): Convert driver to use iflib
Dec 20 2017, 6:35 PM
erj closed D11727: ixgbe(4): Update HEAD to use iflib.

Committed in rS327031.

Dec 20 2017, 6:30 PM

Dec 5 2017

erj committed rS326571: ifconfig(8): Display extended compliance code string for SFP transceivers.
ifconfig(8): Display extended compliance code string for SFP transceivers
Dec 5 2017, 6:42 PM
erj closed D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Dec 5 2017, 6:42 PM

Nov 28 2017

erj updated the summary of D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Nov 28 2017, 7:03 PM
erj added reviewers for D13286: ifconfig(8): Display extended compliance code for SFP transceivers: melifaro, hselasky.
Nov 28 2017, 6:39 PM
erj created D13286: ifconfig(8): Display extended compliance code for SFP transceivers.
Nov 28 2017, 6:38 PM