Committed.

Committed in 015f8cc5b0c10336a048f37a7071ea03516de242.

@gallatin Do you see the Stack tab?

In D39930#943725, @kbowling wrote:

@erj can you post the draft driver update, I'd like to see how it intends to use this patch stack before commentary

Committed in rG5b5f7d0e77a9eee73eb5d596f43aef4e1a3674d8.

Update value used for IFLIB_FEATURE_SUB_INTERFACES

Rebase on latest main; remove whitespace error

Rebase on latest main

@bartosz.sobczak_intel.com Could you re-upload this patch with all of the diff context?

In D43093#982800, @fernape wrote:

I can't find ice(4). Where is it?

$ uname -a
FreeBSD vm-current 15.0-CURRENT FreeBSD 15.0-CURRENT #18 main-n266137-ede5d4ff5b39: Thu Oct 26 21:44:36 CEST 2023     root@vm-current:/usr/obj/usr/src/amd64.amd64/sys/GENERIC amd64
$ man 4 ice
No manual entry for ice

Committed in rG9c30461dd25bac49045acbeac10e00b6cc13d2bc.

I was preparing to push this yesterday, but I forgot to do the last step; I think @anzhu_netapp.com has a good point here because it'll reduce the number of VIMAGE blocks, but I probably would still push it and would just wait for a fix later.

I'll add an MFC period of 1 month as a reminder to check in about merging this update back to stable/13.

I'm going to agree with @kbowling here -- it looks like it's a driver bug / reasonable to fail if the driver sets IFCAP_TXCSUM without setting the CSUM_* bits that it supports for transmit checksumming.

I wish this was uploaded with context, but I'm not an expert on RDMA so I'm not sure it would let me review this code better.

Any new thoughts on this review or the previous one in the stack? I'd like to get these in for 14.0-RELEASE.

Update variable names and sysctl help string

In D41324#941005, @marius wrote:

This change doesn't acutally fix white space violations but introduces additional ones as according to style(9): 'Second level indents are four spaces'.

@jeffrey.e.pieper_intel.com Applying this revision using "arc patch" should pull all the parent revisions, too, but we'll have to double check to make sure.

Split changes out into different Differential revisions for easier review