Page MenuHomeFreeBSD

dan.mcgregor_usask.ca (Dan McGregor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 23 2015, 3:50 AM (464 w, 3 d)

Recent Activity

Mon, May 13

dan.mcgregor_usask.ca added a comment to D45147: sockstat: Fix segfault when peer has no pid.

Thanks, @tuexen and @emaste. This does affect my NFS server on every version I've tried in the 14-STABLE or 15-CURRENT series. 13.3 is unaffected. Looks like everything since commit a83d596f434f in 2022.

Mon, May 13, 4:29 PM

Fri, May 10

dan.mcgregor_usask.ca added reviewers for D45147: sockstat: Fix segfault when peer has no pid: glebius, tuexen, karels.
Fri, May 10, 4:40 PM
dan.mcgregor_usask.ca requested review of D45147: sockstat: Fix segfault when peer has no pid.
Fri, May 10, 2:44 AM

Apr 2 2024

dan.mcgregor_usask.ca updated the summary of D44547: rust: remap debuginfo.
Apr 2 2024, 4:06 PM
dan.mcgregor_usask.ca added a comment to D44547: rust: remap debuginfo.

A bit more explanation, this is the old output:

note: tuple variant defined here
   --> /wrkdirs/usr/ports/lang/rust/work/rustc-1.77.0-src/library/core/src/result.rs:506:5
help: you can convert an `i64` to a `u64` and panic if the converted value doesn't fit

And the new output for the same error:

note: tuple variant defined here
   --> /usr/local/lib/rustlib/src/rust/library/core/src/result.rs:506:5
    |
506 |     Ok(#[stable(feature = "rust1", since = "1.0.0")] T),
    |     ^^
help: you can convert an `i64` to a `u64` and panic if the converted value doesn't fit
Apr 2 2024, 4:00 PM

Mar 28 2024

dan.mcgregor_usask.ca added reviewers for D44547: rust: remap debuginfo: rust, mikael.
Mar 28 2024, 4:53 PM
dan.mcgregor_usask.ca requested review of D44547: rust: remap debuginfo.
Mar 28 2024, 4:51 PM

Nov 3 2023

dan.mcgregor_usask.ca added a comment to D42432: mountd: Allow spaces in directory paths.

It looks ok to me now. Do you have a commit bit?
(If not, I can commit it.)

Nov 3 2023, 3:58 AM

Nov 2 2023

dan.mcgregor_usask.ca added inline comments to D42432: mountd: Allow spaces in directory paths.
Nov 2 2023, 4:53 PM
dan.mcgregor_usask.ca updated the diff for D42432: mountd: Allow spaces in directory paths.

Added requested strnvis error checking.

Nov 2 2023, 4:51 PM
dan.mcgregor_usask.ca added inline comments to D42432: mountd: Allow spaces in directory paths.
Nov 2 2023, 3:31 PM

Nov 1 2023

dan.mcgregor_usask.ca added a reviewer for D42434: bhyve(8): fix manpage formatting: corvink.
Nov 1 2023, 7:28 PM
dan.mcgregor_usask.ca added a comment to D42358: Add support for an exports.db to mountd.

Neat. I should have looked at Phabricator before I created D42432. I think they should be considered together. And the patched version of zfs (I haven't looked, of course), should also consider special characters in mount point names if it doesn't.

Nov 1 2023, 6:38 PM
dan.mcgregor_usask.ca added a comment to D42434: bhyve(8): fix manpage formatting.

Specifically, it caused options to be omitted from entries created after the TPM device option:

Nov 1 2023, 6:31 PM
dan.mcgregor_usask.ca requested review of D42434: bhyve(8): fix manpage formatting.
Nov 1 2023, 6:21 PM
dan.mcgregor_usask.ca updated the diff for D42432: mountd: Allow spaces in directory paths.

Include example export entry with spaces

Nov 1 2023, 6:06 PM
dan.mcgregor_usask.ca updated the diff for D42432: mountd: Allow spaces in directory paths.

Updated the exports(5) manual page.

Nov 1 2023, 6:03 PM
dan.mcgregor_usask.ca added a comment to D42432: mountd: Allow spaces in directory paths.

Hm. Missed updating the documentation. I'll update that too.

Nov 1 2023, 6:02 PM
dan.mcgregor_usask.ca updated the summary of D42432: mountd: Allow spaces in directory paths.
Nov 1 2023, 5:45 PM
dan.mcgregor_usask.ca requested review of D42432: mountd: Allow spaces in directory paths.
Nov 1 2023, 5:42 PM

May 4 2023

dan.mcgregor_usask.ca accepted D39968: lang/gcc11-devel: Enable support for .init_array and .fini_array.

This looks good to me. It's more clear than my proposal of just force-enabling it, and looks like it's something that can be pushed upstream.

May 4 2023, 11:18 PM

Apr 28 2023

dan.mcgregor_usask.ca added inline comments to D39841: lang/gcc13: Add port.
Apr 28 2023, 5:18 PM
dan.mcgregor_usask.ca added inline comments to D39841: lang/gcc13: Add port.
Apr 28 2023, 5:04 PM
dan.mcgregor_usask.ca added inline comments to D39841: lang/gcc13: Add port.
Apr 28 2023, 4:03 AM

Apr 27 2023

dan.mcgregor_usask.ca added a comment to D37007: minio: Update licence to AGPLv3.
In D37007#907380, @bofh wrote:

When there are two different MAINTAINER you should create two different reviews.

Apr 27 2023, 11:07 PM
dan.mcgregor_usask.ca added inline comments to D39841: lang/gcc13: Add port.
Apr 27 2023, 11:00 PM
dan.mcgregor_usask.ca updated the diff for D37007: minio: Update licence to AGPLv3.

Update to latest main

Apr 27 2023, 10:25 PM
dan.mcgregor_usask.ca added a reviewer for D37007: minio: Update licence to AGPLv3: bofh.
Apr 27 2023, 10:21 PM

Jan 10 2023

dan.mcgregor_usask.ca added a comment to D37722: Add new rc: machine_id to generate /etc/machine-id.

This is good, but it doesn't match what Linux does. Both systemd and dbus generate 32 character UUID strings, while this creates 36 character ones.

Jan 10 2023, 7:20 PM

Oct 28 2022

dan.mcgregor_usask.ca added a comment to D37140: rubygem-google-protobuf: Use hidden symbols.

Thanks for taking a look. I don't think the change to the 3.19 port is strictly necessary, but as I said in a private email to @mfechner, I do believe that hiding symbols is good practice for ruby gems.

Oct 28 2022, 4:04 PM

Oct 27 2022

dan.mcgregor_usask.ca added a comment to D37140: rubygem-google-protobuf: Use hidden symbols.

Also created this pull request.

Oct 27 2022, 7:43 PM

Oct 26 2022

dan.mcgregor_usask.ca added a reviewer for D37140: rubygem-google-protobuf: Use hidden symbols: mfechner.
Oct 26 2022, 9:17 PM
dan.mcgregor_usask.ca requested review of D37140: rubygem-google-protobuf: Use hidden symbols.
Oct 26 2022, 9:17 PM

Oct 14 2022

dan.mcgregor_usask.ca requested review of D37007: minio: Update licence to AGPLv3.
Oct 14 2022, 7:31 PM

Feb 18 2021

dan.mcgregor_usask.ca added inline comments to D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 2:34 AM
dan.mcgregor_usask.ca added inline comments to D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 1:49 AM
dan.mcgregor_usask.ca added a comment to D28765: RFC: Use file-prefix-map to lie about kernel build paths.

There are a few more, mostly to do with generated files containing full paths that escape. They're coming too.

Feb 18 2021, 12:27 AM
dan.mcgregor_usask.ca requested review of D28765: RFC: Use file-prefix-map to lie about kernel build paths.
Feb 18 2021, 12:27 AM
dan.mcgregor_usask.ca added a comment to D28764: RFC: Use file-prefix-map to lie about build paths.

This is a large portion of the userland changes to give consistent debug data path data no matter the source or object directories. There are more reviews coming.

Feb 18 2021, 12:24 AM
dan.mcgregor_usask.ca requested review of D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 12:22 AM

Feb 17 2021

dan.mcgregor_usask.ca added a comment to D28632: Add fileprefixmap compiler feature.

Thanks for the review. I'm not a committer, so I can't submit it myself.

Feb 17 2021, 5:10 PM

Feb 12 2021

dan.mcgregor_usask.ca added reviewers for D28632: Add fileprefixmap compiler feature: brooks, emaste, bapt.
Feb 12 2021, 10:36 PM
dan.mcgregor_usask.ca requested review of D28632: Add fileprefixmap compiler feature.
Feb 12 2021, 10:24 PM
dan.mcgregor_usask.ca added a reviewer for D28594: Fix nvi catalog generation: emaste.
Feb 12 2021, 10:17 PM
dan.mcgregor_usask.ca added a comment to D28626: build: kern: support per-KERNCONF LOCAL_MODULES overrides.

Thank you so much for this. I thought of doing it myself.

Feb 12 2021, 10:16 PM
dan.mcgregor_usask.ca updated the diff for D28596: flex: regen bootstrap files.

Update for the one minor change left after 80f31432743446a1e8e4f8cb8268b74ac4e4f2da

Feb 12 2021, 2:43 AM
dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640302, @jkim wrote:
Feb 12 2021, 12:10 AM
dan.mcgregor_usask.ca updated the diff for D28596: flex: regen bootstrap files.

Don't update bootstrap version requirement.

Feb 12 2021, 12:09 AM

Feb 11 2021

dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640192, @jkim wrote:

BTW, initparse.c and initparse.h were generated with yacc. Therefore, it is technically "regen after byacc 20200330 (r363170)".

Feb 11 2021, 9:56 PM
dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640180, @jkim wrote:

I still don't like to change the bootstrap requirement. Other than that, it looks good to me.

Feb 11 2021, 9:19 PM
dan.mcgregor_usask.ca updated the diff for D28596: flex: regen bootstrap files.

Restore NULL check style.

Feb 11 2021, 9:02 PM
dan.mcgregor_usask.ca added a reviewer for D28596: flex: regen bootstrap files: araujo.
Feb 11 2021, 8:52 PM
dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640171, @jkim wrote:

There is no need to change bootstrap requirement because the old lex can build head just fine AFAICT. Although it's nice to update the generated files, I don't see any functional changes between two.

Feb 11 2021, 8:47 PM
dan.mcgregor_usask.ca changed the repository for D28594: Fix nvi catalog generation from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Feb 11 2021, 8:40 PM
dan.mcgregor_usask.ca changed the repository for D28586: Source repo changes for adding new committer Rajesh Kumar from rS FreeBSD src repository - subversion to rG FreeBSD src repository.
Feb 11 2021, 8:40 PM
dan.mcgregor_usask.ca changed the repository for D28586: Source repo changes for adding new committer Rajesh Kumar from rG FreeBSD src repository to rS FreeBSD src repository - subversion.
Feb 11 2021, 8:40 PM
dan.mcgregor_usask.ca added a reviewer for D28596: flex: regen bootstrap files: jkim.
Feb 11 2021, 7:39 PM
dan.mcgregor_usask.ca added a reviewer for D28594: Fix nvi catalog generation: bapt.
Feb 11 2021, 7:33 PM
dan.mcgregor_usask.ca requested review of D28596: flex: regen bootstrap files.
Feb 11 2021, 7:14 PM
dan.mcgregor_usask.ca requested review of D28594: Fix nvi catalog generation.
Feb 11 2021, 7:05 PM

Feb 16 2018

dan.mcgregor_usask.ca added inline comments to D9925: en_CA and fr_CA switch to ISO8601 date format.
Feb 16 2018, 2:19 PM

Mar 8 2017

dan.mcgregor_usask.ca updated the diff for D9925: en_CA and fr_CA switch to ISO8601 date format.

Point Phabricator at the right files..

Mar 8 2017, 9:21 PM
dan.mcgregor_usask.ca created D9925: en_CA and fr_CA switch to ISO8601 date format.
Mar 8 2017, 8:56 PM
dan.mcgregor_usask.ca closed D9532: Fix unaligned access in newfs_nandfs.

Commit r314671 is pretty much this change.

Mar 8 2017, 8:43 PM

Feb 22 2017

dan.mcgregor_usask.ca added a comment to D9532: Fix unaligned access in newfs_nandfs.

It may well be a false positive, though I suspect that this warning is given for any pointer access to a member of a packed structure. This wasn't the only warning of its kind I saw, just the only warning where WARNS wasn't already set to 3 or lower.

Feb 22 2017, 8:28 PM

Feb 10 2017

dan.mcgregor_usask.ca added reviewers for D9532: Fix unaligned access in newfs_nandfs: mjg, emaste.
Feb 10 2017, 7:23 PM
dan.mcgregor_usask.ca retitled D9532: Fix unaligned access in newfs_nandfs from to Fix unaligned access in newfs_nandfs.
Feb 10 2017, 7:19 PM

Aug 13 2015

dan.mcgregor_usask.ca retitled D3376: In binutils opcodes avoid left shifting negative values from to In binutils opcodes avoid left shifting negative values.
Aug 13 2015, 9:09 PM
dan.mcgregor_usask.ca accepted D3344: Fix undefined shift of a negative value in libz.
Aug 13 2015, 7:53 PM

Jun 23 2015

dan.mcgregor_usask.ca added a comment to D2045: Add the ability to detect ZFS and GELI encrypted file systems to fstyp(8).

Yes, the checking against MK_ZFS and changing the #define to HAVE_ZFS makes this work with WITHOUT_ZFS. Looks good to me.

Jun 23 2015, 2:45 PM