Page MenuHomeFreeBSD

dan.mcgregor_usask.ca (Dan McGregor)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 23 2015, 3:50 AM (304 w, 1 d)

Recent Activity

Feb 18 2021

dan.mcgregor_usask.ca added inline comments to D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 2:34 AM
dan.mcgregor_usask.ca added inline comments to D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 1:49 AM
dan.mcgregor_usask.ca added a comment to D28765: RFC: Use file-prefix-map to lie about kernel build paths.

There are a few more, mostly to do with generated files containing full paths that escape. They're coming too.

Feb 18 2021, 12:27 AM
dan.mcgregor_usask.ca requested review of D28765: RFC: Use file-prefix-map to lie about kernel build paths.
Feb 18 2021, 12:27 AM
dan.mcgregor_usask.ca added a comment to D28764: RFC: Use file-prefix-map to lie about build paths.

This is a large portion of the userland changes to give consistent debug data path data no matter the source or object directories. There are more reviews coming.

Feb 18 2021, 12:24 AM
dan.mcgregor_usask.ca requested review of D28764: RFC: Use file-prefix-map to lie about build paths.
Feb 18 2021, 12:22 AM

Feb 17 2021

dan.mcgregor_usask.ca added a comment to D28632: Add fileprefixmap compiler feature.

Thanks for the review. I'm not a committer, so I can't submit it myself.

Feb 17 2021, 5:10 PM

Feb 12 2021

dan.mcgregor_usask.ca added reviewers for D28632: Add fileprefixmap compiler feature: brooks, emaste, bapt.
Feb 12 2021, 10:36 PM
dan.mcgregor_usask.ca requested review of D28632: Add fileprefixmap compiler feature.
Feb 12 2021, 10:24 PM
dan.mcgregor_usask.ca added a reviewer for D28594: Fix nvi catalog generation: emaste.
Feb 12 2021, 10:17 PM
dan.mcgregor_usask.ca added a comment to D28626: build: kern: support per-KERNCONF LOCAL_MODULES overrides.

Thank you so much for this. I thought of doing it myself.

Feb 12 2021, 10:16 PM
dan.mcgregor_usask.ca updated the diff for D28596: flex: regen bootstrap files.

Update for the one minor change left after 80f31432743446a1e8e4f8cb8268b74ac4e4f2da

Feb 12 2021, 2:43 AM
dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640302, @jkim wrote:
Feb 12 2021, 12:10 AM
dan.mcgregor_usask.ca updated the diff for D28596: flex: regen bootstrap files.

Don't update bootstrap version requirement.

Feb 12 2021, 12:09 AM

Feb 11 2021

dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640192, @jkim wrote:

BTW, initparse.c and initparse.h were generated with yacc. Therefore, it is technically "regen after byacc 20200330 (r363170)".

Feb 11 2021, 9:56 PM
dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640180, @jkim wrote:

I still don't like to change the bootstrap requirement. Other than that, it looks good to me.

Feb 11 2021, 9:19 PM
dan.mcgregor_usask.ca updated the diff for D28596: flex: regen bootstrap files.

Restore NULL check style.

Feb 11 2021, 9:02 PM
dan.mcgregor_usask.ca added a reviewer for D28596: flex: regen bootstrap files: araujo.
Feb 11 2021, 8:52 PM
dan.mcgregor_usask.ca added a comment to D28596: flex: regen bootstrap files.
In D28596#640171, @jkim wrote:

There is no need to change bootstrap requirement because the old lex can build head just fine AFAICT. Although it's nice to update the generated files, I don't see any functional changes between two.

Feb 11 2021, 8:47 PM
dan.mcgregor_usask.ca changed the repository for D28594: Fix nvi catalog generation from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.
Feb 11 2021, 8:40 PM
dan.mcgregor_usask.ca changed the repository for D28586: Source repo changes for adding new committer Rajesh Kumar from rS FreeBSD src repository - subversion to R10 FreeBSD src repository.
Feb 11 2021, 8:40 PM
dan.mcgregor_usask.ca changed the repository for D28586: Source repo changes for adding new committer Rajesh Kumar from R10 FreeBSD src repository to rS FreeBSD src repository - subversion.
Feb 11 2021, 8:40 PM
dan.mcgregor_usask.ca added a reviewer for D28596: flex: regen bootstrap files: jkim.
Feb 11 2021, 7:39 PM
dan.mcgregor_usask.ca added a reviewer for D28594: Fix nvi catalog generation: bapt.
Feb 11 2021, 7:33 PM
dan.mcgregor_usask.ca requested review of D28596: flex: regen bootstrap files.
Feb 11 2021, 7:14 PM
dan.mcgregor_usask.ca requested review of D28594: Fix nvi catalog generation.
Feb 11 2021, 7:05 PM

Feb 16 2018

dan.mcgregor_usask.ca added inline comments to D9925: en_CA and fr_CA switch to ISO8601 date format.
Feb 16 2018, 2:19 PM

Mar 8 2017

dan.mcgregor_usask.ca updated the diff for D9925: en_CA and fr_CA switch to ISO8601 date format.

Point Phabricator at the right files..

Mar 8 2017, 9:21 PM
dan.mcgregor_usask.ca created D9925: en_CA and fr_CA switch to ISO8601 date format.
Mar 8 2017, 8:56 PM
dan.mcgregor_usask.ca closed D9532: Fix unaligned access in newfs_nandfs.

Commit r314671 is pretty much this change.

Mar 8 2017, 8:43 PM

Feb 22 2017

dan.mcgregor_usask.ca added a comment to D9532: Fix unaligned access in newfs_nandfs.

It may well be a false positive, though I suspect that this warning is given for any pointer access to a member of a packed structure. This wasn't the only warning of its kind I saw, just the only warning where WARNS wasn't already set to 3 or lower.

Feb 22 2017, 8:28 PM

Feb 10 2017

dan.mcgregor_usask.ca added reviewers for D9532: Fix unaligned access in newfs_nandfs: mjg, emaste.
Feb 10 2017, 7:23 PM
dan.mcgregor_usask.ca retitled D9532: Fix unaligned access in newfs_nandfs from to Fix unaligned access in newfs_nandfs.
Feb 10 2017, 7:19 PM

Aug 13 2015

dan.mcgregor_usask.ca retitled D3376: In binutils opcodes avoid left shifting negative values from to In binutils opcodes avoid left shifting negative values.
Aug 13 2015, 9:09 PM
dan.mcgregor_usask.ca accepted D3344: Fix undefined shift of a negative value in libz.
Aug 13 2015, 7:53 PM

Jun 23 2015

dan.mcgregor_usask.ca added a comment to D2045: Add the ability to detect ZFS and GELI encrypted file systems to fstyp(8).

Yes, the checking against MK_ZFS and changing the #define to HAVE_ZFS makes this work with WITHOUT_ZFS. Looks good to me.

Jun 23 2015, 2:45 PM