Fix unaligned access in newfs_nandfs
ClosedPublic
Actions

Authored by dan.mcgregor_usask.ca on Feb 10 2017, 7:19 PM.

Details

Reviewers

emaste
mjg

Commits

rS314671: newfs_nandfs: Fix unaligned pointer warning

Summary

Clang 4 now warns about unaligned access inside packed structures. Fix unaligned
access in newfs_nandfs.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7342
Build 7509: arc lint + arc unit

Event Timeline

dan.mcgregor_usask.ca updated this revision to Diff 24980.Feb 10 2017, 7:19 PM

dan.mcgregor_usask.ca retitled this revision from to Fix unaligned access in newfs_nandfs.

dan.mcgregor_usask.ca updated this object.

dan.mcgregor_usask.ca edited the test plan for this revision. (Show Details)

dan.mcgregor_usask.ca added reviewers: mjg, emaste.Feb 10 2017, 7:23 PM

dan.mcgregor_usask.ca set the repository for this revision to rS FreeBSD src repository - subversion.

emaste added a subscriber: dim.Feb 10 2017, 7:52 PM

I think this is fine, but it feels like a Clang false-positive to me.
(fsdata.f_uuid is at offset 64 in nandfs_fsdata)

This revision is now accepted and ready to land.Feb 17 2017, 7:50 PM

It may well be a false positive, though I suspect that this warning is given for any pointer access to a member of a packed structure. This wasn't the only warning of its kind I saw, just the only warning where WARNS wasn't already set to 3 or lower.

Commit r314671 is pretty much this change.

Revision Contents
Changeset List

Path

Size

sbin/

newfs_nandfs/

newfs_nandfs.c

4 lines

Diff 24980

View Options

sbin/newfs_nandfs/newfs_nandfs.c

Fix unaligned access in newfs_nandfsClosedPublicActions