Page MenuHomeFreeBSD

Fix unaligned access in newfs_nandfs
ClosedPublic

Authored by dan.mcgregor_usask.ca on Feb 10 2017, 7:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 8, 10:37 PM
Unknown Object (File)
Mon, May 27, 11:27 PM
Unknown Object (File)
May 17 2024, 5:32 AM
Unknown Object (File)
May 14 2024, 6:10 PM
Unknown Object (File)
Apr 20 2024, 12:43 AM
Unknown Object (File)
Jan 2 2024, 9:09 AM
Unknown Object (File)
Dec 20 2023, 8:09 AM
Unknown Object (File)
Nov 21 2023, 6:53 PM
Subscribers

Details

Summary

Clang 4 now warns about unaligned access inside packed structures. Fix unaligned
access in newfs_nandfs.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7342
Build 7509: arc lint + arc unit

Event Timeline

dan.mcgregor_usask.ca retitled this revision from to Fix unaligned access in newfs_nandfs.
dan.mcgregor_usask.ca updated this object.
dan.mcgregor_usask.ca edited the test plan for this revision. (Show Details)
emaste edited edge metadata.

I think this is fine, but it feels like a Clang false-positive to me.
(fsdata.f_uuid is at offset 64 in nandfs_fsdata)

This revision is now accepted and ready to land.Feb 17 2017, 7:50 PM

It may well be a false positive, though I suspect that this warning is given for any pointer access to a member of a packed structure. This wasn't the only warning of its kind I saw, just the only warning where WARNS wasn't already set to 3 or lower.