Page MenuHomeFreeBSD

flex: regen bootstrap files
ClosedPublic

Authored by dan.mcgregor_usask.ca on Feb 11 2021, 7:14 PM.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

There is no need to change bootstrap requirement because the old lex can build head just fine AFAICT. Although it's nice to update the generated files, I don't see any functional changes between two.
Also, 0 -> NULL changes were not mine.

https://svnweb.freebsd.org/changeset/base/298241

In D28596#640171, @jkim wrote:

There is no need to change bootstrap requirement because the old lex can build head just fine AFAICT. Although it's nice to update the generated files, I don't see any functional changes between two.

The built lex works just fine, and is functionally the same. I did this for reproducibility, lex built from old lex is not binary identical to one built from new lex. This is one change of many I have in my queue to have binary identical output of make buildworld and buildkernel, no matter the host.

Also, 0 -> NULL changes were not mine.

https://svnweb.freebsd.org/changeset/base/298241

Good to know about that. This is literally me just regenerating the files, so I'll maintain the NULL check style.

I still don't like to change the bootstrap requirement. Other than that, it looks good to me.

In D28596#640180, @jkim wrote:

I still don't like to change the bootstrap requirement. Other than that, it looks good to me.

That's fair. In the general case I suppose people won't care, and if a person wants to guarantee a reproducible build they can force the bootstrap tools.

if a person wants to guarantee a reproducible build they can force the bootstrap tools.

Exactly.

BTW, initparse.c and initparse.h were generated with yacc. Therefore, it is technically "regen after byacc 20200330 (r363170)".

In D28596#640192, @jkim wrote:

BTW, initparse.c and initparse.h were generated with yacc. Therefore, it is technically "regen after byacc 20200330 (r363170)".

Right! I've been sitting on this for the better part of a year, and my original commit message was 'update flex'.. not exactly helpful for making a quality commit message when submitting upstream ;)

dan.mcgregor_usask.ca edited the summary of this revision. (Show Details)

Don't update bootstrap version requirement.

dan.mcgregor_usask.ca retitled this revision from Regenerate flex bootstrap files. to flex: regen bootstrap files.
dan.mcgregor_usask.ca edited the summary of this revision. (Show Details)

Update for the one minor change left after 80f31432743446a1e8e4f8cb8268b74ac4e4f2da

Please regen initskel.c because flex.skl was updated in 6b7e592c215fb76ea027f25030ddc9a697184fbe. Note it was also MFC'ed to stable/13 and releng/13.0.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 19 2021, 6:31 PM
This revision was automatically updated to reflect the committed changes.