Page MenuHomeFreeBSD

rubygem-google-protobuf: Use hidden symbols
ClosedPublic

Authored by dan.mcgregor_usask.ca on Oct 26 2022, 9:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 5, 3:44 PM
Unknown Object (File)
Apr 13 2023, 12:49 AM
Unknown Object (File)
Apr 13 2023, 12:49 AM
Unknown Object (File)
Apr 13 2023, 12:48 AM
Unknown Object (File)
Apr 13 2023, 12:43 AM
Unknown Object (File)
Mar 5 2023, 6:01 PM
Unknown Object (File)
Feb 21 2023, 8:23 AM
Unknown Object (File)
Feb 17 2023, 4:38 PM

Details

Summary

The Linux and Darwin builds hide the symbols in the native shared
object. This prevents some symbol collisions if this gem is loaded
alongside certain others (that should probably also hide their symbols).

This fixes numerous issues with gitaly and protobuf 3.20 and newer.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thanks a lot, I tested it and can confirm that fixes the problem. @sunpoet could you please commit this, as you are the maintainer of these ports.
Thanks a lot.

This revision is now accepted and ready to land.Oct 28 2022, 2:32 PM

Thanks for taking a look. I don't think the change to the 3.19 port is strictly necessary, but as I said in a private email to @mfechner, I do believe that hiding symbols is good practice for ruby gems.

The change to 3.2x *is* necessary, though.