Page MenuHomeFreeBSD
Differential D3376

In binutils opcodes avoid left shifting negative values
ClosedPublic
Actions

Authored by dan.mcgregor_usask.ca on Aug 13 2015, 9:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 11, 12:24 AM
Unknown Object (File)
Wed, Jun 10, 10:43 AM
Unknown Object (File)
Fri, May 22, 1:11 AM
Unknown Object (File)
Mon, May 18, 7:50 AM
Unknown Object (File)
Mon, May 18, 7:50 AM
Unknown Object (File)
Sun, May 17, 10:59 PM
Unknown Object (File)
Sun, May 17, 7:31 PM
Unknown Object (File)
Sun, May 17, 6:42 PM
View All Files
Subscribers
andrew
imp

Details

Reviewers
dim
Commits
rS289078: MFC r288099:
rS288099: In binutils' arm-dis.c, avoid left-shifting a negative number.
Summary

In binutils, avoid undefined behaviour in arm opcodes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dan.mcgregor_usask.ca updated this revision to Diff 7934.Aug 13 2015, 9:09 PM
dan.mcgregor_usask.ca retitled this revision from to In binutils opcodes avoid left shifting negative values.
dan.mcgregor_usask.ca updated this object.
dan.mcgregor_usask.ca edited the test plan for this revision. (Show Details)
dan.mcgregor_usask.ca added a reviewer: dim.
dan.mcgregor_usask.ca set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added subscribers: andrew, imp. · View Herald TranscriptAug 13 2015, 9:09 PM
dim accepted this revision.Aug 13 2015, 9:22 PM
dim edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Aug 13 2015, 9:22 PM
Closed by commit rS288099: In binutils' arm-dis.c, avoid left-shifting a negative number. (authored by dim). · Explain WhySep 22 2015, 9:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
contrib/
binutils/
opcodes/
2 lines

Diff 8877

View Options

head/contrib/binutils/opcodes/arm-dis.c

Loading...