ix(4): Add support for debug dump for E610 adapters

[Yogesh.Bhosale_intel.com]

Summary

This is part 2 of the support for the new Intel Ethernet E610 family of devices.

Intel E610 Ethernet Controller devices feature a debug dump capability that allows you to capture runtime register values directly from the hardware, with assistance from the firmware. These registers are organized into clusters based on their function, enabling targeted debugging. This information is consolidated into a single dump file, facilitating the debugging of complex issues encountered in the field. The debug dump provides a snapshot of the device's current hardware configuration, including switch tables, transmit scheduler tables, and other relevant data. It captures the state of specified clusters and serves as a stateless snapshot of the entire device.

This update introduces ioctl and sysctl support for the debug dump feature.

Signed-off-by: Yogesh Bhosale [e-mail]
Co-developed-by: Krzysztof Galazka [e-mail]

[kbowling]

@kgalazka Nothing jumping out to me here for feedback on the code. I don't have an E610 so I can't do anything with this.. it looks like this is maybe a support tool where the file is sent to Intel for assistance, but if we can embellish anything as to how an end user might use any of this on their own that would be a worthwhile followup.

[erj]

sys/dev/ixgbe/if_ix.c

1493

Maybe it's because I've only been looking at Intel drivers and what they do with this ioctl, but maybe this check should get moved up into iflib.

[kbowling]

sys/dev/ixgbe/if_ix.c

1493

That's a good point.

In the case of non-iflib drivers, this would be the first thing in the registered ioctl handler for a driver interface. So looking at this code I would suggest moving this check up into ixgbe_if_priv_ioctl now, it doesn't seem like anything should let through without the priv_check.

And then make a new review with @erj suggestion to do this before calling IFDI_PRIV_IOCTL in iflib.c.. make it contractual that priv_ioctl has been priv_checked and this code can be dropped.

[Yogesh.Bhosale_intel.com]

This is part 2 of the support for the new Intel Ethernet E610 family of devices

Intel E610 Ethernet Controller devices feature a debug dump capability that
allows you to capture runtime register values directly from the hardware,
with assistance from the firmware. These registers are organized into clusters
based on their function, enabling targeted debugging. This information is
consolidated into a single dump file, facilitating the debugging of complex
issues encountered in the field. The debug dump provides a snapshot of the
device's current hardware configuration, including switch tables, transmit
scheduler tables, and other relevant data. It captures the state of specified
clusters and serves as a stateless snapshot of the entire device.

This update introduces ioctl and sysctl support for the debug dump feature.

Signed-off-by: Yogesh Bhosale [e-mail]
Co-developed-by: Krzysztof Galazka [e-mail]

[Yogesh.Bhosale_intel.com]

Rebased on main

[Yogesh.Bhosale_intel.com]

Following up on the previous comments, I've added documentation for the debug dump feature. This is currently under review here: https://reviews.freebsd.org/D52990

Eric's suggestion to move the priv check up to iflib will be addressed in a separate change.

[gowtham.kumar.ks_intel.com]

Verified the Debug dump feature