Differential D53245

igb(4): Fix VLAN support on VFs
Needs ReviewPublic
Actions

Authored by kgalazka on Tue, Oct 21, 4:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 22, 4:31 AM

	Unknown Object (File)
	Wed, Oct 22, 2:14 AM

	Unknown Object (File)
	Wed, Oct 22, 1:47 AM

	Unknown Object (File)
	Wed, Oct 22, 12:12 AM

	Unknown Object (File)
	Wed, Oct 22, 12:06 AM

	Unknown Object (File)
	Tue, Oct 21, 8:39 PM

Subscribers

Details

Reviewers

erj
kbowling
jmg

Group Reviewers

Intel Networking

Summary

Virtual Functions are considered untrusted and have no control
over VLAN filtering configuration in HW. To allow using
VLANs on VF intreface driver has to assume that VLAN HW Filtering
is always enabled and pass requests for adding or removing VLAN
tags to Physical Function driver using Mailbox API.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67972
Build 64855: arc lint + arc unit

Event Timeline

kgalazka created this revision.Tue, Oct 21, 4:54 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 21, 4:54 PM

kgalazka requested review of this revision.Tue, Oct 21, 4:54 PM

Harbormaster completed remote builds in B67972: Diff 164703.Tue, Oct 21, 4:54 PM

kgalazka added a parent revision: D52976: igb(4): Fix out-of-bounds register access on VFs.Tue, Oct 21, 4:54 PM

kgalazka added reviewers: erj, kbowling, jmg, Intel Networking.

kbowling accepted this revision.Tue, Oct 21, 6:43 PM

erj added inline comments.Wed, Oct 22, 5:43 PM

sys/dev/e1000/if_em.c
4108	Are you sure that you want to KASSERT() here? Could this be called by a PF that doesn't have the vf_ifp pointer set?

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

34 lines

Diff 164703

sys/dev/e1000/if_em.c

Loading...