igb(4): Fix VLAN support on VFs
ClosedPublic
Actions

Authored by kgalazka on Tue, Oct 21, 4:54 PM.

Details

Reviewers

erj
kbowling
jmg
gowtham.kumar.ks_intel.com

Group Reviewers

Intel Networking

Commits

rG1839526b7315: igb(4): Fix VLAN support on VFs

Summary

Virtual Functions are considered untrusted and have no control
over VLAN filtering configuration in HW. To allow using
VLANs on VF intreface driver has to assume that VLAN HW Filtering
is always enabled and pass requests for adding or removing VLAN
tags to Physical Function driver using Mailbox API.

Signed-off-by: Krzysztof Galazka <krzysztof.galazka@intel.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kgalazka created this revision.Tue, Oct 21, 4:54 PM

Herald added a subscriber: imp. · View Herald TranscriptTue, Oct 21, 4:54 PM

kgalazka requested review of this revision.Tue, Oct 21, 4:54 PM

Harbormaster completed remote builds in B67972: Diff 164703.Tue, Oct 21, 4:54 PM

kgalazka added a parent revision: D52976: igb(4): Fix out-of-bounds register access on VFs.Tue, Oct 21, 4:54 PM

kgalazka added reviewers: erj, kbowling, jmg, Intel Networking.

kbowling accepted this revision.Tue, Oct 21, 6:43 PM

erj added inline comments.Wed, Oct 22, 5:43 PM

sys/dev/e1000/if_em.c
4108	Are you sure that you want to KASSERT() here? Could this be called by a PF that doesn't have the vf_ifp pointer set?

kgalazka added inline comments.Thu, Oct 23, 6:10 PM

sys/dev/e1000/if_em.c
4108	We might have misunderstanding here. vf_ifp is not a pointer. It's a flag set in em_identify_hardware: https://cgit.freebsd.org/src/tree/sys/dev/e1000/if_em.c#n2387 I agree that it is quite confusing, and some refactoring would make sense.