and as long as it builds
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 24 2021
In D26123#647294, @debdrup wrote:It's possible Phabricator mangled things.
What I wanted you to do was:
1: Change 'seem' to 'appear'
2: Put the full path to /etc/rc.conf (instead of just rc.conf).
In D28914#647282, @gbe wrote:LGTM from manpages . Did you run igor and 'mandoc -Tlint' against the man page?
LGTM. I think the comments are unnecessary though.
Reorder SEE ALSO section to fix mandoc -T lint warning.
In D26123#647294, @debdrup wrote:It's possible Phabricator mangled things.
What I wanted you to do was:
1: Change 'seem' to 'appear'
2: Put the full path to /etc/rc.conf (instead of just rc.conf).
Not calling VOP_GETATTR was a feature of the patch. At least, you can do it based on the object type?
It's possible Phabricator mangled things.
LGTM from manpages . Did you run igor and 'mandoc -Tlint' against the man page?
The comment about why could use some help, though, I supposed.
That would be my assumption.
Looks ok to me; Do we assume that no kmods from port would still use this?
Forgot to add manpage to share/man/man9/Makefile
I am wrong on that, it is indeed a page.
No objection, but please do not target this for releng/13.0 (13.0-RELEASE), as it is my opinion it is too late for such a change at this point in the cycle.
- Fixes for tmpfs and shm objects.
In D28892#647134, @mm wrote:In D28892#647126, @nyan wrote:In D28892#646718, @ak wrote:Also, I just noticed that in half of return statements we don't use parentheses, which is violation of style(7).
Yes, but it's a difference of style between FreeBSD and NetBSD.
So I don't change it.Are we importing the whole file or just changes? If it is just changes, then our style(7) should take precedence. If the whole file is imported and kept "in sync" with NetBSD, we should consider moving it to contrib/
After rebase
In D28906#647143, @mikael wrote:In D28906#647082, @arrowd wrote:When preparing a bootstrap it is advised to build with all OPTIONS set to OFF to save space and build time. Would you mind rerolling it again? If you don't want to do this, let's just commit it.
Only the GMP option is set.