According to description of the Data In Polarity register,
configuring pin's corresponding bit to '1' inverts the
value its input. Hitherto configuration during attach
unconditionally set the invertion for each GPIO pin.
The fix does not help for observed issue. I get almost 100% hang rate on PCIE init on McBin when booting with DT from U-Boot and EDK2.
It will boot further 100% times with the GPIO driver probe disabled. I'll update this patch and add another GPIO driver fix - with those McBin passed 100x boot loop test.
PCIE hang example of pure today's HEAD:
Boot with the GPIO fixes (this patch + https://reviews.freebsd.org/D29013). Note, there are no ICU update, hence CP110 MMC timeout: