Page MenuHomeFreeBSD

iflib: Avoid double counting in rxeof
ClosedPublic

Authored by markj on Feb 23 2021, 3:51 PM.

Details

Summary

iflib_rxeof() was counting everything twice. This was introduced when
pfil hooks were added to iflib. I believe we want to count rx
packets/bytes before the pfil hooks are executed, so remove the counter
adjustments that are executed after.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markj requested review of this revision.Feb 23 2021, 3:51 PM
erj added inline comments.
sys/net/iflib.c
2926–2927

So then, this is the one place that the stats should be incremented

sys/net/iflib.c
2926–2927

Correct. The deleted lines run after pfil hooks run, and so won't count dropped (recycled) packets.

This revision is now accepted and ready to land.Feb 23 2021, 8:16 PM
This revision was automatically updated to reflect the committed changes.