Page MenuHomeFreeBSD

iflib: Avoid double counting in rxeof
ClosedPublic

Authored by markj on Feb 23 2021, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 13 2024, 12:49 PM
Unknown Object (File)
Dec 22 2023, 11:11 PM
Unknown Object (File)
Dec 20 2023, 1:08 AM
Unknown Object (File)
Dec 12 2023, 2:44 PM
Unknown Object (File)
Nov 25 2023, 4:51 PM
Unknown Object (File)
Nov 23 2023, 4:40 AM
Unknown Object (File)
Nov 22 2023, 5:31 PM
Unknown Object (File)
Nov 12 2023, 9:26 PM
Subscribers

Details

Summary

iflib_rxeof() was counting everything twice. This was introduced when
pfil hooks were added to iflib. I believe we want to count rx
packets/bytes before the pfil hooks are executed, so remove the counter
adjustments that are executed after.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37317
Build 34206: arc lint + arc unit

Event Timeline

markj requested review of this revision.Feb 23 2021, 3:51 PM
erj added inline comments.
sys/net/iflib.c
2926–2927

So then, this is the one place that the stats should be incremented

sys/net/iflib.c
2926–2927

Correct. The deleted lines run after pfil hooks run, and so won't count dropped (recycled) packets.

This revision is now accepted and ready to land.Feb 23 2021, 8:16 PM
This revision was automatically updated to reflect the committed changes.