Page MenuHomeFreeBSD

all: drop support for FreeBSD 13 and MIPS/riscv64sf
Needs ReviewPublic

Authored by rene on Mon, Mar 2, 9:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 20, 7:58 AM
Unknown Object (File)
Fri, Mar 20, 7:58 AM
Unknown Object (File)
Fri, Mar 20, 7:58 AM
Unknown Object (File)
Fri, Mar 20, 6:27 AM
Unknown Object (File)
Thu, Mar 19, 8:37 AM
Unknown Object (File)
Wed, Mar 18, 5:45 AM
Unknown Object (File)
Wed, Mar 18, 5:38 AM
Unknown Object (File)
Tue, Mar 17, 5:48 PM

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 71413
Build 68296: arc lint + arc unit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

No objection from office@

fluffy added a reviewer: office.

Thanks. Looks good for sysutils/tmux and sysutils/arc_summary.

looks good for security/openvpn-devel

I am a bit confused why two completely diffrent topics are handled in one review.

Can I handle wifi-firmware-kmod separately?

net/wifi-firmware-kmod/Makefile.inc
94

There needs to be more cleanup done there; can I preempt this or do it separately?

se added inline comments.
filesystems/fusefs-libs3/Makefile
26 ↗(On Diff #173039)

The extra patch file files/extra-patch-test_meson.build should also be removed from the filesystems/fusefs-libs3 port.

For both my affected ports, this just removes the "disabled on MIPS", so fine with me.

In the LLVM ports, the lines like:

_BE_LIBS_Mips=		AsmParser Disassembler
_BE_LIBS_BACKWARDS_Mips=Exegesis

Should not be removed as the Mips backend will continue to be built when default options are used and these are needed to ensure the files are handled correctly. The changes removing support from the FREEBSD and NATIVE targets are fine.

Thanks for your work, LGTM for games/anki.

@rene Thanks for the fantastic work. However I believe you are missing some important part like riscv64sf. You can have a look at this.
https://people.freebsd.org/~bofh/dropzone/0001-EOL-of-13.X.patch
or https://reviews.freebsd.org/D55642
Which ever is convenient for you.

Hmm, I didn't grep good enough I guess. I'll remove riscv64sf too.

In D55624#1273192, @fuz wrote:

No objections as far as my sole affected port (devel/objconv) is concerned.
net/aoe should probably removed entirely, as it is broken on all supported versions of FreeBSD (FreeBSD 15 breaks the same way afaik) and attempts to repair it have not been fruitful.

We can just deprecate net/aoe as broken and let it expire?

I am a bit confused why two completely diffrent topics are handled in one review.

What do you mean? The only other thing this patch removes is some workarounds for the now-unsupported 15.0 before it became RELEASE

In D55624#1273320, @bz wrote:

Can I handle wifi-firmware-kmod separately?

Go ahead :)

net-p2p/tremotesf/Makefile
16–31

The sole purpose of conditional is to check if the system where port being built on has OpenSSL 3 as cpp-httplib requires it. The edit suggestion I made is the actual stuff I planned a long ago for a moment releng/13 becomes unsupported.

Modification to games/flightgear-data looks good to me, thanks!

In D55624#1273192, @fuz wrote:

No objections as far as my sole affected port (devel/objconv) is concerned.
net/aoe should probably removed entirely, as it is broken on all supported versions of FreeBSD (FreeBSD 15 breaks the same way afaik) and attempts to repair it have not been fruitful.

We can just deprecate net/aoe as broken and let it expire?

Yes, that would be a possibility. Otherwise, someone could go ahead and process bugs 194663 and 239891 in the hope that this could fix things.

Note for MIPS: sysutils/zidrav missing
as it uses mips conditionals too.
I can fix that by hand later.

Note: for MIPS mail/rmilter missing.
(not my port)

Edit: both ports are included.
the search does not find partial matches here.

ok (graphics/wings)

jbeich requested changes to this revision.Thu, Mar 5, 1:15 AM
jbeich added inline comments.
x11-wm/sway/Makefile
58

14.3 (aka 1403000) won't reach EOL until 2026-06-30, 2 months after 13.* EOL. Other conditionals are fine to drop.

x11-wm/swayfx/Makefile
61

14.3 (aka 1403000) won't reach EOL until 2026-06-30, 2 months after 13.* EOL. Other conditionals are fine to drop.

This revision now requires changes to proceed.Thu, Mar 5, 1:15 AM

The file net/gotify-server/Makefile does not require that anymore, the new version has updated the build chain and does not required that work-around anymore.

rene marked 3 inline comments as done.
  • x11-wm/sway*: 14.3-RELEASE still needs extra-patch-wordexp
  • net-p2p/tremotesf: simplify as per maintainer suggestion
  • filesystems/fusefs-libs3: remove now unused extra-patch
  • devel/llvm*: restore _BE_LIBS_[BACKWARDS_]Mips
jbeich added inline comments.
x11-wm/sway/Makefile
57

Looks good but maybe further simplify by dropping ${OSVERSION} >= 1400000 part.

x11-wm/swayfx/Makefile
60

Looks good but maybe further simplify by dropping ${OSVERSION} >= 1400000 part.

This revision is now accepted and ready to land.Fri, Mar 6, 9:31 AM

OK for archivers/py-borgbackup

Changes to the following my ports look good:

accessibility/hyprsunset
devel/hyprwire
graphics/gifsicle
misc/qman
x11-toolkits/aquamarine
x11-toolkits/hyprtoolkit
x11-wm/hyprland
x11/contour

Thanks for taking care of them!

  • x11-wm/sway*: simplify OSVERSION conditional
  • all: sync with D55642
  • devel/kyua: only for 13
  • rebase
This revision now requires review to proceed.Thu, Mar 12, 3:08 PM

thanks René, +1 for lang/crystal and also erlang-*

This revision is now accepted and ready to land.Sat, Mar 14, 11:06 AM

I am not competent to review this change.

  • Mk/Uses: remove openssl111 from a comment
  • rebase
This revision now requires review to proceed.Sun, Mar 15, 11:21 AM
rene retitled this revision from all: drop support for FreeBSD 13 and MIPS to all: drop support for FreeBSD 13 and MIPS/riscv64sf.Sun, Mar 15, 11:22 AM
This revision is now accepted and ready to land.Mon, Mar 16, 8:18 AM
This revision now requires review to proceed.Wed, Mar 18, 9:21 PM