Looks good to me.

For both my affected ports, this just removes the "disabled on MIPS", so fine with me.

If you've tested any variant of the uchcom chipset used in a different product model, please help add it, thanks

In D49591#1138122, @ziaee wrote:

In D49591#1138042, @joerg wrote:

Not sure why I'm a reviewer here ...

I tagged you because the log shows you are the one who originally put top in the tree in 1997 for FreeBSD 2.2.2, sir.

Not sure why I'm a reviewer here ...

In D48154#1098320, @mail_fbsd2.e4m.org wrote:

The asterisk and the minus sign form special variables.

That's what I thought as well. But what's mentioned in the manpage are asterisk and underscore ;-).

Updated to reflect Andre's comments.

I had someone testing the driver, and he told me that the chip is still buffering data.
I made one inline comment where it's a bit suspicious to me about two register write operations that I think got lost now.

(accidentally) fixed in commit 4a23b974d4871f8

In D21886#888011, @hselasky wrote:

@joerg : There are some ideas spreading that using usbconfig or making a new libusbconfig or adding something to libusb may be better than just, making custom scripts to handle things.

What do you think?

In D21886#886066, @joerg wrote:

I'll see whether I could modify it for that, but otherwise, it's what I've been looking for.
For devices without a serial number, it falls back to a kind of "location ID" which is probably the best that could be had for those.

In D21886#554613, @jmg wrote:

I took Daniel O'Connor's script from: https://www.mail-archive.com/freebsd-usb@freebsd.org/msg14258.html

and did a minor improvement to support creating a USB path via the hub ports, and have this script now:
https://www.funkthat.com/~jmg/FreeBSD/usbserialsn

In D33586#758927, @hselasky wrote:

Just set the date for tomorrow. There are some external scripts which look for date changes.

In D33586#758912, @hselasky wrote:

Don't forget to bump the manual page date again.

Well, with the additional space, one of the usage lines is now 79 characters ...

Documentation fixes, mainly for -i option

Committed.

Committed.

Further update: use --enable-multilib.

Mentioning @dirs in the resulting pkg-plist had been broken before.

In D30022#676463, @joerg wrote:

The definitive repo is the Git one.

The definitive repo is the Git one.

This is how portfmt formats makefiles. It seems to be more and more popular and is documented in the porter's handbook.

I uploaded my diff against the current SVN as D30095 and added you as a reviewer, Craig @leres