pinging on this so we don't forget about it

LGTM

Let me fire off a build against CURRENT as a sanity check (this might also fix the breakage there)

Restoring patches and bumping PORTREVISION for dbn exp-run

For the record, I found a bug related to HTTP headers with my apps that I was able to reproduce with Mono 5.10, so my apps that were "failing" with 5.12 might not have been a 5.12 issue but something else in the 5.x train that caused it. I'd rather we push this out the barn door before 2018Q3 and then we can look at 5.12 in ports again. It should be much easier to upgrade now.

Let's land this

More changes as suggested by dbn

The analyzed output of "make tests" seems to indicate we are passing them all. They reported results look like this:

In D15780#333909, @dbn wrote:

I have been working on an update and I think some of the changes in that patch [1] will be useful.

In D15780#333908, @dbn wrote:

In D15780#333902, @feld wrote:

Disable USES=display by default. Only used for tests, can hide behind X11 option for now.

I think there is a USES=display:test that should be used in conjunction with X11

Disable USES=display by default. Only used for tests, can hide behind X11 option for now.

Switch to the "really stable" release: 5.10.1.47

I'm seeing a few issues with my mono apps I am testing. After speaking with a developer he strongly suggests we follow the "very stable" release which is what they ship with Visual Studio for Mac. That would be slightly older version 5.10.1.47. I will see if I can get it building and if it passes my requirements I will adjust this review to target that release instead. I'd really like us to have a very stable release of mono to rely on. If we need a separate port for people who want the absolute latest version we could do it.

In D15780#333783, @mat wrote:

In D15780#333772, @feld wrote:

USES=python does not provide /usr/local/bin/python. There are countless places in the build system that call "python" instead of "python2.7" (not shebangs) and I couldn't possibly patch them all just to get this to build. What alternative do we have?

BINARY_ALIAS=  python=${PYTHON_CMD}

5.17. Use BINARY_ALIAS to Rename Commands Instead of Patching the Build

USES=python does not provide /usr/local/bin/python. There are countless places in the build system that call "python" instead of "python2.7" (not shebangs) and I couldn't possibly patch them all just to get this to build. What alternative do we have?

I like it. I think it clarifies the situation while giving us space for discernment.

Add comment about where GH_TUPLE versions came from

Revive some patches, pass testport (leftovers from cert store)

Upload correct copy of the pkg-plist

waste of time. This won't work because we don't even start syslog until much later in boot...

Committing with the suggested change by mat.

Can't test this because a distfile is unavailable: