@jtl Can you close this as it appears @mmacy committed functionally the same thing? Or is there work yet to be done here?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jun 19 2018
bump. @markj Did you want to shovel this into head?
In D15891#336175, @manu wrote:This looks okay for me except one comment.
But due to the fact that I/We had a lot of problems with different revision of the hardware IP let me test on different SoC before commiting.
Also I won't set this review as accepted as I don't know anything about CAM.
Heh, I can accept my own revision. :-)
LGTM, would be good to add the comment @mat mentioned, and also to pet portlint by fixing the "USE_* seen before USES" warning it's giving as well.
Can you provide any test case for that?
This should be fine.
Extend to ixl(4)/ixlv(4) after their conversion to iflib(9) in r335338. Akin e1000,
after that conversion these drivers did redundant setup of interface capabilities in
ixl{v,}_setup_interface() and had defunct (but due to r203548 also obsolete) code
to disable IFCAP_VLAN_HWFILTER by default.
Does the-horrible-version-number port update look good? :-)
- Set DCMAKE_INSTALL_MANDIR only
- Set DISTVERSION and use it where appropriate
- Reuse IKONS in PLIST_FILES and do-install
In D15858#336162, @emaste wrote:See linux_map_osrel
In D15891#336632, @imp wrote:In D15891#336482, @kevans wrote:Please do mention in the commit message that MMCCAM is not usable on Allwinner boards using root-on-MMC to curtail that set of complaints if people actually try it.
why not? What breaks?
In D15891#336482, @kevans wrote:Please do mention in the commit message that MMCCAM is not usable on Allwinner boards using root-on-MMC to curtail that set of complaints if people actually try it.
native-xtools didn't seem to matter much with this
[v2] Fix output of linprocfs stat
Patch needs updating again, the port was touched, see https://svnweb.freebsd.org/ports?view=revision&revision=472677.
I think the CPACK option is a good idea -- so ship if after the change mat requested.
s/Another/A/ as requested by @eadler
Not sure if this is still relevant but no objection from me.
I've never used this script. It's maintained by you, @robak, so how it works and who you want to be a blocking review is up to you.
Seems fine to me though.
Seems fine. What generated files are you talking about exactly?
Match 3.11.4
LGTM. sendmsg(2), by the way, is my least favorite system call of all time.
Sorry, I misread the diff -- you already get rid of the icons here \o/
Sorry, it must have slipped through the cracks. It's fine. Can you bump the .Dd before you commit? Thanks!
- Use outsource building
- Use CMAKE_INSTALL_MANDIR* variables instead of post-patch
pinging on this so we don't forget about it
Use bzero from within the function init_msghdr()