Add uefisign and friends to MK_EFI

[sbruno]

Summary

Yet another knob for making our distro that much smaller.

[imp]

while you're here, maybe it's time to do the uefisign -> efisign with a legacy link.

[sbruno]

In D15211#320576, @imp wrote:

while you're here, maybe it's time to do the uefisign -> efisign with a legacy link.

I'm not sure what you mean. I don't know anything about efisign (is it a stable/11 file)?

[kevans]

In D15211#320617, @sbruno wrote:

In D15211#320576, @imp wrote:

while you're here, maybe it's time to do the uefisign -> efisign with a legacy link.

I'm not sure what you mean. I don't know anything about efisign (is it a stable/11 file)?

Rename uefisign to efisign and create a compat link back to uefisign so that we have consistent names for efi* applications. =)

[sbruno]

Regenerate after some of the pkg base stuff hit the tree.

[sbruno]

In D15211#320576, @imp wrote:

while you're here, maybe it's time to do the uefisign -> efisign with a legacy link.

Huh? I don't know what this means. :-( Was there a time when there was an "efisign" binary and we haven't cleaned it up?

[imp]

No, we've always just used efiFOO for the efi programs.

[sbruno]

In D15211#329987, @imp wrote:

No, we've always just used efiFOO for the efi programs.

Oh, so you're saying that "uefisign" should be a symlink to efisign? I don't know the background here.

[emaste]

In D15211#329988, @sbruno wrote:

In D15211#329987, @imp wrote:

No, we've always just used efiFOO for the efi programs.

Oh, so you're saying that "uefisign" should be a symlink to efisign? I don't know the background here.

Yeah, we had efi in the loader from before UEFI existed, and now also have efibootmgr, efidp and efivar userland binaries.

[sbruno]

In D15211#330017, @emaste wrote:

In D15211#329988, @sbruno wrote:

In D15211#329987, @imp wrote:

No, we've always just used efiFOO for the efi programs.

Oh, so you're saying that "uefisign" should be a symlink to efisign? I don't know the background here.

Yeah, we had efi in the loader from before UEFI existed, and now also have efibootmgr, efidp and efivar userland binaries.

Ok, can someone else who knows more about this take that as an action item? I just want to get this knob into base so I don't have to load a 96MB ramdisk over TFTP.

[emaste]

share/examples/Makefile

34 ↗

(On Diff #43142)

No corresponding conditional LDIRS+=uefisign?

[emaste]

Ok, can someone else who knows more about this take that as an action item?

Yes, just go ahead without worrying about efi vs uefi in this review.

For reference I think the history is:

1. We had EFI support in the loader to support ia64 long before UEFI existed
2. uefisign was added to support UEFI secure boot, which did not exist in EFI
3. other efi* tools were added for EFI variables etc. - these things did exist in EFI, but were just not implemented in FreeBSD until long after UEFI existed

[sbruno]

usr.sbin/Makefile

124 ↗

(On Diff #43142)

I am now seriously confused. After building my image I still have these three tools in my install directory. Something isn't right.

[sbruno]

Add missing LDIRS for uefisign

[sbruno]

Exclude MK_EFI things if OPENSSL is unset with some better
syntax.

[sbruno]

um

WITHOUT_EFI="YES" seems to do nothing.

[sbruno]

root@lab:/home/sbruno/bsd/fbsd_head # env | grep SRCCONF
SRCCONF=/home/sbruno/bsd/src.conf.efitest
root@lab:/home/sbruno/bsd/fbsd_head # cat ${SRCCONF}
WTTHOUT_EFI="YES"
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old DESTDIR=/tftpboot/netboot
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old MK_EFI=no DESTDIR=/tftpboot/netboot                                                                                                                                                    
>>> Removing old files (only deletes safe to delete libs)
remove /tftpboot/netboot/usr/sbin/efibootmgr?

[imp]

usr.sbin/Makefile

124 ↗

(On Diff #43212)

No. This isn't correct. You want to just add:

.if ${MK_OPENSSL} != "no"
SUBDIR.${MK_EFI}+= uefisign
.endif

[sbruno]

hrm ... WITH_EFI="NO" has zero effect as well. So, I'm stumped.

root@lab:/home/sbruno/bsd/fbsd_head # setenv SRCCONF /home/sbruno/bsd/src.conf.efitest
root@lab:/home/sbruno/bsd/fbsd_head # env | grep SRCCONF
SRCCONF=/home/sbruno/bsd/src.conf.efitest
root@lab:/home/sbruno/bsd/fbsd_head # cat ${SRCCONF}
WTTH_EFI="NO"
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old DESTDIR=/tftpboot/netboot
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old MK_EFI=no DESTDIR=/tftpboot/netboot                                                                                                                                                    
>>> Removing old files (only deletes safe to delete libs)
remove /tftpboot/netboot/usr/sbin/efibootmgr?

[emaste]

Is setting it in the environment expected to work? What about make SRCCONF=/foo/bar/baz ...?

[sbruno]

Don't nuke *all* the efi tools if OPENSSL isn't installed. (imp)

[sbruno]

In D15211#330335, @emaste wrote:

Is setting it in the environment expected to work? What about make SRCCONF=/foo/bar/baz ...?

Yah, __MAKE_CONF in the evironment is works too.

[sbruno]

Ok, wow.

In D15211#330309, @sbruno wrote:

root@lab:/home/sbruno/bsd/fbsd_head # env | grep SRCCONF
SRCCONF=/home/sbruno/bsd/src.conf.efitest
root@lab:/home/sbruno/bsd/fbsd_head # cat ${SRCCONF}
WTTHOUT_EFI="YES"
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old DESTDIR=/tftpboot/netboot
>>> Removing old files (only deletes safe to delete libs)
>>> Old files removed
>>> Removing old directories
>>> Old directories removed
To remove old libraries run 'make delete-old-libs'.
root@lab:/home/sbruno/bsd/fbsd_head # make delete-old MK_EFI=no DESTDIR=/tftpboot/netboot                                                                                                                                                    
>>> Removing old files (only deletes safe to delete libs)
remove /tftpboot/netboot/usr/sbin/efibootmgr?

Note that WTTHOUT_EFI="YES" is not WITHOUT_EFI="YES"

Damn fonts.

This all works as it should now.

[emaste]

tools/build/mk/OptionalObsoleteFiles.inc

1618–1621 ↗

(On Diff #43233)

sort in alpha order

[sbruno]

Sort by alpha as per @emaste.