Page MenuHomeFreeBSD

aniketp (Aniket Pandey)
User

Projects

User does not belong to any projects.

User Details

User Since
May 14 2018, 9:57 AM (26 w, 2 d)

Recent Activity

Jul 29 2018

aniketp updated the diff for D16448: Add tests for various other ioctls for auditpipe(4).
  • Add auditable startup and closeup events if auditd(8) was not already running
Jul 29 2018, 1:04 PM

Jul 28 2018

aniketp accepted D16486: Disable -Wcast-align in libbsm and libauditd.
Jul 28 2018, 7:55 PM
aniketp requested changes to D16486: Disable -Wcast-align in libbsm and libauditd.
Jul 28 2018, 6:10 PM

Jul 27 2018

aniketp created D16475: Introduce test-program for auditon(2) syscall.
Jul 27 2018, 9:04 PM
aniketp added inline comments to D16448: Add tests for various other ioctls for auditpipe(4).
Jul 27 2018, 8:41 PM
aniketp updated the diff for D16448: Add tests for various other ioctls for auditpipe(4).
  • Move auditon code before starting calling AUDITPIPE_FLUSH
Jul 27 2018, 8:41 PM
aniketp updated the diff for D16448: Add tests for various other ioctls for auditpipe(4).
  • Check if auditing was enabled before AUDITPIPE_FLUSH test
Jul 27 2018, 8:31 PM

Jul 26 2018

aniketp created D16448: Add tests for various other ioctls for auditpipe(4).
Jul 26 2018, 7:06 AM

Jul 23 2018

aniketp created D16407: Fix the incorrect logical operator in AUDITPIPE_SET_QLIMIT ioctl.
Jul 23 2018, 4:24 PM

Jul 22 2018

aniketp updated the diff for D16395: Introduce test-program for auditpipe(4).
  • Move cleanup part of auditpipe_set_qlimit to test case cleanup section
Jul 22 2018, 6:51 PM
aniketp created D16395: Introduce test-program for auditpipe(4).
Jul 22 2018, 4:31 PM
aniketp accepted D16388: Fix audit of chflagsat, lgetfh, and setfib.

Woah! This was easy. Though I guess later on, we can add these lines to eliminate false positives from lgetfh(2)

pid = getpid();
snprintf(extregex, sizeof(extregex), "lgetfh.*%d.*return,success", pid);

Also, many more such tests can be improved similarly.

Jul 22 2018, 12:21 PM

Jul 21 2018

aniketp updated the diff for D16379: Add initial expected failures cases for chflagsat(2), lgetfh(2), setfib(2).
  • Include PR number with the expected failure message
Jul 21 2018, 3:59 PM
aniketp updated the diff for D16381: Add default case and ENOSYS expected cases for auditon(2) system call.
  • Rename auditon_{success/failure} to auditon_default_{success/failure}
Jul 21 2018, 3:52 PM
aniketp created D16381: Add default case and ENOSYS expected cases for auditon(2) system call.
Jul 21 2018, 2:38 PM
aniketp created D16379: Add initial expected failures cases for chflagsat(2), lgetfh(2), setfib(2).
Jul 21 2018, 1:03 PM

Jul 20 2018

aniketp updated the diff for D16255: Separate the tests for auditon(2) based on individual commands.
  • Comment describing the latest change in auditon_setcond_success
Jul 20 2018, 6:10 PM
aniketp updated the diff for D16255: Separate the tests for auditon(2) based on individual commands.
  • Fix the above described bug in auditon_setcond_success
Jul 20 2018, 6:05 PM

Jul 19 2018

aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Fix 'pointer from integer without a cast' build failure on sparc64
Jul 19 2018, 5:42 PM
aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Fix build for ARM and Sparc64 architectures
Jul 19 2018, 4:07 PM

Jul 17 2018

aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Replace ARM_SYNC_ICACHE with ARM_DRAIN_WRITEBUF as the syscall argument

ARM_SYNC_ICACHE for some reason breaks build on arm as pointed out by @asomers. It can't find the declaration of the corresponding struct and hence, assumes that the test-program is declaring the struct instead of defining it.

Jul 17 2018, 7:24 PM
aniketp added inline comments to D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Jul 17 2018, 3:00 PM
aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Changes as suggested in the previous review
Jul 17 2018, 11:00 AM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Grammatical corrections in the same comment
Jul 17 2018, 8:47 AM
aniketp added a comment to D16099: Introduce tests for Capability mode System calls and _exit(2).
Jul 17 2018, 8:40 AM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Improvements in setvbuf's comments
Jul 17 2018, 8:40 AM

Jul 16 2018

aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Remove redundant header includes that were added for ioctl operations which are not required anymore
Jul 16 2018, 10:47 PM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Disable I/O buffering for the whole test-suite
Jul 16 2018, 10:44 PM
aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Use respective args instead of a common void *sysarg
Jul 16 2018, 10:37 PM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Some more updates to the recent comments
Jul 16 2018, 8:35 PM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Forgot a comma in _exit(2) test case comments
Jul 16 2018, 8:33 PM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Disable I/O buffering from /dev/auditpipe for read operations for cap_enter(2) and _exit(2)
Jul 16 2018, 8:31 PM

Jul 14 2018

aniketp updated the diff for D16255: Separate the tests for auditon(2) based on individual commands.
  • Same change as above for the missed mallocs
Jul 14 2018, 4:59 PM
aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Add the missed sysnum for sparc64 tests
Jul 14 2018, 4:46 PM
aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.

Add the missed \#endif statement

Jul 14 2018, 4:39 PM
aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.

Include Sparc64 in the possible architectures for sysarch(2)

Jul 14 2018, 4:34 PM
aniketp added inline comments to D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Jul 14 2018, 3:02 PM
aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.

Create a single success mode test case for sysarch(2) with sysnum being dependent on the system architecture

Jul 14 2018, 12:08 PM
aniketp updated the diff for D16255: Separate the tests for auditon(2) based on individual commands.

Store auditinfo in stack instead of allocating heap memory

Jul 14 2018, 11:38 AM

Jul 13 2018

aniketp updated the summary of D16255: Separate the tests for auditon(2) based on individual commands.
Jul 13 2018, 1:37 PM
aniketp created D16255: Separate the tests for auditon(2) based on individual commands.
Jul 13 2018, 1:36 PM
aniketp added a comment to D16222: auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command.

I guess in one of the later tests, I'll have to fix this too: tests/sys/audit/administrative.c#L389

Jul 13 2018, 12:04 PM
aniketp updated the test plan for D16222: auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command.
Jul 13 2018, 12:02 PM

Jul 11 2018

aniketp accepted D16210: Don't acquire evclass_lock with a spinlock held.
Jul 11 2018, 2:33 PM
aniketp added a comment to D16210: Don't acquire evclass_lock with a spinlock held.

Oh, no. _exit(2) wasn't failing previously. In fact, I hadn't even created its test. I apparently overlooked it just because process-control has a _lot_ of syscalls.

Jul 11 2018, 1:59 PM
aniketp retitled D16222: auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command from Fix AUDIT_CNT bit negation's misplacement in A_SETPOLICY:auditon(2) to auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command.
Jul 11 2018, 11:57 AM
aniketp created D16222: auditon(2): Fix the misplacement of negation symbol in A_SETPOLICY command.
Jul 11 2018, 11:56 AM
aniketp added a comment to D16210: Don't acquire evclass_lock with a spinlock held.

Other than the (possible?) repetition of AUDIT_SYSCALL_EXIT in kern_exit.c. The issue with exa(1) seems to have gone away. Also, the regression tests for audit of _exit(2) in D16099 don't fail on introducing this change.

Jul 11 2018, 8:07 AM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Updates in _exit(2) test case comment
Jul 11 2018, 7:57 AM
aniketp retitled D16099: Introduce tests for Capability mode System calls and _exit(2) from Introduce tests for Capability mode System calls to Introduce tests for Capability mode System calls and _exit(2).
Jul 11 2018, 7:33 AM
aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Add tests for _exit(2) using the AUDITPIPE_FLUSH approach (for now)
Jul 11 2018, 7:32 AM
aniketp added inline comments to D16210: Don't acquire evclass_lock with a spinlock held.
Jul 11 2018, 6:57 AM

Jul 10 2018

aniketp updated the diff for D16099: Introduce tests for Capability mode System calls and _exit(2).
  • Add the AUDITPIPE_FLUSH ioctl after calling cap_enter() to eliminate the buffering issue
Jul 10 2018, 8:47 AM

Jul 4 2018

aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Add test for audit(2) in failure case
Jul 4 2018, 3:09 PM

Jul 3 2018

aniketp updated the diff for D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
  • Updates in Copyright
Jul 3 2018, 7:24 PM
aniketp created D16116: Introduce tests for sysctl(3), and sysarch(2) for AMD64, i386, ARM & MIPS architectures.
Jul 3 2018, 7:15 PM

Jul 2 2018

aniketp created D16099: Introduce tests for Capability mode System calls and _exit(2).
Jul 2 2018, 5:41 PM

Jul 1 2018

aniketp created D16086: Add tests for procctl(2): process-control audit class.
Jul 1 2018, 3:38 PM

Jun 27 2018

aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.
  • Initialize ec_class to 0
Jun 27 2018, 5:28 PM
aniketp updated the diff for D16035: audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2).
  • Update comment explaining why we are ignoring the output of first setsid()
Jun 27 2018, 5:26 PM
aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.

Initialize evclass to get the event-class mapping for auditon(2)

Jun 27 2018, 5:11 PM
aniketp updated the diff for D16035: audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2).
  • Call setsid() prematurely to intentionally fail the tests
Jun 27 2018, 4:56 PM
aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.
  • Remove placeholder comment about not testing mount(2), nmount(2) in success case

These will be dealt later on

Jun 27 2018, 4:19 PM
aniketp updated the summary of D15898: Add tests for miscellaneous administrative system calls.
Jun 27 2018, 3:04 PM
aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.
  • Add tests for clock_settime(2)
Jun 27 2018, 2:53 PM
aniketp updated the summary of D15898: Add tests for miscellaneous administrative system calls.
Jun 27 2018, 2:00 PM
aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.
  • Add tests for auditon(2), swapon(2) and swapoff(2)

Note: swapon(2) and swapoff(2) require block device, hence can't be tested
in success case since block devices are gone (from FreeBSD)

Jun 27 2018, 1:59 PM
aniketp created D16035: audit(4): Add tests for setsid(2), wait4(2), wait6(2) and kill(2).
Jun 27 2018, 11:30 AM
aniketp updated the diff for D16000: Fix wrong sizeof() argument and descriptor leak reported by Coverity.

Remove 80 bytes hardcoded initialization from buff array

Jun 27 2018, 4:30 AM

Jun 25 2018

aniketp updated the diff for D16000: Fix wrong sizeof() argument and descriptor leak reported by Coverity.

Declare buff as an array instead of a pointer, to be able to correctly pass the value to nbytes argument for extattr_set_*

Jun 25 2018, 11:04 AM

Jun 24 2018

aniketp created D16000: Fix wrong sizeof() argument and descriptor leak reported by Coverity.
Jun 24 2018, 9:10 PM

Jun 23 2018

aniketp updated the summary of D15966: Introduce test-program for process-control group of system calls.
Jun 23 2018, 8:36 PM
aniketp updated the diff for D15966: Introduce test-program for process-control group of system calls.

Add test for setpgrp_success

Jun 23 2018, 8:35 PM
aniketp added inline comments to D15966: Introduce test-program for process-control group of system calls.
Jun 23 2018, 7:27 PM
aniketp updated the diff for D15966: Introduce test-program for process-control group of system calls.

Update ngroups for setgroups_success as 5 instead of 100

Jun 23 2018, 7:26 PM
aniketp updated the diff for D15966: Introduce test-program for process-control group of system calls.

Changes according to the inline comments

Jun 23 2018, 2:26 AM
aniketp updated the diff for D15963: Add tests for pipe(2) and POSIX standardized IPC syscalls.

Remove -1 from strlcat() in shm_inlink_success test case

Jun 23 2018, 1:52 AM

Jun 22 2018

aniketp updated the diff for D15963: Add tests for pipe(2) and POSIX standardized IPC syscalls.

Changes as suggested in the inline comments

Jun 22 2018, 5:11 PM
aniketp updated the summary of D15966: Introduce test-program for process-control group of system calls.
Jun 22 2018, 4:05 PM
aniketp updated the diff for D15966: Introduce test-program for process-control group of system calls.

Add test for successful invocation of setlogin(2)

Jun 22 2018, 4:04 PM
aniketp updated the summary of D15966: Introduce test-program for process-control group of system calls.
Jun 22 2018, 3:45 PM
aniketp created D15966: Introduce test-program for process-control group of system calls.
Jun 22 2018, 3:45 PM
aniketp created D15963: Add tests for pipe(2) and POSIX standardized IPC syscalls.
Jun 22 2018, 4:51 AM
aniketp updated the summary of D15898: Add tests for miscellaneous administrative system calls.
Jun 22 2018, 4:27 AM
aniketp added inline comments to D15898: Add tests for miscellaneous administrative system calls.
Jun 22 2018, 4:27 AM

Jun 21 2018

aniketp updated the diff for D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.

Define _WANT_SEMUN instead of declaring union semun in the test program

Jun 21 2018, 11:59 PM
aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.

Shift the location of close(filedesc2) to right after opening it

Jun 21 2018, 11:25 PM
aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.

Update the test case for acct_success

Jun 21 2018, 4:01 PM
aniketp updated the diff for D15898: Add tests for miscellaneous administrative system calls.
  • Add test for acct_success. Use sysctlbyname(3) to retrieve the accounting status
  • Minor changes in auditctl_success test case cleanup
Jun 21 2018, 8:51 AM

Jun 20 2018

aniketp added inline comments to D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
Jun 20 2018, 3:51 PM
aniketp updated the diff for D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
  • Remove semarg from GETVAL, GETPID, GETZCNT, GETNCNT
  • Initialize semvals in SETALL by first calling GETALL
Jun 20 2018, 3:51 PM
aniketp added inline comments to D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
Jun 20 2018, 11:55 AM
aniketp updated the diff for D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.

Replace arg with semarg; And some minor changes

Jun 20 2018, 11:51 AM
aniketp added inline comments to D15898: Add tests for miscellaneous administrative system calls.
Jun 20 2018, 11:06 AM

Jun 19 2018

aniketp updated the diff for D15895: Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2).

Use bzero from within the function init_msghdr()

Jun 19 2018, 5:12 PM
aniketp updated the diff for D15895: Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2).

Lots of changes

  • Typecast changes to socklen_t
  • bzeroed struct msghdrs
  • Some tweaks in hex format identifiers and variable namings
Jun 19 2018, 3:51 PM
aniketp created D15898: Add tests for miscellaneous administrative system calls.
Jun 19 2018, 6:07 AM
aniketp created D15897: System V standardized IPC syscalls concerned with manipulating semaphore sets.
Jun 19 2018, 3:57 AM
aniketp updated the diff for D15893: Add tests for utimes(2), futimes(2), lutimes(2), futimesat(2), mprotect(2) and undelete(2).

Use PROT_NONE instead of 0 for mprotect_success

Jun 19 2018, 3:04 AM
aniketp created D15895: Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2).
Jun 19 2018, 1:41 AM