Page MenuHomeFreeBSD

Fix audit of chflagsat, lgetfh, and setfib
ClosedPublic

Authored by asomers on Jul 22 2018, 5:00 AM.
Tags
None
Referenced Files
F151013590: D16388.id45685.diff
Sun, Apr 5, 11:20 AM
F150993098: D16388.id45671.diff
Sun, Apr 5, 8:44 AM
Unknown Object (File)
Fri, Apr 3, 6:09 AM
Unknown Object (File)
Fri, Apr 3, 2:29 AM
Unknown Object (File)
Tue, Mar 24, 6:56 PM
Unknown Object (File)
Thu, Mar 19, 3:23 PM
Unknown Object (File)
Sat, Mar 14, 11:09 PM
Unknown Object (File)
Sat, Mar 14, 5:54 AM
Subscribers

Details

Summary

Fix audit of chflagsat, lgetfh, and setfib

These syscalls were always supposed to have been auditted, but due to
oversights never were.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Woah! This was easy. Though I guess later on, we can add these lines to eliminate false positives from lgetfh(2)

pid = getpid();
snprintf(extregex, sizeof(extregex), "lgetfh.*%d.*return,success", pid);

Also, many more such tests can be improved similarly.

This revision is now accepted and ready to land.Jul 22 2018, 12:21 PM
This revision was automatically updated to reflect the committed changes.