Page MenuHomeFreeBSD

Fix audit of chflagsat, lgetfh, and setfib
ClosedPublic

Authored by asomers on Jul 22 2018, 5:00 AM.

Details

Summary

Fix audit of chflagsat, lgetfh, and setfib

These syscalls were always supposed to have been auditted, but due to
oversights never were.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Jul 22 2018, 5:00 AM
aniketp accepted this revision.EditedJul 22 2018, 12:21 PM

Woah! This was easy. Though I guess later on, we can add these lines to eliminate false positives from lgetfh(2)

pid = getpid();
snprintf(extregex, sizeof(extregex), "lgetfh.*%d.*return,success", pid);

Also, many more such tests can be improved similarly.

This revision is now accepted and ready to land.Jul 22 2018, 12:21 PM
This revision was automatically updated to reflect the committed changes.