Page MenuHomeFreeBSD

Fix audit of chflagsat, lgetfh, and setfib
ClosedPublic

Authored by asomers on Jul 22 2018, 5:00 AM.
Tags
None
Referenced Files
F81593807: D16388.diff
Thu, Apr 18, 4:15 PM
Unknown Object (File)
Sat, Apr 6, 6:28 PM
Unknown Object (File)
Feb 24 2024, 2:27 AM
Unknown Object (File)
Feb 24 2024, 2:27 AM
Unknown Object (File)
Feb 24 2024, 2:27 AM
Unknown Object (File)
Feb 23 2024, 8:50 PM
Unknown Object (File)
Dec 20 2023, 2:42 AM
Unknown Object (File)
Dec 10 2023, 8:56 PM
Subscribers

Details

Summary

Fix audit of chflagsat, lgetfh, and setfib

These syscalls were always supposed to have been auditted, but due to
oversights never were.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18243
Build 17971: arc lint + arc unit

Event Timeline

Woah! This was easy. Though I guess later on, we can add these lines to eliminate false positives from lgetfh(2)

pid = getpid();
snprintf(extregex, sizeof(extregex), "lgetfh.*%d.*return,success", pid);

Also, many more such tests can be improved similarly.

This revision is now accepted and ready to land.Jul 22 2018, 12:21 PM
This revision was automatically updated to reflect the committed changes.