Add tests for sendmsg(2), recvmsg(2), shutdown(2), sendfile(2)

[aniketp]

Summary

This revision introduces atf-c(3) tests for final set of system calls categorized within
network audit class. The system calls, as mentioned in the title are:

• sendmsg(2)
• recvmsg(2)
• sendfile(2)
• shutdown(2)

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

[asomers]

tests/sys/audit/network.c

66 ↗

(On Diff #44052)

ALLCAPS is normally reserved for constants. Variables should be lower case.

76 ↗

(On Diff #44052)

s/addres/address

78 ↗

(On Diff #44052)

You should zero out hdrbuf's other fields, either explictly or by using bzero before initializing anything.

78 ↗

(On Diff #44052)

This is the wrong type. sizeof returns a size_t, not ssize_t. And msg_name is a socklen_t. So you'll obviously have to cast size_t to socklen_t at some point, but there's no reason to cast to ssize_t first.

924 ↗

(On Diff #44052)

Better to use sizeof(data). More future-proof that way.

938 ↗

(On Diff #44052)

Another good opportunity for "%#x".

[aniketp]

Lots of changes

• Typecast changes to socklen_t
• bzeroed struct msghdrs
• Some tweaks in hex format identifiers and variable namings

[asomers]

tests/sys/audit/network.c

859 ↗

(On Diff #44078)

You neglected to zero out sendbuf here, too. It would probably be easier to do it from within init_msghdr.

[aniketp]

Use bzero from within the function init_msghdr()

[asomers]

LGTM. sendmsg(2), by the way, is my least favorite system call of all time.