Page MenuHomeFreeBSD

Disable -Wcast-align in libbsm and libauditd
ClosedPublic

Authored by asomers on Jul 28 2018, 5:54 PM.

Details

Summary

Disable -Wcast-align in libbsm and libauditd

Along with some pending upstream changes, this will allow raising the WARNS
level.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers created this revision.Jul 28 2018, 5:54 PM
aniketp requested changes to this revision.Jul 28 2018, 6:10 PM
aniketp added inline comments.
lib/libauditd/Makefile
27 ↗(On Diff #45956)

s/cating/casting

lib/libbsm/Makefile
185 ↗(On Diff #45956)

Same here!

This revision now requires changes to proceed.Jul 28 2018, 6:10 PM
cem added inline comments.Jul 28 2018, 6:21 PM
lib/libauditd/Makefile
30–32 ↗(On Diff #45956)

Isn't the next best thing disabling it in only one file?

Does CWARNFLAGS.auditd_lib.c+= -Wno-cast-align work?

Similar below.

asomers updated this revision to Diff 45959.Jul 28 2018, 7:33 PM

Respond to comments

cem accepted this revision.Jul 28 2018, 7:55 PM

LGTM assuming the CWARNFLAGS.foo construct actually works — I did not test it :-).

aniketp accepted this revision.Jul 28 2018, 7:55 PM
This revision is now accepted and ready to land.Jul 28 2018, 7:55 PM
This revision was automatically updated to reflect the committed changes.