Paths

Table of Contentst

Disable -Wcast-align in libbsm and libauditd
ClosedPublic
Actions

Authored by asomers on Jul 28 2018, 5:54 PM.

Details

Reviewers

cem
aniketp

Commits

rS336838: Disable -Wcast-align in libbsm and libauditd

Summary

Disable -Wcast-align in libbsm and libauditd

Along with some pending upstream changes, this will allow raising the WARNS
level.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Jul 28 2018, 5:54 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 28 2018, 5:54 PM

Harbormaster completed remote builds in B18397: Diff 45956.Jul 28 2018, 5:54 PM

aniketp requested changes to this revision.Jul 28 2018, 6:10 PM

aniketp added inline comments.

lib/libauditd/Makefile
27 ↗	(On Diff #45956)	s/cating/casting
lib/libbsm/Makefile
185 ↗	(On Diff #45956)	Same here!

This revision now requires changes to proceed.Jul 28 2018, 6:10 PM

cem added inline comments.Jul 28 2018, 6:21 PM

lib/libauditd/Makefile
30–32 ↗	(On Diff #45956)	Isn't the next best thing disabling it in only one file? Does `CWARNFLAGS.auditd_lib.c+= -Wno-cast-align` work? Similar below.

Respond to comments

Harbormaster completed remote builds in B18400: Diff 45959.Jul 28 2018, 7:33 PM

LGTM assuming the CWARNFLAGS.foo construct actually works — I did not test it :-).

aniketp accepted this revision.Jul 28 2018, 7:55 PM

This revision is now accepted and ready to land.Jul 28 2018, 7:55 PM

Closed by commit rS336838: Disable -Wcast-align in libbsm and libauditd (authored by asomers). · Explain WhyJul 28 2018, 8:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libauditd/

Makefile

7 lines

libbsm/

Makefile

7 lines

Diff 45962

View Options

head/lib/libauditd/Makefile