Page MenuHomeFreeBSD
Differential D16395

Introduce test-program for auditpipe(4)
ClosedPublic
Actions

Authored by aniketp on Jul 22 2018, 4:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 19, 7:52 PM
Unknown Object (File)
Sat, Dec 7, 2:47 PM
Unknown Object (File)
Sat, Dec 7, 2:47 PM
Unknown Object (File)
Sat, Dec 7, 2:47 PM
Unknown Object (File)
Sat, Dec 7, 2:47 PM
Unknown Object (File)
Sat, Dec 7, 2:33 PM
Unknown Object (File)
Fri, Nov 29, 1:33 AM
Unknown Object (File)
Nov 12 2024, 11:14 PM
View All 81 Files
Subscribers
gnn
imp
rwatson

Details

Reviewers
asomers
Commits
rS339094: MFC r336728:
rS336728: Introduce test program for auditpipe(4)
Summary

This revision introduces test-program for auditpipe(4). The tests currently only test initial
ioctls provided by auditpipe(4) and lay a foundation on how the tests will be organised later on.

The ioctls currently tested are:

  • AUDITPIPE_GET_QLEN
  • AUDITPIPE_GET_QLIMIT
  • AUDITPIPE_SET_QLIMIT
  • AUDITPIPE_GET_QLIMIT_MAX
  • AUDITPIPE_GET_QLIMIT_MIN
  • AUDITPIPE_GET_MAXAUDITDATA
Test Plan

Execute make && make install from test/sys/auditpipe.
Execute kyua test from /usr/tests/sys/auditpipe. All testcases should succeed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aniketp created this revision.Jul 22 2018, 4:31 PM
Harbormaster completed remote builds in B18252: Diff 45692.Jul 22 2018, 4:31 PM
asomers requested changes to this revision.Jul 22 2018, 5:16 PM
asomers added inline comments.
tests/sys/auditpipe/auditpipe_test.c
90 ↗(On Diff #45692)

Why do you think it's probably 128? How about setting it to curr_qlimit - 1 instead of hardcoding 128?

99 ↗(On Diff #45692)

This should go in a cleanup step, not in the test body.

This revision now requires changes to proceed.Jul 22 2018, 5:16 PM
aniketp updated this revision to Diff 45694.Jul 22 2018, 6:51 PM
  • Move cleanup part of auditpipe_set_qlimit to test case cleanup section
Harbormaster completed remote builds in B18253: Diff 45694.Jul 22 2018, 6:51 PM
asomers accepted this revision.Jul 22 2018, 7:34 PM
This revision is now accepted and ready to land.Jul 22 2018, 7:34 PM
Closed by commit rS336728: Introduce test program for auditpipe(4) (authored by asomers). · Explain WhyJul 26 2018, 12:16 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptJul 26 2018, 12:16 AM

Revision Contents
Changeset List

PathSize
head/
etc/
mtree/
2 lines
tests/
sys/
1 line
auditpipe/
10 lines
185 lines

Diff 45853

View Options

head/etc/mtree/BSD.tests.dist

Loading...
View Options

head/tests/sys/Makefile

Loading...
View Options

head/tests/sys/auditpipe/Makefile

Loading...
View Options

head/tests/sys/auditpipe/auditpipe_test.c

Loading...