Page MenuHomeFreeBSD

Introduce test-program for auditpipe(4)
ClosedPublic

Authored by aniketp on Jul 22 2018, 4:31 PM.

Details

Summary

This revision introduces test-program for auditpipe(4). The tests currently only test initial
ioctls provided by auditpipe(4) and lay a foundation on how the tests will be organised later on.

The ioctls currently tested are:

  • AUDITPIPE_GET_QLEN
  • AUDITPIPE_GET_QLIMIT
  • AUDITPIPE_SET_QLIMIT
  • AUDITPIPE_GET_QLIMIT_MAX
  • AUDITPIPE_GET_QLIMIT_MIN
  • AUDITPIPE_GET_MAXAUDITDATA
Test Plan

Execute make && make install from test/sys/auditpipe.
Execute kyua test from /usr/tests/sys/auditpipe. All testcases should succeed.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

aniketp created this revision.Jul 22 2018, 4:31 PM
asomers requested changes to this revision.Jul 22 2018, 5:16 PM
asomers added inline comments.
tests/sys/auditpipe/auditpipe_test.c
90 ↗(On Diff #45692)

Why do you think it's probably 128? How about setting it to curr_qlimit - 1 instead of hardcoding 128?

99 ↗(On Diff #45692)

This should go in a cleanup step, not in the test body.

This revision now requires changes to proceed.Jul 22 2018, 5:16 PM
aniketp updated this revision to Diff 45694.Jul 22 2018, 6:51 PM
  • Move cleanup part of auditpipe_set_qlimit to test case cleanup section
asomers accepted this revision.Jul 22 2018, 7:34 PM
This revision is now accepted and ready to land.Jul 22 2018, 7:34 PM
This revision was automatically updated to reflect the committed changes.