Paths

Table of Contentst

net/subnetcalc: update to 2.4.9
ClosedPublic
Actions

Authored by fernape on Jun 18 2018, 3:12 PM.

Details

Reviewers

tcberner
tz

Commits

rP473848: net/subnetcalc: update to 2.4.9

Summary

Sent by freebsd_ports@k-worx.org in PR 229108

Awaiting maintainer (dreibh@iem.uni-due.de) approval

Test Plan

portlint -AC OK
poudriere builds for {10.4,11.1}{amd64,i386}, 12i386 OK
run test in 10.4 amd64 OK

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fernape created this revision.Jun 18 2018, 3:12 PM

Herald added a subscriber: mat. · View Herald TranscriptJun 18 2018, 3:12 PM

Harbormaster completed remote builds in B17407: Diff 44005.Jun 18 2018, 3:12 PM

tcberner requested changes to this revision.Jun 18 2018, 6:03 PM

tcberner added inline comments.

net/subnetcalc/Makefile
17 ↗	(On Diff #44005)	^prefer `cmake:outsource` if it works
22 ↗	(On Diff #44005)	^ you should be able to just set `CMAKE_INSTALL_MANDIR` to something sensible instead of patching.

This revision now requires changes to proceed.Jun 18 2018, 6:03 PM

Use outsource building
Use CMAKE_INSTALL_MANDIR* variables instead of post-patch

Harbormaster completed remote builds in B17449: Diff 44084.Jun 19 2018, 5:13 PM

tcberner added inline comments.Jun 19 2018, 5:43 PM

net/subnetcalc/Makefile
18 ↗	(On Diff #44084)	^once should be enough :) -- also, use "\" to break the line, and not add `CMAKE_ARGS+=` -- makes it more readable.

Set DCMAKE_INSTALL_MANDIR only

Harbormaster completed remote builds in B17456: Diff 44099.Jun 19 2018, 8:11 PM

tcberner accepted this revision.Jun 21 2018, 4:39 PM

This revision is now accepted and ready to land.Jun 21 2018, 4:39 PM

Closed by commit rP473848: net/subnetcalc: update to 2.4.9 (authored by fernape). · Explain WhyJul 3 2018, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

net/

subnetcalc/

Makefile

8 lines

distinfo

6 lines

Diff 44816

View Options

head/net/subnetcalc/Makefile